Re: RFR: 8307980: Rotate Transformation never invalidates inverseCache [v3]
On Thu, 28 Mar 2024 11:23:02 GMT, Lukasz Kostyra wrote: >> Fixed as described in the issue + added tests to check for this scenario >> with all Transform sub classes. Since the test scenario slightly exceeding >> the regular parametrized testing of `TransformOperationsTest` I decided to >> implement the tests in a separate class. >> >> I didn't manage to reproduce the issue with other Transform sub classes, so >> it seems to only affect `Rotate`. Also checked by looking at the code, only >> `Rotate` was affected by this bug. As such, without 08ba284 only >> `testTransformInverseCache_Rotate` fails, while others succeed. With the >> fix, all tests pass. >> >> Ran the whole test suite afterwards and didn't notice any changes to test >> results after introducing the fix. > > Lukasz Kostyra has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing EOF newline Marked as reviewed by kcr (Lead). - PR Review: https://git.openjdk.org/jfx/pull/1392#pullrequestreview-1966034023
Re: RFR: 8307980: Rotate Transformation never invalidates inverseCache [v3]
> Fixed as described in the issue + added tests to check for this scenario with > all Transform sub classes. Since the test scenario slightly exceeding the > regular parametrized testing of `TransformOperationsTest` I decided to > implement the tests in a separate class. > > I didn't manage to reproduce the issue with other Transform sub classes, so > it seems to only affect `Rotate`. Also checked by looking at the code, only > `Rotate` was affected by this bug. As such, without 08ba284 only > `testTransformInverseCache_Rotate` fails, while others succeed. With the fix, > all tests pass. > > Ran the whole test suite afterwards and didn't notice any changes to test > results after introducing the fix. Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision: Add missing EOF newline - Changes: - all: https://git.openjdk.org/jfx/pull/1392/files - new: https://git.openjdk.org/jfx/pull/1392/files/cd8fdde8..17bfefc0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx=1392=02 - incr: https://webrevs.openjdk.org/?repo=jfx=1392=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1392.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1392/head:pull/1392 PR: https://git.openjdk.org/jfx/pull/1392
