Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v6]
On Mon, 29 Jan 2024 07:31:53 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation of nodes and fixed the issue in >> `getHitInfo()` to calculate correct hit test values. >> >> Added system tests to validate the changes. > > Karthik P K has updated the pull request incrementally with one additional > commit since the last revision: > > Fix issue with RTL text within LTR text The issue should be fixed now. I tested using monkey tester, my local standalone tests and system tests. Let me know if you find issue in any case. - PR Comment: https://git.openjdk.org/jfx/pull/1323#issuecomment-1918809350
Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v6]
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation > conditions were not considered, hence hit test values such as character index > and insertion index values were incorrect. > > Added checks for RTL orientation of nodes and fixed the issue in > `getHitInfo()` to calculate correct hit test values. > > Added system tests to validate the changes. Karthik P K has updated the pull request incrementally with one additional commit since the last revision: Fix issue with RTL text within LTR text - Changes: - all: https://git.openjdk.org/jfx/pull/1323/files - new: https://git.openjdk.org/jfx/pull/1323/files/b08de73c..a58f754e Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1323&range=05 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1323&range=04-05 Stats: 33 lines in 2 files changed: 13 ins; 12 del; 8 mod Patch: https://git.openjdk.org/jfx/pull/1323.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1323/head:pull/1323 PR: https://git.openjdk.org/jfx/pull/1323
