Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+), and fixes the dragging issue on Wayland. > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Revert changes and add touch mask to gdk pointer grab function All ok. - Marked as reviewed by tsayao (Committer). PR Review: https://git.openjdk.org/jfx/pull/1305#pullrequestreview-1900802532
Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+), and fixes the dragging issue on Wayland. > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Revert changes and add touch mask to gdk pointer grab function Marked as reviewed by kcr (Lead). - PR Review: https://git.openjdk.org/jfx/pull/1305#pullrequestreview-1895996832
Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+), and fixes the dragging issue on Wayland. > > Jose Pereda has updated the pull request incrementally with one additional > commit since the last revision: > > Revert changes and add touch mask to gdk pointer grab function This is a much less intrusive fix. The tests are indeed green now with no regressions. I don't have access to a Lunux system with a touch enabled display to test it on, but as long as you've verified that it fixes the problem, it's a +1 from me. - PR Review: https://git.openjdk.org/jfx/pull/1305#pullrequestreview-1894647152
Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and > `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and > wrapped functions for GTK 3.20+ (so systems without it still run with GTK > 3.8+), and fixes the dragging issue on Wayland. Jose Pereda has updated the pull request incrementally with one additional commit since the last revision: Revert changes and add touch mask to gdk pointer grab function - Changes: - all: https://git.openjdk.org/jfx/pull/1305/files - new: https://git.openjdk.org/jfx/pull/1305/files/f8ffe87f..ca5766fd Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx=1305=03 - incr: https://webrevs.openjdk.org/?repo=jfx=1305=02-03 Stats: 105 lines in 5 files changed: 1 ins; 93 del; 11 mod Patch: https://git.openjdk.org/jfx/pull/1305.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1305/head:pull/1305 PR: https://git.openjdk.org/jfx/pull/1305
