Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v4]
On Fri, 23 Feb 2024 21:58:37 GMT, Michael Strauß wrote: >> Platform preferences detection doesn't pick up effective macOS system >> preferences if AWT owns the NSApplication and has set its NSAppearance to a >> fixed value. >> >> The workaround is to set the system property >> "apple.awt.application.appearance=system". >> >> If this property is not set, the following warning will be emitted if a >> JavaFX application attempts to use the platform preferences API: >> >> >> WARNING: Reported preferences may not reflect the macOS system preferences >> unless the sytem >> property apple.awt.application.appearance=system is set. This warning can be >> disabled by >> setting javafx.preferences.suppressAppleAwtWarning=true. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > Break warning message into separate lines Verified that the settings are working as expected and warning only appears once. Looks good to me. - Marked as reviewed by mfox (Committer). PR Review: https://git.openjdk.org/jfx/pull/1367#pullrequestreview-1968987071
Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v4]
On Fri, 23 Feb 2024 21:58:37 GMT, Michael Strauß wrote: >> Platform preferences detection doesn't pick up effective macOS system >> preferences if AWT owns the NSApplication and has set its NSAppearance to a >> fixed value. >> >> The workaround is to set the system property >> "apple.awt.application.appearance=system". >> >> If this property is not set, the following warning will be emitted if a >> JavaFX application attempts to use the platform preferences API: >> >> >> WARNING: Reported preferences may not reflect the macOS system preferences >> unless the sytem >> property apple.awt.application.appearance=system is set. This warning can be >> disabled by >> setting javafx.preferences.suppressAppleAwtWarning=true. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > Break warning message into separate lines I can review this. - PR Comment: https://git.openjdk.org/jfx/pull/1367#issuecomment-2023250420
Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v4]
On Fri, 23 Feb 2024 21:58:37 GMT, Michael Strauß wrote: >> Platform preferences detection doesn't pick up effective macOS system >> preferences if AWT owns the NSApplication and has set its NSAppearance to a >> fixed value. >> >> The workaround is to set the system property >> "apple.awt.application.appearance=system". >> >> If this property is not set, the following warning will be emitted if a >> JavaFX application attempts to use the platform preferences API: >> >> >> WARNING: Reported preferences may not reflect the macOS system preferences >> unless the sytem >> property apple.awt.application.appearance=system is set. This warning can be >> disabled by >> setting javafx.preferences.suppressAppleAwtWarning=true. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > Break warning message into separate lines Pending a second reviewer. @beldenfox or @prsadhuk Would one of you be able to review? - PR Comment: https://git.openjdk.org/jfx/pull/1367#issuecomment-2021187420
Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v4]
On Fri, 23 Feb 2024 21:58:37 GMT, Michael Strauß wrote: >> Platform preferences detection doesn't pick up effective macOS system >> preferences if AWT owns the NSApplication and has set its NSAppearance to a >> fixed value. >> >> The workaround is to set the system property >> "apple.awt.application.appearance=system". >> >> If this property is not set, the following warning will be emitted if a >> JavaFX application attempts to use the platform preferences API: >> >> >> WARNING: Reported preferences may not reflect the macOS system preferences >> unless the sytem >> property apple.awt.application.appearance=system is set. This warning can be >> disabled by >> setting javafx.preferences.suppressAppleAwtWarning=true. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > Break warning message into separate lines Marked as reviewed by kcr (Lead). - PR Review: https://git.openjdk.org/jfx/pull/1367#pullrequestreview-1899133239
Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v4]
> Platform preferences detection doesn't pick up effective macOS system > preferences if AWT owns the NSApplication and has set its NSAppearance to a > fixed value. > > The workaround is to set the system property > "apple.awt.application.appearance=system". > > If this property is not set, the following warning will be emitted if a > JavaFX application attempts to use the platform preferences API: > > > WARNING: Reported preferences may not reflect the macOS system preferences > unless the sytem > property apple.awt.application.appearance=system is set. This warning can be > disabled by > setting javafx.preferences.suppressAppleAwtWarning=true. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: Break warning message into separate lines - Changes: - all: https://git.openjdk.org/jfx/pull/1367/files - new: https://git.openjdk.org/jfx/pull/1367/files/5c743df7..8fdbc624 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1367&range=03 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1367&range=02-03 Stats: 7 lines in 1 file changed: 3 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jfx/pull/1367.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1367/head:pull/1367 PR: https://git.openjdk.org/jfx/pull/1367
