[jfx22u] RFR: 8328752: Fix missing @Overrides in javafx.web
Hi all, This pull request contains a backport of commit [483c6408](https://urldefense.com/v3/__https://github.com/openjdk/jfx/commit/483c64082f7752e239c5630eb1d7895e599e5dda__;!!ACWV5N9M2RV99hQ!M-G018UM97QRsj9teiPLnY-Cdm4FuyCwtrHfyQodu1pJVqB6O1X9nx8G-xSgI9garjnyTYhFbukpa-9-Sfb6b7kZJpzddg$) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Andy Goryachev on 3 Apr 2024 and was reviewed by Kevin Rushforth and Hima Bindu Meda. Thanks! - Commit messages: - Backport 483c64082f7752e239c5630eb1d7895e599e5dda Changes: https://git.openjdk.org/jfx22u/pull/23/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u=23=00 Issue: https://bugs.openjdk.org/browse/JDK-8328752 Stats: 1058 lines in 103 files changed: 956 ins; 0 del; 102 mod Patch: https://git.openjdk.org/jfx22u/pull/23.diff Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/23/head:pull/23 PR: https://git.openjdk.org/jfx22u/pull/23
Re: RFR: 8328752: Fix missing @Overrides in javafx.web
On Wed, 3 Apr 2024 17:45:46 GMT, Hima Bindu Meda wrote: >> Fix missing @Overrides in **javafx.web**. >> >> This is still a trivial change since all the spots are identified by the IDE. > > Changes look good thank you @HimaBinduMeda ! - PR Comment: https://git.openjdk.org/jfx/pull/1424#issuecomment-2035217487
Re: RFR: 8328752: Fix missing @Overrides in javafx.web
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote: > Fix missing @Overrides in **javafx.web**. > > This is still a trivial change since all the spots are identified by the IDE. Changes look good - Marked as reviewed by hmeda (Committer). PR Review: https://git.openjdk.org/jfx/pull/1424#pullrequestreview-1977554056
Re: RFR: 8328752: Fix missing @Overrides in javafx.web
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote: > Fix missing @Overrides in **javafx.web**. > > This is still a trivial change since all the spots are identified by the IDE. These changes look good. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1424#pullrequestreview-1973976089
Re: RFR: 8328752: Fix missing @Overrides in javafx.web
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote: > Fix missing @Overrides in **javafx.web**. > > This is still a trivial change since all the spots are identified by the IDE. @HimaBinduMeda could you please take a look at this? Once reviewed, I'll start the back port chain. Thank you! - PR Comment: https://git.openjdk.org/jfx/pull/1424#issuecomment-2030415866
Re: RFR: 8328752: Fix missing @Overrides in javafx.web
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote: > Fix missing @Overrides in **javafx.web**. > > This is still a trivial change since all the spots are identified by the IDE. There are special considerations when touching files under `modules/javafx.web/src/main/native/Source/WebCore/bindings/java/dom3/java`, so it will need an extra pair of eyes. Also, this will need to be backported to earlier release trains to keep `modules/javafx.web/src/main/native/` identical for all releases. Reviewers: @kevinrushforth @HimaBinduMeda - PR Comment: https://git.openjdk.org/jfx/pull/1424#issuecomment-2015368894
RFR: 8328752: Fix missing @Overrides in javafx.web
Fix missing @Overrides in **javafx.web**. This is still a trivial change since all the spots are identified by the IDE. - Commit messages: - part 2 - 8328752: Fix missing @Overrides in javafx.web Changes: https://git.openjdk.org/jfx/pull/1424/files Webrev: https://webrevs.openjdk.org/?repo=jfx=1424=00 Issue: https://bugs.openjdk.org/browse/JDK-8328752 Stats: 1060 lines in 103 files changed: 956 ins; 0 del; 104 mod Patch: https://git.openjdk.org/jfx/pull/1424.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1424/head:pull/1424 PR: https://git.openjdk.org/jfx/pull/1424
