[jfx17u] RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-06-04 Thread Johan Vos
8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

-

Commit messages:
 - Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88

Changes: https://git.openjdk.org/jfx17u/pull/191/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx17u=191=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332328
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx17u/pull/191.diff
  Fetch: git fetch https://git.openjdk.org/jfx17u.git pull/191/head:pull/191

PR: https://git.openjdk.org/jfx17u/pull/191


[jfx21u] RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-06-04 Thread Johan Vos
8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

-

Commit messages:
 - Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88

Changes: https://git.openjdk.org/jfx21u/pull/59/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx21u=59=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332328
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx21u/pull/59.diff
  Fetch: git fetch https://git.openjdk.org/jfx21u.git pull/59/head:pull/59

PR: https://git.openjdk.org/jfx21u/pull/59


Re: [jfx22u] RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-05-16 Thread Kevin Rushforth
On Thu, 16 May 2024 22:23:40 GMT, Kevin Rushforth  wrote:

> Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for 
> future 22u backports)

@johanvos Since this is a clean backport, it doesn't need to be reviewed, but 
it does need maintainer approval. It's not an urgent fix, but until it is 
integrated, all GHA runs in this repo will fail on Linux.

-

PR Comment: https://git.openjdk.org/jfx22u/pull/29#issuecomment-2116311432


[jfx22u] RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-05-16 Thread Kevin Rushforth
Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for 
future 22u backports)

-

Commit messages:
 - Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88

Changes: https://git.openjdk.org/jfx22u/pull/29/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx22u=29=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332328
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx22u/pull/29.diff
  Fetch: git fetch https://git.openjdk.org/jfx22u.git pull/29/head:pull/29

PR: https://git.openjdk.org/jfx22u/pull/29


Re: RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-05-16 Thread Andy Goryachev
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth  wrote:

> It looks like the list of packages available in the Ubuntu 22.04 GitHub 
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't 
> find any documentation to indicate that this was intentional, but now that 
> Ubuntu 24.04 is available we can fix the problem by updating to that version. 
> We will need to do this at some point anyway, so we might as well do it now.
> 
> With this fix, the GHA test build now passes on all platforms. See the test 
> results to verify this.
> 
> Given that GHA builds are currently broken on Linux, and that this fix 
> doesn't affect the product at all (just our GHA tests), I will integrate this 
> as soon as it is approved by 1 Reviewer, as an exception to the usual 
> requirement to wait for 24 hours.

it's working for me -
https://github.com/openjdk/jfx/pull/1374/checks?check_run_id=25062333595

Thank you for fixing the setup!

-

PR Comment: https://git.openjdk.org/jfx/pull/1457#issuecomment-2115745629


Re: RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-05-16 Thread Kevin Rushforth
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth  wrote:

> It looks like the list of packages available in the Ubuntu 22.04 GitHub 
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't 
> find any documentation to indicate that this was intentional, but now that 
> Ubuntu 24.04 is available we can fix the problem by updating to that version. 
> We will need to do this at some point anyway, so we might as well do it now.
> 
> With this fix, the GHA test build now passes on all platforms. See the test 
> results to verify this.
> 
> Given that GHA builds are currently broken on Linux, and that this fix 
> doesn't affect the product at all (just our GHA tests), I will integrate this 
> as soon as it is approved by 1 Reviewer, as an exception to the usual 
> requirement to wait for 24 hours.

Hopefully we won't see any instability as a result. If we do, then we might 
need to figure out how to get gcc-13 back on Ubuntu 22.04. We should keep an 
eye out for any odd Linux failures.

-

PR Comment: https://git.openjdk.org/jfx/pull/1457#issuecomment-2115734798


Re: RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-05-16 Thread Nir Lisker
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth  wrote:

> It looks like the list of packages available in the Ubuntu 22.04 GitHub 
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't 
> find any documentation to indicate that this was intentional, but now that 
> Ubuntu 24.04 is available we can fix the problem by updating to that version. 
> We will need to do this at some point anyway, so we might as well do it now.
> 
> With this fix, the GHA test build now passes on all platforms. See the test 
> results to verify this.
> 
> Given that GHA builds are currently broken on Linux, and that this fix 
> doesn't affect the product at all (just our GHA tests), I will integrate this 
> as soon as it is approved by 1 Reviewer, as an exception to the usual 
> requirement to wait for 24 hours.

Note that the Ubuntu 24 runner is in beta: 
https://github.com/actions/runner-images#available-images.

-

PR Comment: https://git.openjdk.org/jfx/pull/1457#issuecomment-2115686652


Re: RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-05-16 Thread Andy Goryachev
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth  wrote:

> It looks like the list of packages available in the Ubuntu 22.04 GitHub 
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't 
> find any documentation to indicate that this was intentional, but now that 
> Ubuntu 24.04 is available we can fix the problem by updating to that version. 
> We will need to do this at some point anyway, so we might as well do it now.
> 
> With this fix, the GHA test build now passes on all platforms. See the test 
> results to verify this.
> 
> Given that GHA builds are currently broken on Linux, and that this fix 
> doesn't affect the product at all (just our GHA tests), I will integrate this 
> as soon as it is approved by 1 Reviewer, as an exception to the usual 
> requirement to wait for 24 hours.

looks good

-

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1457#pullrequestreview-2061224330


RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

2024-05-16 Thread Kevin Rushforth
It looks like the list of packages available in the Ubuntu 22.04 GitHub Actions 
test runner no longer includes `gcc-13` as of yesterday. I didn't find any 
documentation to indicate that this was intentional, but now that Ubuntu 24.04 
is available we can fix the problem by updating to that version. We will need 
to do this at some point anyway, so we might as well do it now.

With this fix, the GHA test build now passes on all platforms. See the test 
results to verify this.

Given that GHA builds are currently broken on Linux, and that this fix doesn't 
affect the product at all (just our GHA tests), I will integrate this as soon 
as it is approved by 1 Reviewer, as an exception to the usual requirement to 
wait for 24 hours.

-

Commit messages:
 - 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

Changes: https://git.openjdk.org/jfx/pull/1457/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx=1457=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332328
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/1457.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1457/head:pull/1457

PR: https://git.openjdk.org/jfx/pull/1457