Re: RFR: 8332748: Grammatical errors in animation API docs [v2]
On Wed, 29 May 2024 15:52:36 GMT, Lukasz Kostyra wrote: >> Checked code and fixed the gramatical error in Transition files: >> s/interval/intervals >> >> Fill and Stroke Transition had correct grammatical form already, so those >> were untouched. I couldn't find any other instances of this error in our >> javadoc documentation. > > Lukasz Kostyra has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing fix for Scale Transition Marked as reviewed by angorya (Reviewer). - PR Review: https://git.openjdk.org/jfx/pull/1466#pullrequestreview-2085812054
Re: RFR: 8332748: Grammatical errors in animation API docs [v2]
On Wed, 29 May 2024 15:52:36 GMT, Lukasz Kostyra wrote: >> Checked code and fixed the gramatical error in Transition files: >> s/interval/intervals >> >> Fill and Stroke Transition had correct grammatical form already, so those >> were untouched. I couldn't find any other instances of this error in our >> javadoc documentation. > > Lukasz Kostyra has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing fix for Scale Transition I think that 1 Reviewer is enough, but give it some time for others to have a chance to review. - Marked as reviewed by nlisker (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1466#pullrequestreview-2085810041
Re: RFR: 8332748: Grammatical errors in animation API docs
On Wed, 29 May 2024 14:23:16 GMT, Nir Lisker wrote: > `ScaleTransition` is missing a fix. Newline in the comment between "regular" and "interval" got me... Should be all good now. - PR Comment: https://git.openjdk.org/jfx/pull/1466#issuecomment-2137740568
Re: RFR: 8332748: Grammatical errors in animation API docs [v2]
> Checked code and fixed the gramatical error in Transition files: > s/interval/intervals > > Fill and Stroke Transition had correct grammatical form already, so those > were untouched. I couldn't find any other instances of this error in our > javadoc documentation. Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision: Add missing fix for Scale Transition - Changes: - all: https://git.openjdk.org/jfx/pull/1466/files - new: https://git.openjdk.org/jfx/pull/1466/files/db71ff37..295fed8c Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1466&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1466&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1466.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1466/head:pull/1466 PR: https://git.openjdk.org/jfx/pull/1466
Re: RFR: 8332748: Grammatical errors in animation API docs
On Wed, 29 May 2024 06:53:40 GMT, Lukasz Kostyra wrote: > Checked code and fixed the gramatical error in Transition files: > s/interval/intervals > > Fill and Stroke Transition had correct grammatical form already, so those > were untouched. I couldn't find any other instances of this error in our > javadoc documentation. `ScaleTransition` is missing a fix. - PR Comment: https://git.openjdk.org/jfx/pull/1466#issuecomment-2137545249
RFR: 8332748: Grammatical errors in animation API docs
Checked code and fixed the gramatical error in Transition files: s/interval/intervals Fill and Stroke Transition had correct grammatical form already, so those were untouched. I couldn't find any other instances of this error in our javadoc documentation. - Commit messages: - Fix gramatical errors in Transition javadoc comments Changes: https://git.openjdk.org/jfx/pull/1466/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1466&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332748 Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jfx/pull/1466.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1466/head:pull/1466 PR: https://git.openjdk.org/jfx/pull/1466
