Re: RFR: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy [v4]

2022-09-16 Thread Ajit Ghaisas
On Fri, 16 Sep 2022 16:13:57 GMT, Andy Goryachev  wrote:

>> Modified the tree/table view internals to suppress the horizontal (a.k.a. 
>> breadth in VirtualFlow) scroll bar when a constrained resize mode is in 
>> effect.  This change complements fixes added in 
>> [JDK-8089009](https://bugs.openjdk.org/browse/JDK-8089009) without 
>> addressing other bugs found in https://bugs.openjdk.org/browse/JDK-8292810
>
> Andy Goryachev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8089280: spaces in type parameters

Marked as reviewed by aghaisas (Reviewer).

-

PR: https://git.openjdk.org/jfx/pull/894


Re: RFR: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy [v4]

2022-09-16 Thread Kevin Rushforth
On Fri, 16 Sep 2022 16:13:57 GMT, Andy Goryachev  wrote:

>> Modified the tree/table view internals to suppress the horizontal (a.k.a. 
>> breadth in VirtualFlow) scroll bar when a constrained resize mode is in 
>> effect.  This change complements fixes added in 
>> [JDK-8089009](https://bugs.openjdk.org/browse/JDK-8089009) without 
>> addressing other bugs found in https://bugs.openjdk.org/browse/JDK-8292810
>
> Andy Goryachev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8089280: spaces in type parameters

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.org/jfx/pull/894


Re: RFR: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy [v4]

2022-09-16 Thread Andy Goryachev
> Modified the tree/table view internals to suppress the horizontal (a.k.a. 
> breadth in VirtualFlow) scroll bar when a constrained resize mode is in 
> effect.  This change complements fixes added in 
> [JDK-8089009](https://bugs.openjdk.org/browse/JDK-8089009) without addressing 
> other bugs found in https://bugs.openjdk.org/browse/JDK-8292810

Andy Goryachev has updated the pull request incrementally with one additional 
commit since the last revision:

  8089280: spaces in type parameters

-

Changes:
  - all: https://git.openjdk.org/jfx/pull/894/files
  - new: https://git.openjdk.org/jfx/pull/894/files/bf4aac22..52e48c48

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx=894=03
 - incr: https://webrevs.openjdk.org/?repo=jfx=894=02-03

  Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jfx/pull/894.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/894/head:pull/894

PR: https://git.openjdk.org/jfx/pull/894