Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v12]
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote: >> The goal of this change is to make sure jfx repo can be imported as a gradle >> project in eclipse and all nested projects in the workspace compile with no >> errors. >> >> - updated .classpath entries in apps/ >> - added utf-8 prefs in .settings/ > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > 8290473: review comments Marked as reviewed by nlisker (Reviewer). - PR: https://git.openjdk.org/jfx/pull/858
Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v12]
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote: >> The goal of this change is to make sure jfx repo can be imported as a gradle >> project in eclipse and all nested projects in the workspace compile with no >> errors. >> >> - updated .classpath entries in apps/ >> - added utf-8 prefs in .settings/ > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > 8290473: review comments rt -> jfx change is not in scope for this PR. eclipse seems to have no issues if one imports the project as a gradle project. - PR: https://git.openjdk.org/jfx/pull/858
Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v12]
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote: >> The goal of this change is to make sure jfx repo can be imported as a gradle >> project in eclipse and all nested projects in the workspace compile with no >> errors. >> >> - updated .classpath entries in apps/ >> - added utf-8 prefs in .settings/ > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > 8290473: review comments Changes look good. The only remaining issue is that the project file under the root directory is named "rt" while in Eclipse it's named "jfx". I'm not sure where Gradle is taking the name from. The problem is that you can import the "rt" project and get a duplicate project. - PR: https://git.openjdk.org/jfx/pull/858
Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v12]
> The goal of this change is to make sure jfx repo can be imported as a gradle > project in eclipse and all nested projects in the workspace compile with no > errors. > > - updated .classpath entries in apps/ > - added utf-8 prefs in .settings/ Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: 8290473: review comments - Changes: - all: https://git.openjdk.org/jfx/pull/858/files - new: https://git.openjdk.org/jfx/pull/858/files/e86cb390..ed13176e Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=858&range=11 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=858&range=10-11 Stats: 6 lines in 3 files changed: 2 ins; 4 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/858.diff Fetch: git fetch https://git.openjdk.org/jfx pull/858/head:pull/858 PR: https://git.openjdk.org/jfx/pull/858
