Re: RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote: > It looks like the list of packages available in the Ubuntu 22.04 GitHub > Actions test runner no longer includes `gcc-13` as of yesterday. I didn't > find any documentation to indicate that this was intentional, but now that > Ubuntu 24.04 is available we can fix the problem by updating to that version. > We will need to do this at some point anyway, so we might as well do it now. > > With this fix, the GHA test build now passes on all platforms. See the test > results to verify this. > > Given that GHA builds are currently broken on Linux, and that this fix > doesn't affect the product at all (just our GHA tests), I will integrate this > as soon as it is approved by 1 Reviewer, as an exception to the usual > requirement to wait for 24 hours. it's working for me - https://github.com/openjdk/jfx/pull/1374/checks?check_run_id=25062333595 Thank you for fixing the setup! - PR Comment: https://git.openjdk.org/jfx/pull/1457#issuecomment-2115745629
Re: RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote: > It looks like the list of packages available in the Ubuntu 22.04 GitHub > Actions test runner no longer includes `gcc-13` as of yesterday. I didn't > find any documentation to indicate that this was intentional, but now that > Ubuntu 24.04 is available we can fix the problem by updating to that version. > We will need to do this at some point anyway, so we might as well do it now. > > With this fix, the GHA test build now passes on all platforms. See the test > results to verify this. > > Given that GHA builds are currently broken on Linux, and that this fix > doesn't affect the product at all (just our GHA tests), I will integrate this > as soon as it is approved by 1 Reviewer, as an exception to the usual > requirement to wait for 24 hours. Hopefully we won't see any instability as a result. If we do, then we might need to figure out how to get gcc-13 back on Ubuntu 22.04. We should keep an eye out for any odd Linux failures. - PR Comment: https://git.openjdk.org/jfx/pull/1457#issuecomment-2115734798
Re: RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote: > It looks like the list of packages available in the Ubuntu 22.04 GitHub > Actions test runner no longer includes `gcc-13` as of yesterday. I didn't > find any documentation to indicate that this was intentional, but now that > Ubuntu 24.04 is available we can fix the problem by updating to that version. > We will need to do this at some point anyway, so we might as well do it now. > > With this fix, the GHA test build now passes on all platforms. See the test > results to verify this. > > Given that GHA builds are currently broken on Linux, and that this fix > doesn't affect the product at all (just our GHA tests), I will integrate this > as soon as it is approved by 1 Reviewer, as an exception to the usual > requirement to wait for 24 hours. Note that the Ubuntu 24 runner is in beta: https://github.com/actions/runner-images#available-images. - PR Comment: https://git.openjdk.org/jfx/pull/1457#issuecomment-2115686652
Re: RFR: 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote: > It looks like the list of packages available in the Ubuntu 22.04 GitHub > Actions test runner no longer includes `gcc-13` as of yesterday. I didn't > find any documentation to indicate that this was intentional, but now that > Ubuntu 24.04 is available we can fix the problem by updating to that version. > We will need to do this at some point anyway, so we might as well do it now. > > With this fix, the GHA test build now passes on all platforms. See the test > results to verify this. > > Given that GHA builds are currently broken on Linux, and that this fix > doesn't affect the product at all (just our GHA tests), I will integrate this > as soon as it is approved by 1 Reviewer, as an exception to the usual > requirement to wait for 24 hours. looks good - Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1457#pullrequestreview-2061224330
