[Openlp-core] [Bug 1710109] [NEW] languagemanager.py - ValueError: Unknown format code 'i' for object of type 'int'

2017-08-11 Thread Kemuel
Public bug reported:

When trying to run OpenLP for the first time it immediately exits with

ValueError: Unknown format code 'i' for object of type 'int'

in languagemanager.py

Found that replacing "{count:>2i}" with "{count:>2d}" in the method
"init_qm_list():" solved the problem and language selection now shows as
normal.

My system: 
Arch Linux
Python 3.6.2
Qt 5.9.1
Installed OpenLP from bzr trunk (Help>About says 2.5.0)

Steps to reproduce:
* bzr co http://bazaar.launchpad.net/~openlp-core/openlp/trunk/ openlp
* cd openlp
* python setup.py install --root="/" --optimize=1
* mv /usr/bin/openlp{.py}
* openlp

** Affects: openlp
 Importance: Undecided
 Status: New

** Patch added: "Replace "{count:>2i}" with "{count:>2d}""
   
https://bugs.launchpad.net/bugs/1710109/+attachment/4930603/+files/d_instead_of_i.patch

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1710109

Title:
  languagemanager.py - ValueError: Unknown format code 'i' for object of
  type 'int'

Status in OpenLP:
  New

Bug description:
  When trying to run OpenLP for the first time it immediately exits with

  ValueError: Unknown format code 'i' for object of type 'int'

  in languagemanager.py

  Found that replacing "{count:>2i}" with "{count:>2d}" in the method
  "init_qm_list():" solved the problem and language selection now shows
  as normal.

  My system: 
  Arch Linux
  Python 3.6.2
  Qt 5.9.1
  Installed OpenLP from bzr trunk (Help>About says 2.5.0)

  Steps to reproduce:
  * bzr co http://bazaar.launchpad.net/~openlp-core/openlp/trunk/ openlp
  * cd openlp
  * python setup.py install --root="/" --optimize=1
  * mv /usr/bin/openlp{.py}
  * openlp

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1710109/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-h into lp:openlp

2017-08-11 Thread Ken Roberts
Ken Roberts has proposed merging lp:~alisonken1/openlp/pjlink2-h into lp:openlp.

Commit message:
PJLink 2 update H

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-h/+merge/328907

- Restructured AVMT to shortcut return on invalid input
- Added AVMT bad data test
- Fix AVMT tests
- Added extra logging information for CLSS errors
- Added CLSS failure tests
- Restructure ERST to not use hard-coded error breakout
- Added several ERST tests
- Fix ERST tests
- Added tests for pjlink.process_command



lp:~alisonken1/openlp/pjlink2-h (revision 2757)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/2130/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/2037/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1941/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Code_Analysis/1318/
[SUCCESS] https://ci.openlp.io/job/Branch-04b-Test_Coverage/1158/
[SUCCESS] https://ci.openlp.io/job/Branch-04c-Code_Analysis2/288/
[FAILURE] https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/133/

-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~alisonken1/openlp/pjlink2-h into lp:openlp.
=== modified file 'openlp/core/lib/projector/constants.py'
--- openlp/core/lib/projector/constants.py	2017-08-06 07:23:26 +
+++ openlp/core/lib/projector/constants.py	2017-08-11 11:14:30 +
@@ -46,7 +46,7 @@
'S_NOT_CONNECTED', 'S_CONNECTING', 'S_CONNECTED',
'S_STATUS', 'S_OFF', 'S_INITIALIZE', 'S_STANDBY', 'S_WARMUP', 'S_ON', 'S_COOLDOWN',
'S_INFO', 'S_NETWORK_SENDING', 'S_NETWORK_RECEIVED',
-   'ERROR_STRING', 'CR', 'LF', 'PJLINK_ERST_STATUS', 'PJLINK_POWR_STATUS',
+   'ERROR_STRING', 'CR', 'LF', 'PJLINK_ERST_DATA', 'PJLINK_ERST_STATUS', 'PJLINK_POWR_STATUS',
'PJLINK_PORT', 'PJLINK_MAX_PACKET', 'TIMEOUT', 'ERROR_MSG', 'PJLINK_ERRORS',
'STATUS_STRING', 'PJLINK_VALID_CMD', 'CONNECTION_ERRORS',
'PJLINK_DEFAULT_SOURCES', 'PJLINK_DEFAULT_CODES', 'PJLINK_DEFAULT_ITEMS']
@@ -393,11 +393,32 @@
 S_NETWORK_RECEIVED: translate('OpenLP.ProjectorConstants', 'Received data')
 }
 
+# Map ERST return code positions to equipment
+PJLINK_ERST_DATA = {
+'DATA_LENGTH': 6,
+0: 'FAN',
+1: 'LAMP',
+2: 'TEMP',
+3: 'COVER',
+4: 'FILTER',
+5: 'OTHER',
+'FAN': 0,
+'LAMP': 1,
+'TEMP': 2,
+'COVER': 3,
+'FILTER': 4,
+'OTHER': 5
+}
+
 # Map for ERST return codes to string
 PJLINK_ERST_STATUS = {
-'0': ERROR_STRING[E_OK],
+'0': 'OK',
 '1': ERROR_STRING[E_WARN],
-'2': ERROR_STRING[E_ERROR]
+'2': ERROR_STRING[E_ERROR],
+'OK': '0',
+E_OK: '0',
+E_WARN: '1',
+E_ERROR: '2'
 }
 
 # Map for POWR return codes to status code

=== modified file 'openlp/core/lib/projector/pjlink.py'
--- openlp/core/lib/projector/pjlink.py	2017-08-06 23:33:53 +
+++ openlp/core/lib/projector/pjlink.py	2017-08-11 11:14:30 +
@@ -54,8 +54,8 @@
 
 from openlp.core.common import translate, qmd5_hash
 from openlp.core.lib.projector.constants import CONNECTION_ERRORS, CR, ERROR_MSG, ERROR_STRING, \
-E_AUTHENTICATION, E_CONNECTION_REFUSED, E_GENERAL, E_INVALID_DATA, E_NETWORK, E_NOT_CONNECTED, \
-E_PARAMETER, E_PROJECTOR, E_SOCKET_TIMEOUT, E_UNAVAILABLE, E_UNDEFINED, PJLINK_ERRORS, \
+E_AUTHENTICATION, E_CONNECTION_REFUSED, E_GENERAL, E_INVALID_DATA, E_NETWORK, E_NOT_CONNECTED, E_OK, \
+E_PARAMETER, E_PROJECTOR, E_SOCKET_TIMEOUT, E_UNAVAILABLE, E_UNDEFINED, PJLINK_ERRORS, PJLINK_ERST_DATA, \
 PJLINK_ERST_STATUS, PJLINK_MAX_PACKET, PJLINK_PORT, PJLINK_POWR_STATUS, PJLINK_VALID_CMD, \
 STATUS_STRING, S_CONNECTED, S_CONNECTING, S_NETWORK_RECEIVED, S_NETWORK_SENDING, \
 S_NOT_CONNECTED, S_OFF, S_OK, S_ON, S_STATUS
@@ -154,39 +154,37 @@
 if _cmd not in PJLINK_VALID_CMD:
 log.error("({ip}) Ignoring command='{cmd}' (Invalid/Unknown)".format(ip=self.ip, cmd=cmd))
 return
+elif _data == 'OK':
+log.debug('({ip}) Command "{cmd}" returned OK'.format(ip=self.ip, cmd=cmd))
+# A command returned successfully, no further processing needed
+return
 elif _cmd not in self.pjlink_functions:
 log.warn("({ip}) Unable to process command='{cmd}' (Future option)".format(ip=self.ip, cmd=cmd))
 return
 elif _data in PJLINK_ERRORS:
 # Oops - projector error
 log.error('({ip}) Projector returned error "{data}"'.format(ip=self.ip, data=data))
-if _data == 'ERRA':
+if _data == PJLINK_ERRORS[E_AUTHENTICATION]:
 # Authentication error
 self.disconnect_from_host()
 self.change_status(E_AUTHENTICATION)
 log.debug('({ip}) emitting projectorAuthentication() signal'.format(ip=self.ip))
 self.projectorAuthentication.emit(self.name)
-  

[Openlp-core] [Merge] lp:~nixcode/openlp/fairsplitting into lp:openlp

2017-08-11 Thread Jonathan Tanner
Jonathan Tanner has proposed merging lp:~nixcode/openlp/fairsplitting into 
lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~nixcode/openlp/fairsplitting/+merge/328911

Adds the option to have text split fairly between slides.
E.g. if 3 lines fit on a slide and you have a 4 line verse this adds the option 
to have it split 2-2 not 3-1.

lp:~nixcode/openlp/fairsplitting (revision 2758)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/2133/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/2040/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1944/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Code_Analysis/1321/
[SUCCESS] https://ci.openlp.io/job/Branch-04b-Test_Coverage/1160/
[SUCCESS] https://ci.openlp.io/job/Branch-04c-Code_Analysis2/290/
[SUCCESS] https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/135/

-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~nixcode/openlp/fairsplitting into lp:openlp.
=== modified file 'openlp/core/common/__init__.py'
--- openlp/core/common/__init__.py	2017-08-01 20:59:41 +
+++ openlp/core/common/__init__.py	2017-08-11 12:52:52 +
@@ -167,6 +167,14 @@
 Next = 3
 
 
+class SlideSplitting(object):
+"""
+Provides an enumeration for behaviour of OpenLP when a slide needs to be split across multiple slides
+"""
+Greedily = 1
+Fairly = 2
+
+
 def de_hump(name):
 """
 Change any Camel Case string to python string

=== modified file 'openlp/core/common/settings.py'
--- openlp/core/common/settings.py	2017-06-05 06:05:54 +
+++ openlp/core/common/settings.py	2017-08-11 12:52:52 +
@@ -28,7 +28,7 @@
 
 from PyQt5 import QtCore, QtGui
 
-from openlp.core.common import ThemeLevel, SlideLimits, UiStrings, is_win, is_linux
+from openlp.core.common import ThemeLevel, SlideLimits, SlideSplitting, UiStrings, is_win, is_linux
 
 
 log = logging.getLogger(__name__)
@@ -159,6 +159,7 @@
 'core/songselect username': '',
 'core/update check': True,
 'core/view mode': 'default',
+'core/slide splitting': SlideSplitting.Fairly,
 # The other display settings (display position and dimensions) are defined in the ScreenList class due to a
 # circular dependency.
 'core/display on monitor': True,

=== modified file 'openlp/core/lib/renderer.py'
--- openlp/core/lib/renderer.py	2017-01-25 21:17:27 +
+++ openlp/core/lib/renderer.py	2017-08-11 12:52:52 +
@@ -25,7 +25,7 @@
 from string import Template
 from PyQt5 import QtGui, QtCore, QtWebKitWidgets
 
-from openlp.core.common import Registry, RegistryProperties, OpenLPMixin, RegistryMixin, Settings
+from openlp.core.common import Registry, RegistryProperties, OpenLPMixin, RegistryMixin, Settings, SlideSplitting
 from openlp.core.lib import FormattingTags, ImageSource, ItemCapabilities, ScreenList, ServiceItem, expand_tags, \
 build_lyrics_format_css, build_lyrics_outline_css, build_chords_css
 from openlp.core.common import ThemeLevel
@@ -380,6 +380,15 @@
 // returned value).
 return main.offsetHeight;
 }
+function get_height_of_text(text) {
+show_text(text);
+var main = document.getElementById('main');
+var old_height = main.style.height;
+main.style.height = "auto";
+var text_height = main.offsetHeight;
+main.style.height = old_height;
+return text_height
+}
 
 

[Openlp-core] [Merge] lp:~trb143/openlp/splitter into lp:openlp

2017-08-11 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/splitter into lp:openlp has been 
updated.

Status: Needs review => Superseded

For more details, see:
https://code.launchpad.net/~trb143/openlp/splitter/+merge/322053
-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~trb143/openlp/splitter into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Merge] lp:~trb143/openlp/splitter into lp:openlp

2017-08-11 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/splitter into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~trb143/openlp/splitter/+merge/328923

Add option to add a split to a song 
This will split the verse when added to the service but keep the verse together 
for editing.
Useful for the 10 line hymn verses which need 2 slides to display.

lp:~trb143/openlp/splitter (revision 2734)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/2135/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/2042/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1946/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Code_Analysis/1323/
[SUCCESS] https://ci.openlp.io/job/Branch-04b-Test_Coverage/1161/
[SUCCESS] https://ci.openlp.io/job/Branch-04c-Code_Analysis2/291/
[SUCCESS] https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/136/

-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~trb143/openlp/splitter into lp:openlp.
=== modified file 'openlp/core/lib/db.py'
--- openlp/core/lib/db.py	2017-08-01 20:59:41 +
+++ openlp/core/lib/db.py	2017-08-11 16:29:23 +
@@ -208,7 +208,7 @@
 :param upgrade: The python module that contains the upgrade instructions.
 """
 if not database_exists(url):
-log.warn("Database {db} doesn't exist - skipping upgrade checks".format(db=url))
+log.warning("Database {db} doesn't exist - skipping upgrade checks".format(db=url))
 return (0, 0)
 
 log.debug('Checking upgrades for DB {db}'.format(db=url))

=== modified file 'openlp/plugins/songs/forms/duplicatesongremovalform.py'
--- openlp/plugins/songs/forms/duplicatesongremovalform.py	2017-06-09 06:06:49 +
+++ openlp/plugins/songs/forms/duplicatesongremovalform.py	2017-08-11 16:29:23 +
@@ -25,14 +25,13 @@
 
 import logging
 import multiprocessing
-import os
 
 from PyQt5 import QtCore, QtWidgets
 
 from openlp.core.common import Registry, RegistryProperties, translate
 from openlp.core.ui.lib.wizard import OpenLPWizard, WizardStrings
 from openlp.plugins.songs.lib import delete_song
-from openlp.plugins.songs.lib.db import Song, MediaFile
+from openlp.plugins.songs.lib.db import Song
 from openlp.plugins.songs.forms.songreviewwidget import SongReviewWidget
 from openlp.plugins.songs.lib.songcompare import songs_probably_equal
 

=== modified file 'openlp/plugins/songs/forms/editversedialog.py'
--- openlp/plugins/songs/forms/editversedialog.py	2017-07-04 23:13:51 +
+++ openlp/plugins/songs/forms/editversedialog.py	2017-08-11 16:29:23 +
@@ -42,6 +42,10 @@
 self.dialog_layout.addWidget(self.verse_text_edit)
 self.verse_type_layout = QtWidgets.QHBoxLayout()
 self.verse_type_layout.setObjectName('verse_type_layout')
+self.divide_split_button = QtWidgets.QPushButton(edit_verse_dialog)
+self.divide_split_button.setIcon(build_icon(':/general/general_add.png'))
+self.divide_split_button.setObjectName('divide_split_button')
+self.verse_type_layout.addWidget(self.divide_split_button)
 self.split_button = QtWidgets.QPushButton(edit_verse_dialog)
 self.split_button.setIcon(build_icon(':/general/general_add.png'))
 self.split_button.setObjectName('split_button')
@@ -95,6 +99,9 @@
 self.verse_type_combo_box.setItemText(VerseType.Other, VerseType.translated_names[VerseType.Other])
 self.split_button.setText(UiStrings().Split)
 self.split_button.setToolTip(UiStrings().SplitToolTip)
+self.divide_split_button.setText(translate('SongsPlugin.EditVerseForm', '&Divide'))
+self.divide_split_button.setToolTip(translate('SongsPlugin.EditVerseForm', 'Divide the verse when displayed '
+   'regardless of the screen size.'))
 self.insert_button.setText(translate('SongsPlugin.EditVerseForm', '&Insert'))
 self.insert_button.setToolTip(translate('SongsPlugin.EditVerseForm',
   'Split a slide into two by inserting a verse splitter.'))

=== modified file 'openlp/plugins/songs/forms/editverseform.py'
--- openlp/plugins/songs/forms/editverseform.py	2017-06-04 12:14:23 +
+++ openlp/plugins/songs/forms/editverseform.py	2017-08-11 16:29:23 +
@@ -51,9 +51,10 @@
 self.split_button.clicked.connect(self.on_split_button_clicked)
 self.verse_text_edit.cursorPositionChanged.connect(self.on_cursor_position_changed)
 self.verse_type_combo_box.currentIndexChanged.connect(self.on_verse_type_combo_box_changed)
+self.divide_split_button.clicked.connect(self.on_divide_split_button_clicked)
 if Settings().value('songs/enable chords'):
-self.transpose_down_button.clicked.connect(self.on_transepose_down_button_clicked)
-self.transpose_up_button.clicked.connect(self.on_transepose_up_button_clicked)
+self.transpo

[Openlp-core] [Merge] lp:~trb143/openlp/splitter into lp:openlp

2017-08-11 Thread Tim Bentley
The proposal to merge lp:~trb143/openlp/splitter into lp:openlp has been 
updated.

Status: Needs review => Superseded

For more details, see:
https://code.launchpad.net/~trb143/openlp/splitter/+merge/328923
-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~trb143/openlp/splitter into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Merge] lp:~trb143/openlp/splitter into lp:openlp

2017-08-11 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/splitter into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~trb143/openlp/splitter/+merge/328924

Add option to add a split to a song 
This will split the verse when added to the service but keep the verse together 
for editing.
Useful for the 10 line hymn verses which need 2 slides to display.

Fix some iffy spelling

lp:~trb143/openlp/splitter (revision 2734)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/2135/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/2042/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1946/
[SUCCESS] https://ci.openlp.io/job/Branch-04a-Code_Analysis/1323/
[SUCCESS] https://ci.openlp.io/job/Branch-04b-Test_Coverage/1161/
[SUCCESS] https://ci.openlp.io/job/Branch-04c-Code_Analysis2/291/
[SUCCESS] https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/136/

-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~trb143/openlp/splitter into lp:openlp.
=== modified file 'openlp/core/lib/db.py'
--- openlp/core/lib/db.py	2017-08-01 20:59:41 +
+++ openlp/core/lib/db.py	2017-08-11 16:39:27 +
@@ -208,7 +208,7 @@
 :param upgrade: The python module that contains the upgrade instructions.
 """
 if not database_exists(url):
-log.warn("Database {db} doesn't exist - skipping upgrade checks".format(db=url))
+log.warning("Database {db} doesn't exist - skipping upgrade checks".format(db=url))
 return (0, 0)
 
 log.debug('Checking upgrades for DB {db}'.format(db=url))

=== modified file 'openlp/plugins/songs/forms/duplicatesongremovalform.py'
--- openlp/plugins/songs/forms/duplicatesongremovalform.py	2017-06-09 06:06:49 +
+++ openlp/plugins/songs/forms/duplicatesongremovalform.py	2017-08-11 16:39:27 +
@@ -25,14 +25,13 @@
 
 import logging
 import multiprocessing
-import os
 
 from PyQt5 import QtCore, QtWidgets
 
 from openlp.core.common import Registry, RegistryProperties, translate
 from openlp.core.ui.lib.wizard import OpenLPWizard, WizardStrings
 from openlp.plugins.songs.lib import delete_song
-from openlp.plugins.songs.lib.db import Song, MediaFile
+from openlp.plugins.songs.lib.db import Song
 from openlp.plugins.songs.forms.songreviewwidget import SongReviewWidget
 from openlp.plugins.songs.lib.songcompare import songs_probably_equal
 

=== modified file 'openlp/plugins/songs/forms/editversedialog.py'
--- openlp/plugins/songs/forms/editversedialog.py	2017-07-04 23:13:51 +
+++ openlp/plugins/songs/forms/editversedialog.py	2017-08-11 16:39:27 +
@@ -42,6 +42,10 @@
 self.dialog_layout.addWidget(self.verse_text_edit)
 self.verse_type_layout = QtWidgets.QHBoxLayout()
 self.verse_type_layout.setObjectName('verse_type_layout')
+self.divide_split_button = QtWidgets.QPushButton(edit_verse_dialog)
+self.divide_split_button.setIcon(build_icon(':/general/general_add.png'))
+self.divide_split_button.setObjectName('divide_split_button')
+self.verse_type_layout.addWidget(self.divide_split_button)
 self.split_button = QtWidgets.QPushButton(edit_verse_dialog)
 self.split_button.setIcon(build_icon(':/general/general_add.png'))
 self.split_button.setObjectName('split_button')
@@ -95,6 +99,9 @@
 self.verse_type_combo_box.setItemText(VerseType.Other, VerseType.translated_names[VerseType.Other])
 self.split_button.setText(UiStrings().Split)
 self.split_button.setToolTip(UiStrings().SplitToolTip)
+self.divide_split_button.setText(translate('SongsPlugin.EditVerseForm', '&Divide'))
+self.divide_split_button.setToolTip(translate('SongsPlugin.EditVerseForm', 'Divide the verse when displayed '
+   'regardless of the screen size.'))
 self.insert_button.setText(translate('SongsPlugin.EditVerseForm', '&Insert'))
 self.insert_button.setToolTip(translate('SongsPlugin.EditVerseForm',
   'Split a slide into two by inserting a verse splitter.'))

=== modified file 'openlp/plugins/songs/forms/editverseform.py'
--- openlp/plugins/songs/forms/editverseform.py	2017-06-04 12:14:23 +
+++ openlp/plugins/songs/forms/editverseform.py	2017-08-11 16:39:27 +
@@ -51,9 +51,10 @@
 self.split_button.clicked.connect(self.on_split_button_clicked)
 self.verse_text_edit.cursorPositionChanged.connect(self.on_cursor_position_changed)
 self.verse_type_combo_box.currentIndexChanged.connect(self.on_verse_type_combo_box_changed)
+self.divide_split_button.clicked.connect(self.on_divide_split_button_clicked)
 if Settings().value('songs/enable chords'):
-self.transpose_down_button.clicked.connect(self.on_transepose_down_button_clicked)
-self.transpose_up_button.clicked.connect(self.on_transepose_up_button_clicked)
+

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-11 Thread Raoul Snyman
Review: Approve

Looks OK to me.
-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328825
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-h into lp:openlp

2017-08-11 Thread Tim Bentley
Review: Approve


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-h/+merge/328907
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-h into lp:openlp

2017-08-11 Thread Tomas Groth
Review: Approve


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-h/+merge/328907
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-h into lp:openlp

2017-08-11 Thread noreply
The proposal to merge lp:~alisonken1/openlp/pjlink2-h into lp:openlp has been 
updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-h/+merge/328907
-- 
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-11 Thread Tim Bentley
Review: Approve


-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328825
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp


[Openlp-core] [Merge] lp:~phill-ridout/openlp/pathlib2 into lp:openlp

2017-08-11 Thread noreply
The proposal to merge lp:~phill-ridout/openlp/pathlib2 into lp:openlp has been 
updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/pathlib2/+merge/328825
-- 
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp