[Openlp-core] [Bug 1742910] [NEW] first time wizard crashes
Public bug reported: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index run_thread(worker, thread_name) File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread if thread_name in main_window.threads: AttributeError: 'NoneType' object has no attribute 'threads' Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux. ** Affects: openlp Importance: Critical Status: New ** Tags: ftw threads -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1742910 Title: first time wizard crashes Status in OpenLP: New Bug description: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index run_thread(worker, thread_name) File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread if thread_name in main_window.threads: AttributeError: 'NoneType' object has no attribute 'threads' Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1742910/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Bug 1742910] Re: first time wizard crashes
Confirmed on Fedora 25 as well. ** Tags added: threads ** Tags added: ftw ** Attachment added: "openlp.log from fedora 25 after deleting ~/.openlp ~/.config/OpenLP" https://bugs.launchpad.net/openlp/+bug/1742910/+attachment/5035774/+files/openlp.log ** Changed in: openlp Importance: Undecided => Critical -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1742910 Title: first time wizard crashes Status in OpenLP: New Bug description: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index run_thread(worker, thread_name) File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread if thread_name in main_window.threads: AttributeError: 'NoneType' object has no attribute 'threads' Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1742910/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Bug 1742910] Re: first time wizard crashes
The issue seems to be that the threads are all stored in the mainwindow which isn't always there. If you run the first time wizard in the very beginning, no mainwindow exists. So the threads should probably be attached to something that is created much earlier, before anything else is done, so it's guaranteed to be always there. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1742910 Title: first time wizard crashes Status in OpenLP: New Bug description: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index run_thread(worker, thread_name) File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread if thread_name in main_window.threads: AttributeError: 'NoneType' object has no attribute 'threads' Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1742910/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Bug 1742910] Re: first time wizard crashes
** Branch linked: lp:~alisonken1/openlp/pjlink2-o-with_thread_hack -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1742910 Title: first time wizard crashes Status in OpenLP: New Bug description: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index run_thread(worker, thread_name) File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread if thread_name in main_window.threads: AttributeError: 'NoneType' object has no attribute 'threads' Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1742910/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Bug 1742910] Re: first time wizard crashes
** Branch unlinked: lp:~alisonken1/openlp/pjlink2-o-with_thread_hack -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1742910 Title: first time wizard crashes Status in OpenLP: New Bug description: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index run_thread(worker, thread_name) File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread if thread_name in main_window.threads: AttributeError: 'NoneType' object has no attribute 'threads' Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1742910/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Bug 1742910] Re: first time wizard crashes
** Branch linked: lp:~raoul-snyman/openlp/bug-1742910 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1742910 Title: first time wizard crashes Status in OpenLP: New Bug description: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index run_thread(worker, thread_name) File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread if thread_name in main_window.threads: AttributeError: 'NoneType' object has no attribute 'threads' Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1742910/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1742910 into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-1742910 into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1742910 in OpenLP: "first time wizard crashes"
https://bugs.launchpad.net/openlp/+bug/1742910
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1742910/+merge/336064
Fix bug #1742910 by moving the threads to the application object instead of the
main window object.
Add this to your merge proposal:
lp:~raoul-snyman/openlp/bug-1742910 (revision 2810)
https://ci.openlp.io/job/Branch-01-Pull/2418/ [SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2319/ [SUCCESS]
https://ci.openlp.io/job/Branch-02b-macOS-Tests/114/ [SUCCESS]
https://ci.openlp.io/job/Branch-03a-Build-Source/36/ [SUCCESS]
https://ci.openlp.io/job/Branch-03b-Build-macOS/35/[SUCCESS]
https://ci.openlp.io/job/Branch-04a-Code-Analysis/1498/[SUCCESS]
https://ci.openlp.io/job/Branch-04b-Test-Coverage/1311/[SUCCESS]
https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/262/ [FAILURE]
Stopping after failure
Failed builds:
- Branch-05-AppVeyor-Tests #262:
https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/262/console
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/bug-1742910 into lp:openlp.
=== modified file 'openlp/core/app.py'
--- openlp/core/app.py 2018-01-07 04:40:40 +
+++ openlp/core/app.py 2018-01-13 05:29:49 +
@@ -63,8 +63,8 @@
The core application class. This class inherits from Qt's QApplication
class in order to provide the core of the application.
"""
-
args = []
+worker_threads = {}
def exec(self):
"""
=== modified file 'openlp/core/common/path.py'
--- openlp/core/common/path.py 2017-12-29 09:15:48 +
+++ openlp/core/common/path.py 2018-01-13 05:29:49 +
@@ -26,9 +26,9 @@
from openlp.core.common import is_win
if is_win():
-from pathlib import WindowsPath as PathVariant
+from pathlib import WindowsPath as PathVariant # pragma: nocover
else:
-from pathlib import PosixPath as PathVariant
+from pathlib import PosixPath as PathVariant# pragma: nocover
log = logging.getLogger(__name__)
=== modified file 'openlp/core/threading.py'
--- openlp/core/threading.py 2018-01-07 17:50:29 +
+++ openlp/core/threading.py 2018-01-13 05:29:49 +
@@ -50,12 +50,12 @@
"""
if not thread_name:
raise ValueError('A thread_name is required when calling the "run_thread" function')
-main_window = Registry().get('main_window')
-if thread_name in main_window.threads:
+application = Registry().get('application')
+if thread_name in application.worker_threads:
raise KeyError('A thread with the name "{}" has already been created, please use another'.format(thread_name))
# Create the thread and add the thread and the worker to the parent
thread = QtCore.QThread()
-main_window.threads[thread_name] = {
+application.worker_threads[thread_name] = {
'thread': thread,
'worker': worker
}
@@ -78,7 +78,10 @@
:param str thread_name: The name of the thread
:returns: The worker for this thread name
"""
-return Registry().get('main_window').threads.get(thread_name)
+thread_info = Registry().get('application').worker_threads.get(thread_name)
+if not thread_info:
+raise KeyError('No thread named "{}" exists'.format(thread_name))
+return thread_info.get('worker')
def is_thread_finished(thread_name):
@@ -88,8 +91,11 @@
:param str thread_name: The name of the thread
:returns: True if the thread is finished, False if it is still running
"""
-main_window = Registry().get('main_window')
-return thread_name not in main_window.threads or main_window.threads[thread_name]['thread'].isFinished()
+thread_info = Registry().get('application').worker_threads.get(thread_name)
+if not thread_info:
+# If the thread doesnt exist anymore, it's probably because it is finished
+return True
+return thread_info['thread'].isFinished()
def make_remove_thread(thread_name):
@@ -99,13 +105,14 @@
:param str thread_name: The name of the thread which should be removed from the thread registry.
:returns: A function which will remove the thread from the thread registry.
"""
-def remove_thread():
+
+def remove_thread():# pragma: nocover
"""
Stop and remove a registered thread
:param str thread_name: The name of the thread to stop and remove
"""
-main_window = Registry().get('main_window')
-if thread_name in main_window.threads:
-
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1742910 into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/bug-1742910 into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/bug-1742910/+merge/336064 -- Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/bug-1742910 into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1742910 into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-1742910 into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1742910 in OpenLP: "first time wizard crashes"
https://bugs.launchpad.net/openlp/+bug/1742910
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1742910/+merge/336066
Fix bug #1742910 by moving the threads to the application object instead of the
main window object.
Add this to your merge proposal:
lp:~raoul-snyman/openlp/bug-1742910 (revision 2810)
https://ci.openlp.io/job/Branch-01-Pull/2418/ [SUCCESS]
https://ci.openlp.io/job/Branch-02a-Linux-Tests/2319/ [SUCCESS]
https://ci.openlp.io/job/Branch-02b-macOS-Tests/114/ [SUCCESS]
https://ci.openlp.io/job/Branch-03a-Build-Source/36/ [SUCCESS]
https://ci.openlp.io/job/Branch-03b-Build-macOS/35/[SUCCESS]
https://ci.openlp.io/job/Branch-04a-Code-Analysis/1498/[SUCCESS]
https://ci.openlp.io/job/Branch-04b-Test-Coverage/1311/[SUCCESS]
https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/262/ [FAILURE]
Stopping after failure
Failed builds:
- Branch-05-AppVeyor-Tests #262:
https://ci.openlp.io/job/Branch-05-AppVeyor-Tests/262/console
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/bug-1742910 into lp:openlp.
=== modified file 'openlp/core/app.py'
--- openlp/core/app.py 2018-01-07 04:40:40 +
+++ openlp/core/app.py 2018-01-13 06:00:49 +
@@ -63,8 +63,8 @@
The core application class. This class inherits from Qt's QApplication
class in order to provide the core of the application.
"""
-
args = []
+worker_threads = {}
def exec(self):
"""
=== modified file 'openlp/core/common/path.py'
--- openlp/core/common/path.py 2017-12-29 09:15:48 +
+++ openlp/core/common/path.py 2018-01-13 06:00:49 +
@@ -26,9 +26,9 @@
from openlp.core.common import is_win
if is_win():
-from pathlib import WindowsPath as PathVariant
+from pathlib import WindowsPath as PathVariant # pragma: nocover
else:
-from pathlib import PosixPath as PathVariant
+from pathlib import PosixPath as PathVariant# pragma: nocover
log = logging.getLogger(__name__)
=== modified file 'openlp/core/threading.py'
--- openlp/core/threading.py 2018-01-07 17:50:29 +
+++ openlp/core/threading.py 2018-01-13 06:00:49 +
@@ -50,12 +50,12 @@
"""
if not thread_name:
raise ValueError('A thread_name is required when calling the "run_thread" function')
-main_window = Registry().get('main_window')
-if thread_name in main_window.threads:
+application = Registry().get('application')
+if thread_name in application.worker_threads:
raise KeyError('A thread with the name "{}" has already been created, please use another'.format(thread_name))
# Create the thread and add the thread and the worker to the parent
thread = QtCore.QThread()
-main_window.threads[thread_name] = {
+application.worker_threads[thread_name] = {
'thread': thread,
'worker': worker
}
@@ -78,7 +78,10 @@
:param str thread_name: The name of the thread
:returns: The worker for this thread name
"""
-return Registry().get('main_window').threads.get(thread_name)
+thread_info = Registry().get('application').worker_threads.get(thread_name)
+if not thread_info:
+raise KeyError('No thread named "{}" exists'.format(thread_name))
+return thread_info.get('worker')
def is_thread_finished(thread_name):
@@ -88,8 +91,8 @@
:param str thread_name: The name of the thread
:returns: True if the thread is finished, False if it is still running
"""
-main_window = Registry().get('main_window')
-return thread_name not in main_window.threads or main_window.threads[thread_name]['thread'].isFinished()
+app = Registry().get('application')
+return thread_name not in app.worker_threads or app.worker_threads[thread_name]['thread'].isFinished()
def make_remove_thread(thread_name):
@@ -99,13 +102,14 @@
:param str thread_name: The name of the thread which should be removed from the thread registry.
:returns: A function which will remove the thread from the thread registry.
"""
-def remove_thread():
+
+def remove_thread():# pragma: nocover
"""
Stop and remove a registered thread
:param str thread_name: The name of the thread to stop and remove
"""
-main_window = Registry().get('main_window')
-if thread_name in main_window.threads:
-del main_window.threads[thread_name]
+application = Registry().get('application')
+if
[Openlp-core] [Bug 1603702] Re: no compatible signature for decorated function in projector test
Not sure which update fixed, but problem resolved and in trunk ** Changed in: openlp Importance: Undecided => Medium ** Changed in: openlp Status: New => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1603702 Title: no compatible signature for decorated function in projector test Status in OpenLP: Fix Committed Bug description: Trunk on superfly machine == ERROR: test_source_select_edit_button (tests.interfaces.openlp_core_ui.test_projectorsourceform.ProjectorSourceFormTest) -- Traceback (most recent call last): File "/usr/lib/python3.5/unittest/mock.py", line 1157, in patched return func(*args, **keywargs) File "/home/raoul/Projects/OpenLP/OpenLP/permission-error/tests/interfaces/openlp_core_ui/test_projectorsourceform.py", line 132, in test_source_select_edit_button select_form.exec(projector=self.projector) File "/home/raoul/Projects/OpenLP/OpenLP/permission-error/openlp/core/ui/projector/sourceselectform.py", line 448, in exec self.button_box.clicked.connect(self.button_clicked) TypeError: decorated slot has no signature compatible with clicked(QAbstractButton*) == ERROR: test_source_select_noedit_button (tests.interfaces.openlp_core_ui.test_projectorsourceform.ProjectorSourceFormTest) -- Traceback (most recent call last): File "/usr/lib/python3.5/unittest/mock.py", line 1157, in patched return func(*args, **keywargs) File "/home/raoul/Projects/OpenLP/OpenLP/permission-error/tests/interfaces/openlp_core_ui/test_projectorsourceform.py", line 152, in test_source_select_noedit_button select_form.exec(projector=self.projector) File "/home/raoul/Projects/OpenLP/OpenLP/permission-error/openlp/core/ui/projector/sourceselectform.py", line 448, in exec self.button_box.clicked.connect(self.button_clicked) TypeError: decorated slot has no signature compatible with clicked(QAbstractButton*) To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1603702/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Bug 1742910] Re: first time wizard crashes
** Changed in: openlp Assignee: (unassigned) => Raoul Snyman (raoul-snyman) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1742910 Title: first time wizard crashes Status in OpenLP: New Bug description: Traceback (most recent call last): File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 307, in on_current_id_changed self._download_index() File "/home/sim/dev/openlp/better-threading/openlp/core/ui/firsttimeform.py", line 260, in _download_index run_thread(worker, thread_name) File "/home/sim/dev/openlp/better-threading/openlp/core/threading.py", line 54, in run_thread if thread_name in main_window.threads: AttributeError: 'NoneType' object has no attribute 'threads' Using the better-threading branch, with no data or configs for OpenLP present in my home running on Archlinux. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1742910/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Bug 1625767] Re: Can't delete/add a projector...
** Changed in: openlp Importance: Undecided => Medium ** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1625767 Title: Can't delete/add a projector... Status in OpenLP: Fix Committed Bug description: When trying to add a projector through the projector manager it won't connect and when opening OpenLP with the 'connect to projector on startup' option enabled it gives an error window. I also cannot delete projector as the same window pops up with an error. So all in all it won't connect. PC Specs: -Arch Linux (kernel 4.7.4) -OpenLP-bzr2496 Steps to reproduce issue: 1. Click on add projector 2. Fill in info to projector 3. Click on connect...nothing happens 4. Click on Settins/Configure OpenLP/Projectors and enable the 'Connect to projectors on startup' option 5. Close OpenLP 6. Open OpenLP and error window pops up. 7. Delete the projector in Projector Manager the same popup window shows up. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1625767/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Bug 1594001] Re: Projector port entry allows invalid port numbers
Not sure when but fixed ** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1594001 Title: Projector port entry allows invalid port numbers Status in OpenLP: Fix Committed Bug description: New/edit projector wizard does not check port entry for valid ports. Empty field will cause an exception. Since it's prefilled with the default port, it is normally not an issue. To manage notifications about this bug go to: https://bugs.launchpad.net/openlp/+bug/1594001/+subscriptions ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-o into lp:openlp
Review: Needs Fixing I'm pretty happy with this overall, just the field in the database which I think should be bigger. Diff comments: > === modified file 'openlp/core/projectors/db.py' > --- openlp/core/projectors/db.py 2017-12-29 09:15:48 + > +++ openlp/core/projectors/db.py 2018-01-13 05:52:32 + > @@ -152,6 +152,7 @@ > location: Column(String(30)) > notes: Column(String(200)) > pjlink_name:Column(String(128)) # From projector > +pjlink_classColumn(String(1))# From projector Just one character? Space is cheap, make it bigger, just in case these classes become something weird like "18.02" > manufacturer: Column(String(128)) # From projector > model: Column(String(128)) # From projector > other: Column(String(128)) # From projector > @@ -197,6 +199,7 @@ > location = Column(String(30)) > notes = Column(String(200)) > pjlink_name = Column(String(128)) > +pjlink_class = Column(String(1)) Same here. > manufacturer = Column(String(128)) > model = Column(String(128)) > other = Column(String(128)) -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-o/+merge/336065 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-o into lp:openlp
I don't forsee pjlink going to a split versioning for class information (it's not like software), but as you say, space is cheap On Fri, Jan 12, 2018 at 11:07 PM, Raoul Snyman wrote: > Review: Needs Fixing > > I'm pretty happy with this overall, just the field in the database which I > think should be bigger. > > Diff comments: > >> === modified file 'openlp/core/projectors/db.py' >> --- openlp/core/projectors/db.py 2017-12-29 09:15:48 + >> +++ openlp/core/projectors/db.py 2018-01-13 05:52:32 + >> @@ -152,6 +152,7 @@ >> location: Column(String(30)) >> notes: Column(String(200)) >> pjlink_name:Column(String(128)) # From projector >> +pjlink_classColumn(String(1))# From projector > > Just one character? Space is cheap, make it bigger, just in case these > classes become something weird like "18.02" > >> manufacturer: Column(String(128)) # From projector >> model: Column(String(128)) # From projector >> other: Column(String(128)) # From projector >> @@ -197,6 +199,7 @@ >> location = Column(String(30)) >> notes = Column(String(200)) >> pjlink_name = Column(String(128)) >> +pjlink_class = Column(String(1)) > > Same here. > >> manufacturer = Column(String(128)) >> model = Column(String(128)) >> other = Column(String(128)) > > > -- > https://code.launchpad.net/~alisonken1/openlp/pjlink2-o/+merge/336065 > You are the owner of lp:~alisonken1/openlp/pjlink2-o. -- - Ken Registered Linux user 296561 Slackin' since 1993 Slackware Linux (http://www.slackware.com) OpenLP - Church Projection Software Empower Your Church http://openlp.org https://code.launchpad.net/~alisonken1/openlp/pjlink2-o/+merge/336065 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-o into lp:openlp
The proposal to merge lp:~alisonken1/openlp/pjlink2-o into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~alisonken1/openlp/pjlink2-o/+merge/336065 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-o into lp:openlp
Review: Approve Looks good but unable to test. -- https://code.launchpad.net/~alisonken1/openlp/pjlink2-o/+merge/336067 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
