[Openlp-core] [Bug 1751628] [NEW] portabe flag is marked as not implemented

2018-02-25 Thread Simon Hanna 
Public bug reported:

OpenLP has a portable flag that runs OpenLP with a data/config directory
relative to the path where it's stored. I think it is built in a windows
specific way (where the stuff is then stored) but it seems to work
flawlessly on my linux machine.

However the output of -h says that it's not implemented. I am pretty
sure that the documentation is wrong, but someone else might know more
about that.

** Affects: openlp
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1751628

Title:
  portabe flag is marked as not implemented

Status in OpenLP:
  New

Bug description:
  OpenLP has a portable flag that runs OpenLP with a data/config
  directory relative to the path where it's stored. I think it is built
  in a windows specific way (where the stuff is then stored) but it
  seems to work flawlessly on my linux machine.

  However the output of -h says that it's not implemented. I am pretty
  sure that the documentation is wrong, but someone else might know more
  about that.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1751628/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Bug 1751626] [NEW] -d flag is used in a very confusing way

2018-02-25 Thread Simon Hanna 
Public bug reported:

in the startup code the parameters accepted include --dev-version (-d).

What's irritating is that it's not actually used there. The values are
also not actually passed along somewhere else.

However the about dialog still correctly displays the bzr revision if
started with -d.

So a little searching showed the following. The argument is defined in
openlp.core.app.parse_options but only used in
openlp.core.version.get_version

Since the dev_version is not stored somewhere or passed to some place,
get_version actually checks sys.argv searching for "-d" or "--dev-
version"

This is not very nice to people reading the code. It very much looks
like the argument definition is not actually used.

My request:
* either completely remove the functionality
* or properly use the parsed value, so it's clear it actually does something.

also having the bzr check code in openlp.core.version.get_version is
probably not the best idea. Especially since the code includes a comment
that it's a duplicate of code in setup.py

Further rants:
in setup.py the code is not actually exactly the same, there are modifications 
and there is a comment that it is a duplicate of the no longer existing 
openlp.core.common.checkversions.py 

This illustrates that comments are bad for the reason that they are
often not updated when the code changes. This can lead to comments
confusing more than helping.


In short:
Remove the flag, remove the code from get_version and only have it in setup.py
The flag is only useful for people running from bzr so devs, which should know 
what they are running and even if they don't they should know how to get that 
information without reverting to the about tab.

** Affects: openlp
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1751626

Title:
  -d flag is used in a very confusing way

Status in OpenLP:
  New

Bug description:
  in the startup code the parameters accepted include --dev-version
  (-d).

  What's irritating is that it's not actually used there. The values are
  also not actually passed along somewhere else.

  However the about dialog still correctly displays the bzr revision if
  started with -d.

  So a little searching showed the following. The argument is defined in
  openlp.core.app.parse_options but only used in
  openlp.core.version.get_version

  Since the dev_version is not stored somewhere or passed to some place,
  get_version actually checks sys.argv searching for "-d" or "--dev-
  version"

  This is not very nice to people reading the code. It very much looks
  like the argument definition is not actually used.

  My request:
  * either completely remove the functionality
  * or properly use the parsed value, so it's clear it actually does something.

  also having the bzr check code in openlp.core.version.get_version is
  probably not the best idea. Especially since the code includes a
  comment that it's a duplicate of code in setup.py

  Further rants:
  in setup.py the code is not actually exactly the same, there are 
modifications and there is a comment that it is a duplicate of the no longer 
existing openlp.core.common.checkversions.py 

  This illustrates that comments are bad for the reason that they are
  often not updated when the code changes. This can lead to comments
  confusing more than helping.

  
  In short:
  Remove the flag, remove the code from get_version and only have it in setup.py
  The flag is only useful for people running from bzr so devs, which should 
know what they are running and even if they don't they should know how to get 
that information without reverting to the about tab.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1751626/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Bug 1533401] Re: Remote plugin stays active until a restart

2018-02-25 Thread Simon Hanna 
So once downloaded it's always there, always running? In that case I'd
open a new bug to enable/disable the API. My remarks would pretty much
remain unchanged...

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1533401

Title:
  Remote plugin stays active until a restart

Status in OpenLP:
  Won't Fix

Bug description:
  Deactivating the remote plugin has no effect until OpenLP is restarted

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1533401/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Bug 1533401] Re: Remote plugin stays active until a restart

2018-02-25 Thread Tim Bentley 
The behavior is no longer valid.  The API is running all the time in version 3 
so this is not a valid defect anymore.
The remote plugin is only a placeholder for web code and not the web server.

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1533401

Title:
  Remote plugin stays active until a restart

Status in OpenLP:
  Won't Fix

Bug description:
  Deactivating the remote plugin has no effect until OpenLP is restarted

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1533401/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Bug 1533401] Re: Remote plugin stays active until a restart

2018-02-25 Thread Simon Hanna 
TBH I'm not particularly happy about closing this as Won't Fix.
It's unexpected behavior and potentially a "security" issue. If you want to 
have it disabled at a given time, you have to restart, which is probably not 
the time that you want to restart.

It shouldn't be too complicated. My branch is probably outdated by now,
but tbh you didn't followup one the issues you had with it. If we are
able to shutdown the remote properly on OpenLP shutdown (which we
should!!), then we have to be able to do that without a OpenLP shutdown.
Otherwise something is wrong about the architecture. Also note that
other plugins can be disabled/enabled that way.

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1533401

Title:
  Remote plugin stays active until a restart

Status in OpenLP:
  Won't Fix

Bug description:
  Deactivating the remote plugin has no effect until OpenLP is restarted

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1533401/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Bug 1744553] Re: replace live background with image causes crash

2018-02-25 Thread Simon Hanna 
And we close it before that is added (double checked)?

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1744553

Title:
  replace live background with image causes crash

Status in OpenLP:
  Won't Fix

Bug description:
  Here is the trace

  
  Traceback (most recent call last):
File "/home/sim/dev/openlp/trunk/openlp/core/ui/media/mediacontroller.py", 
line 219, in media_state_live
  self.media_play(self.display_controllers[DisplayControllerType.Live], 
True)
File "/home/sim/dev/openlp/trunk/openlp/core/ui/media/mediacontroller.py", 
line 639, in media_play
  if not 
self.current_media_players[controller.controller_type].play(display):
  KeyError: 0

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1744553/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Bug 1589675] Re: OpenLP on Linux crashes on startup when VLC not installed

2018-02-25 Thread Tim Bentley 
** Changed in: openlp
   Status: Invalid => Confirmed

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1589675

Title:
  OpenLP on Linux crashes on startup when VLC not installed

Status in OpenLP:
  Confirmed

Bug description:
  Similar to bug #966086

  **OpenLP Bug Report**
  Version: {'build': None, 'version': '2.4.1', 'full': '2.4.1'}

  --- Details of the Exception. ---

  this occurred as OpenLP was opened

   --- Exception Traceback ---
  Traceback (most recent call last):
File "/usr/bin/openlp", line 44, in 
  main()
File "/usr/share/openlp/openlp/core/__init__.py", line 391, in main
  sys.exit(application.run(qt_args))
File "/usr/share/openlp/openlp/core/__init__.py", line 142, in run
  Registry().execute('bootstrap_initialise')
File "/usr/share/openlp/openlp/core/common/registry.py", line 137, in 
execute
  result = function(*args, **kwargs)
File "/usr/share/openlp/openlp/core/lib/pluginmanager.py", line 60, in 
bootstrap_initialise
  self.hook_media_manager()
File "/usr/share/openlp/openlp/core/lib/pluginmanager.py", line 122, in 
hook_media_manager
  plugin.create_media_manager_item()
File "/usr/share/openlp/openlp/core/lib/plugin.py", line 204, in 
create_media_manager_item
  self.media_item = 
self.media_item_class(self.main_window.media_dock_manager.media_dock, self)
File "/usr/share/openlp/openlp/plugins/media/lib/mediaitem.py", line 58, in 
__init__
  super(MediaMediaItem, self).__init__(parent, plugin)
File "/usr/share/openlp/openlp/core/lib/mediamanageritem.py", line 82, in 
__init__
  self.setup_item()
File "/usr/share/openlp/openlp/plugins/media/lib/mediaitem.py", line 90, in 
setup_item
  
self.media_controller.setup_display(self.display_controller.preview_display, 
False)
File "/usr/share/openlp/openlp/core/ui/media/mediacontroller.py", line 322, 
in setup_display
  player.setup(display)
File "/usr/share/openlp/openlp/core/ui/media/vlcplayer.py", line 157, in 
setup
  display.vlc_instance = vlc.Instance(command_line_options)
File "/usr/share/openlp/openlp/core/ui/media/vendor/vlc.py", line 1411, in 
__new__
  return libvlc_new(len(args), args)
File "/usr/share/openlp/openlp/core/ui/media/vendor/vlc.py", line 3630, in 
libvlc_new
  ctypes.c_void_p, ctypes.c_int, ListPOINTER(ctypes.c_char_p))
File "/usr/share/openlp/openlp/core/ui/media/vendor/vlc.py", line 246, in 
_Cfunction
  raise NameError('no function %r' % (name,))
  NameError: no function 'libvlc_new'

  --- System information ---
  Platform: Linux-4.2.0-36-generic-i686-with-Ubuntu-15.10-wily
  Desktop: GNOME

  --- Library Versions ---
  Python: 3.4.3+
  Qt5: 5.4.2
  PyQt5: 5.4.2
  QtWebkit: 538.1
  SQLAlchemy: 1.0.8
  SQLAlchemy Migrate: -
  BeautifulSoup: 4.3.2
  lxml: 3.4.4
  Chardet: 2.3.0
  PyEnchant: 1.6.6
  Mako: 1.0.2
  pyICU: -
  pyUNO bridge: 5.0
  VLC: -

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1589675/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp