[Openlp-core] Linting: Passed

2019-04-20 Thread Raoul Snyman 
Linting passed!
-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-v1/+merge/366334
Your team OpenLP Core is requested to review the proposed merge of 
lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] Linux Test Results: Passed

2019-04-20 Thread Raoul Snyman 
Linux tests passed!
-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-v1/+merge/366334
Your team OpenLP Core is requested to review the proposed merge of 
lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp

2019-04-20 Thread Ken Roberts 
The proposal to merge lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp has been 
updated.

Description changed to:

NOTE: Part 1 of a multi-part merge. Rest of pjlink2-v[2..n]
  merges are to fix tests

- Move projectors.pjlink.PJLinkCommand class/methods to
  separate projectors.pjlinkcommands module/functions to
  simplify PJLinkUDP commands processing.

- Mark projector tests that involve command processing as
  "skip('Needs update to new setup')" while fixing tests.
NOTE: projector controller tested live and works - some unit tests
  are skipped at this time until fixed.

NOTE: Jenkins tests passed except MacOS (offline)
  no cli output from MacOS+ tests

For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-v1/+merge/366334
-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp

2019-04-20 Thread Ken Roberts 
Ken Roberts has proposed merging lp:~alisonken1/openlp/pjlink2-v1 into 
lp:openlp.

Commit message:
PJLink2 Update V1

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-v1/+merge/366334

NOTE: Part 1 of a multi-part merge. Rest of pjlink2-v[2..n]
  merges are to fix tests

- Move projectors.pjlink.PJLinkCommand class/methods to
  separate projectors.pjlinkcommands module/functions to simplify PJLinkUDP
  commands processing.

- Mark projector tests that involve command processing as
  "skip('Needs update to new setup')" while fixing tests.
NOTE: projector controller tested live and works - some unit tests
  are skipped at this time until fixed.

NOTE: Jenkins tests passed except MacOS (offline) no cli output from MacOS+ 
tests
-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp.
=== modified file 'openlp/core/projectors/editform.py'
--- openlp/core/projectors/editform.py	2019-02-14 15:09:09 +
+++ openlp/core/projectors/editform.py	2019-04-21 01:35:00 +
@@ -37,6 +37,8 @@
 log = logging.getLogger(__name__)
 log.debug('editform loaded')
 
+# TODO: Fix db entries for input source(s)
+
 
 class Ui_ProjectorEditForm(object):
 """

=== modified file 'openlp/core/projectors/pjlink.py'
--- openlp/core/projectors/pjlink.py	2019-03-09 03:53:20 +
+++ openlp/core/projectors/pjlink.py	2019-04-21 01:35:00 +
@@ -47,19 +47,18 @@
 where ```` is the PJLink command being processed
 """
 import logging
-import re
 from codecs import decode
 
 from PyQt5 import QtCore, QtNetwork
 
-from openlp.core.common import qmd5_hash
 from openlp.core.common.i18n import translate
 from openlp.core.common.settings import Settings
-from openlp.core.projectors.constants import CONNECTION_ERRORS, E_AUTHENTICATION, E_CONNECTION_REFUSED, E_GENERAL, \
-E_NETWORK, E_NOT_CONNECTED, E_SOCKET_TIMEOUT, PJLINK_CLASS, PJLINK_DEFAULT_CODES, PJLINK_ERRORS, PJLINK_ERST_DATA, \
-PJLINK_ERST_STATUS, PJLINK_MAX_PACKET, PJLINK_PORT, PJLINK_POWR_STATUS, PJLINK_PREFIX, PJLINK_SUFFIX, \
+from openlp.core.projectors.pjlinkcommands import process_command
+from openlp.core.projectors.constants import CONNECTION_ERRORS, E_CONNECTION_REFUSED, E_GENERAL, \
+E_NETWORK, E_NOT_CONNECTED, E_SOCKET_TIMEOUT, PJLINK_CLASS, \
+PJLINK_MAX_PACKET, PJLINK_PORT, PJLINK_PREFIX, PJLINK_SUFFIX, \
 PJLINK_VALID_CMD, PROJECTOR_STATE, QSOCKET_STATE, S_CONNECTED, S_CONNECTING, S_NOT_CONNECTED, S_OFF, S_OK, S_ON, \
-S_STANDBY, STATUS_CODE, STATUS_MSG
+STATUS_CODE, STATUS_MSG
 
 
 log = logging.getLogger(__name__)
@@ -183,544 +182,7 @@
 self.udp_stop()
 
 
-class PJLinkCommands(object):
-"""
-Process replies from PJLink projector.
-"""
-# List of IP addresses and mac addresses found via UDP search command
-ackn_list = []
-
-def __init__(self, *args, **kwargs):
-"""
-Setup for the process commands
-"""
-log.debug('PJlinkCommands(args={args} kwargs={kwargs})'.format(args=args, kwargs=kwargs))
-super().__init__()
-# Map PJLink command to method and include pjlink class version for this instance
-# Default initial pjlink class version is '1'
-self.pjlink_functions = {
-'ACKN': {"method": self.process_ackn,  # Class 2 (command is SRCH)
- "version": "2"},
-'AVMT': {"method": self.process_avmt,
- "version": "1"},
-'CLSS': {"method": self.process_clss,
- "version": "1"},
-'ERST': {"method": self.process_erst,
- "version": "1"},
-'INFO': {"method": self.process_info,
- "version": "1"},
-'INF1': {"method": self.process_inf1,
- "version": "1"},
-'INF2': {"method": self.process_inf2,
- "version": "1"},
-'INPT': {"method": self.process_inpt,
- "version": "1"},
-'INST': {"method": self.process_inst,
- "version": "1"},
-'LAMP': {"method": self.process_lamp,
- "version": "1"},
-'LKUP': {"method": self.process_lkup,  # Class 2  (reply only - no cmd)
- "version": "2"},
-'NAME': {"method": self.process_name,
- "version": "1"},
-'PJLINK': {"method": self.process_pjlink,
-   "version": "1"},
-'POWR': {"method": self.process_powr,
- "version": "1"},
-'SNUM': {"method": self.process_snum,
- "version": "1"},
-'SRCH': {"method": self.process_srch,   # Class 2 (reply is ACKN)
- "version": "2"},
-'SVER': {"method": self.process_sver,
- "version": "1"},
-'RFIL':

[Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp

2019-04-20 Thread Ken Roberts 
The proposal to merge lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp has been 
updated.

Description changed to:

NOTE: Part 1 of a multi-part merge. Rest of pjlink2-v[2..n]
  merges are to fix tests

- Move projectors.pjlink.PJLinkCommand class/methods to
  separate projectors.pjlinkcommands module/functions to simplify PJLinkUDP
  commands processing.

- Mark projector tests that involve command processing as
  "skip('Needs update to new setup')" while fixing tests.
NOTE: projector controller tested live and works - some unit tests
  are skipped at this time until fixed.

NOTE: Jenkins tests passed except MacOS (offline) no cli output from MacOS+ 
tests

For more details, see:
https://code.launchpad.net/~alisonken1/openlp/pjlink2-v1/+merge/366334
-- 
Your team OpenLP Core is requested to review the proposed merge of 
lp:~alisonken1/openlp/pjlink2-v1 into lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/gpl3 into lp:openlp

2019-04-20 Thread Tim Bentley 
Review: Needs Information

What about the test files.
Are you going to fix those as well?
-- 
https://code.launchpad.net/~bastian-germann/openlp/gpl3/+merge/365987
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

[Openlp-core] [Bug 1810809] Re: Fails to launch due to dependency on python3-distutils in Ubuntu 18.04/18.10

2019-04-20 Thread mahfiaz 
** Changed in: openlp
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1810809

Title:
  Fails to launch due to dependency on python3-distutils in Ubuntu
  18.04/18.10

Status in OpenLP:
  New

Bug description:
  OpenLP(2.4.6-1) fails to launch on new(clean) install of Ubuntu 18.10.
  Work-around:

  sudo apt install python3-distutils

  
  SOURCE:  
https://forums.openlp.org/discussion/3900/ubuntu-18-04-openlp-can-not-start

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1810809/+subscriptions

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp