[Openlp-core] Linting: Passed
Linting passed! -- https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371851 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/pymysql into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] macOS Test Results: Passed
macOS tests passed! -- https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371851 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/pymysql into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] JavaScript Test Results: Passed
JavaScript tests passed! -- https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371851 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/pymysql into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] Linux Test Results: Passed
Linux tests passed! -- https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371851 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/pymysql into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/pymysql into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/pymysql into
lp:openlp.
Commit message:
Change MySQL-Connector optional dependency to pymysql, a pure-Python MySQL
client.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371851
Change MySQL-Connector optional dependency to pymysql, a pure-Python MySQL
client.
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/pymysql into lp:openlp.
=== modified file 'openlp/core/lib/db.py'
--- openlp/core/lib/db.py 2019-07-03 13:23:23 +
+++ openlp/core/lib/db.py 2019-08-27 04:42:28 +
@@ -67,7 +67,7 @@
create_database(engine.url)
database_exists(engine.url) #=> True
-Borrowed from SQLAlchemy_Utils (v0.32.14 )since we only need this one function.
+Borrowed from SQLAlchemy_Utils (v0.32.14) since we only need this one function.
"""
url = copy(make_url(url))
=== modified file 'scripts/check_dependencies.py'
--- scripts/check_dependencies.py 2019-07-01 22:48:52 +
+++ scripts/check_dependencies.py 2019-08-27 04:42:28 +
@@ -97,7 +97,7 @@
OPTIONAL_MODULES = [
('qdarkstyle', '(dark style support)'),
-('mysql.connector', '(MySQL support)'),
+('pymysql', '(MySQL support)'),
('pyodbc', '(ODBC support)'),
('psycopg2', '(PostgreSQL support)'),
('enchant', '(spell checker)'),
=== modified file 'setup.py'
--- setup.py 2019-07-02 20:29:42 +
+++ setup.py 2019-08-27 04:42:28 +
@@ -191,7 +191,7 @@
extras_require={
'agpl-pdf': ['PyMuPDF'],
'darkstyle': ['QDarkStyle'],
-'mysql': ['mysql-connector-python'],
+'mysql': ['pymysql'],
'odbc': ['pyodbc'],
'postgresql': ['psycopg2'],
'spellcheck': ['pyenchant >= 1.6'],
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/pymysql into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/pymysql into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371825 -- Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/pymysql into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/chromium-tests into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838 -- Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] macOS Tests Succeeded
macOS Tests Passed -- https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/chromium-tests into lp:openlp has been updated. Description changed to: Fix JS tests: - Include the test config in sdist builds - Update the config to work best in Jenkins - Use Chromium rather than Firefox For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838 -- Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/chromium-tests into lp:openlp has been updated. Commit message changed to: Fix JS tests: - Include the test config in sdist builds - Update the config to work best in Jenkins - Use Chromium rather than Firefox For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838 -- Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] Linting: Passed
Linting passed! -- https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] Linux Test Results: Passed
Linux tests passed! -- https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] JavaScript Test Results: Passed
JavaScript tests passed! -- https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/chromium-tests into
lp:openlp.
Commit message:
Change the JS tests to use Chromium rather than Firefox
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371838
Change the JS tests to use Chromium rather than Firefox
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/chromium-tests into lp:openlp.
=== modified file 'MANIFEST.in'
--- MANIFEST.in 2019-08-22 17:11:54 +
+++ MANIFEST.in 2019-08-26 22:18:07 +
@@ -17,3 +17,4 @@
include README.txt
include openlp/.version
include package.json
+include karma.conf.js
=== modified file 'karma.conf.js'
--- karma.conf.js 2019-08-22 17:38:44 +
+++ karma.conf.js 2019-08-26 22:18:07 +
@@ -26,18 +26,21 @@
// source files, that you wanna generate coverage for
// do not include tests or libraries
// (these files will be instrumented by Istanbul)
- "display.js": ["coverage"]
+ // "display.js": ["coverage"]
},
// test results reporter to use
// possible values: "dots", "progress"
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
-reporters: ["progress", "coverage"],
+reporters: ["dots", "junit"],
// configure the coverateReporter
-coverageReporter: {
+/* coverageReporter: {
type : "html",
dir : "htmlcov/"
+}, */
+junitReporter: {
+ outputFile: "test-results.xml"
},
// web server port
@@ -60,11 +63,11 @@
// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-browsers: ["Firefox"],
+browsers: ["Chromium"],
// Continuous Integration mode
// if true, Karma captures browsers, runs the tests and exits
-singleRun: false,
+singleRun: true,
// Concurrency level
// how many browser should be started simultaneous
=== modified file 'package.json'
--- package.json 2019-08-22 17:38:44 +
+++ package.json 2019-08-26 22:18:07 +
@@ -9,9 +9,11 @@
"dependencies": {
"jasmine-core": "^2.6.4",
"karma": "^3.1.4",
+"karma-chrome-launcher": "^3.1.0",
"karma-coverage": "^1.1.2",
+"karma-firefox-launcher": "^1.2.0",
"karma-jasmine": "^1.1.0",
-"karma-firefox-launcher": "^1.2.0",
+"karma-junit-reporter": "^1.2.0",
"karma-log-reporter": "0.0.4"
},
"scripts": {
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/chromium-tests into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371835 -- Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] JavaScript Test Results: Failed
JavaScript tests failed, please see https://ci.openlp.io/job/MP-02-JavaScript-Tests/9/ for more details -- https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371835 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/chromium-tests into
lp:openlp.
Commit message:
Change the JS tests to use Chromium rather than Firefox
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371835
Change the JS tests to use Chromium rather than Firefox
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/chromium-tests into lp:openlp.
=== modified file 'MANIFEST.in'
--- MANIFEST.in 2019-08-22 17:11:54 +
+++ MANIFEST.in 2019-08-26 22:06:42 +
@@ -17,3 +17,4 @@
include README.txt
include openlp/.version
include package.json
+include karma.conf.js
=== modified file 'karma.conf.js'
--- karma.conf.js 2019-08-22 17:38:44 +
+++ karma.conf.js 2019-08-26 22:06:42 +
@@ -26,19 +26,22 @@
// source files, that you wanna generate coverage for
// do not include tests or libraries
// (these files will be instrumented by Istanbul)
- "display.js": ["coverage"]
+ // "display.js": ["coverage"]
},
// test results reporter to use
// possible values: "dots", "progress"
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
-reporters: ["progress", "coverage"],
+reporters: ["dots", "junit"],
// configure the coverateReporter
-coverageReporter: {
+/* coverageReporter: {
type : "html",
dir : "htmlcov/"
-},
+}, */
+junitReporter: {
+ outputFile: "test-results.xml"
+}
// web server port
port: 9876,
@@ -60,11 +63,11 @@
// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-browsers: ["Firefox"],
+browsers: ["Chromium"],
// Continuous Integration mode
// if true, Karma captures browsers, runs the tests and exits
-singleRun: false,
+singleRun: true,
// Concurrency level
// how many browser should be started simultaneous
=== modified file 'package.json'
--- package.json 2019-08-22 17:38:44 +
+++ package.json 2019-08-26 22:06:42 +
@@ -9,9 +9,10 @@
"dependencies": {
"jasmine-core": "^2.6.4",
"karma": "^3.1.4",
+"karma-chrome-launcher": "^3.1.0",
"karma-coverage": "^1.1.2",
+"karma-firefox-launcher": "^1.2.0",
"karma-jasmine": "^1.1.0",
-"karma-firefox-launcher": "^1.2.0",
"karma-log-reporter": "0.0.4"
},
"scripts": {
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/chromium-tests into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371830 -- Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/chromium-tests into
lp:openlp.
Commit message:
Change the JS tests to use Chromium rather than Firefox
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371830
Change the JS tests to use Chromium rather than Firefox
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/chromium-tests into lp:openlp.
=== modified file 'karma.conf.js'
--- karma.conf.js 2019-08-22 17:38:44 +
+++ karma.conf.js 2019-08-26 21:57:52 +
@@ -26,19 +26,22 @@
// source files, that you wanna generate coverage for
// do not include tests or libraries
// (these files will be instrumented by Istanbul)
- "display.js": ["coverage"]
+ // "display.js": ["coverage"]
},
// test results reporter to use
// possible values: "dots", "progress"
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
-reporters: ["progress", "coverage"],
+reporters: ["dots", "junit"],
// configure the coverateReporter
-coverageReporter: {
+/* coverageReporter: {
type : "html",
dir : "htmlcov/"
-},
+}, */
+junitReporter: {
+ outputFile: "test-results.xml"
+}
// web server port
port: 9876,
@@ -60,11 +63,11 @@
// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-browsers: ["Firefox"],
+browsers: ["Chromium"],
// Continuous Integration mode
// if true, Karma captures browsers, runs the tests and exits
-singleRun: false,
+singleRun: true,
// Concurrency level
// how many browser should be started simultaneous
=== modified file 'package.json'
--- package.json 2019-08-22 17:38:44 +
+++ package.json 2019-08-26 21:57:52 +
@@ -9,9 +9,10 @@
"dependencies": {
"jasmine-core": "^2.6.4",
"karma": "^3.1.4",
+"karma-chrome-launcher": "^3.1.0",
"karma-coverage": "^1.1.2",
+"karma-firefox-launcher": "^1.2.0",
"karma-jasmine": "^1.1.0",
-"karma-firefox-launcher": "^1.2.0",
"karma-log-reporter": "0.0.4"
},
"scripts": {
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/chromium-tests into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371829 -- Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] JavaScript Test Results: Failed
JavaScript tests failed, please see https://ci.openlp.io/job/MP-02-JavaScript-Tests/7/ for more details -- https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371829 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/chromium-tests into
lp:openlp.
Commit message:
Change the JS tests to use Chromium rather than Firefox
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371829
Change the JS tests to use Chromium rather than Firefox
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/chromium-tests into lp:openlp.
=== modified file 'karma.conf.js'
--- karma.conf.js 2019-08-22 17:38:44 +
+++ karma.conf.js 2019-08-26 21:52:19 +
@@ -26,7 +26,7 @@
// source files, that you wanna generate coverage for
// do not include tests or libraries
// (these files will be instrumented by Istanbul)
- "display.js": ["coverage"]
+ // "display.js": ["coverage"]
},
// test results reporter to use
@@ -35,10 +35,10 @@
reporters: ["progress", "coverage"],
// configure the coverateReporter
-coverageReporter: {
+/* coverageReporter: {
type : "html",
dir : "htmlcov/"
-},
+}, */
// web server port
port: 9876,
@@ -60,11 +60,11 @@
// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-browsers: ["Firefox"],
+browsers: ["Chromium"],
// Continuous Integration mode
// if true, Karma captures browsers, runs the tests and exits
-singleRun: false,
+singleRun: true,
// Concurrency level
// how many browser should be started simultaneous
=== modified file 'package.json'
--- package.json 2019-08-22 17:38:44 +
+++ package.json 2019-08-26 21:52:19 +
@@ -9,9 +9,10 @@
"dependencies": {
"jasmine-core": "^2.6.4",
"karma": "^3.1.4",
+"karma-chrome-launcher": "^3.1.0",
"karma-coverage": "^1.1.2",
+"karma-firefox-launcher": "^1.2.0",
"karma-jasmine": "^1.1.0",
-"karma-firefox-launcher": "^1.2.0",
"karma-log-reporter": "0.0.4"
},
"scripts": {
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
The proposal to merge lp:~raoul-snyman/openlp/chromium-tests into lp:openlp has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371824 -- Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] JavaScript Test Results: Failed
JavaScript tests failed, please see https://ci.openlp.io/job/MP-02-JavaScript-Tests/5/ for more details -- https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371824 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/chromium-tests into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] JavaScript Test Results: Failed
JavaScript tests failed, please see https://ci.openlp.io/job/MP-02-JavaScript-Tests/6/ for more details -- https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371825 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/pymysql into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/pymysql into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/pymysql into
lp:openlp.
Commit message:
Change MySQL-Connector optional dependency to pymysql, a pure-Python MySQL
client.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/pymysql/+merge/371825
Change MySQL-Connector optional dependency to pymysql, a pure-Python MySQL
client.
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/pymysql into lp:openlp.
=== modified file 'openlp/core/lib/db.py'
--- openlp/core/lib/db.py 2019-07-03 13:23:23 +
+++ openlp/core/lib/db.py 2019-08-26 21:39:23 +
@@ -67,7 +67,7 @@
create_database(engine.url)
database_exists(engine.url) #=> True
-Borrowed from SQLAlchemy_Utils (v0.32.14 )since we only need this one function.
+Borrowed from SQLAlchemy_Utils (v0.32.14) since we only need this one function.
"""
url = copy(make_url(url))
=== modified file 'scripts/check_dependencies.py'
--- scripts/check_dependencies.py 2019-07-01 22:48:52 +
+++ scripts/check_dependencies.py 2019-08-26 21:39:23 +
@@ -97,7 +97,7 @@
OPTIONAL_MODULES = [
('qdarkstyle', '(dark style support)'),
-('mysql.connector', '(MySQL support)'),
+('pymysql', '(MySQL support)'),
('pyodbc', '(ODBC support)'),
('psycopg2', '(PostgreSQL support)'),
('enchant', '(spell checker)'),
=== modified file 'setup.py'
--- setup.py 2019-07-02 20:29:42 +
+++ setup.py 2019-08-26 21:39:23 +
@@ -191,7 +191,7 @@
extras_require={
'agpl-pdf': ['PyMuPDF'],
'darkstyle': ['QDarkStyle'],
-'mysql': ['mysql-connector-python'],
+'mysql': ['pymysql'],
'odbc': ['pyodbc'],
'postgresql': ['psycopg2'],
'spellcheck': ['pyenchant >= 1.6'],
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~raoul-snyman/openlp/chromium-tests into lp:openlp
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/chromium-tests into
lp:openlp.
Commit message:
Change the JS tests to use Chromium rather than Firefox
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/chromium-tests/+merge/371824
Change the JS tests to use Chromium rather than Firefox
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/chromium-tests into lp:openlp.
=== modified file 'karma.conf.js'
--- karma.conf.js 2019-08-22 17:38:44 +
+++ karma.conf.js 2019-08-26 21:37:06 +
@@ -60,7 +60,7 @@
// start these browsers
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-browsers: ["Firefox"],
+browsers: ["Chromium"],
// Continuous Integration mode
// if true, Karma captures browsers, runs the tests and exits
=== modified file 'package.json'
--- package.json 2019-08-22 17:38:44 +
+++ package.json 2019-08-26 21:37:06 +
@@ -9,9 +9,10 @@
"dependencies": {
"jasmine-core": "^2.6.4",
"karma": "^3.1.4",
+"karma-chrome-launcher": "^3.1.0",
"karma-coverage": "^1.1.2",
+"karma-firefox-launcher": "^1.2.0",
"karma-jasmine": "^1.1.0",
-"karma-firefox-launcher": "^1.2.0",
"karma-log-reporter": "0.0.4"
},
"scripts": {
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
[Openlp-core] Linting: Passed
Linting passed! -- https://code.launchpad.net/~trb143/openlp/latest-fixes/+merge/371774 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/latest-fixes into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] Linux Test Results: Passed
Linux tests passed! -- https://code.launchpad.net/~trb143/openlp/latest-fixes/+merge/371774 Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/latest-fixes into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
