Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-t into lp:openlp

2018-10-24 Thread Tomas Groth 
Review: Approve


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-t/+merge/357428
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-t into lp:openlp

2018-10-20 Thread Tim Bentley 
Review: Approve


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-t/+merge/357428
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-t into lp:openlp

2018-10-13 Thread Ken Roberts 
I spent some time trying to work with signals, but since signals have to be 
bound to be used, trying to get a signal connected from the projector code to 
the settings tab instance was convoluted and not as clean as the registry.

The other consideration is how often will projector instances be added/deleted 
once the system is set up and running. The only case where I could think of 
might be a portable setting but once set up should not be changing during 
service. For normal use at a church, I haven't made any changes to projector 
manager since hardware typically does not change unless building gets a 
hardware makeover.

Any suggestions would be appreciated.
-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-t/+merge/356677
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Re: [Openlp-core] [Merge] lp:~alisonken1/openlp/pjlink2-t into lp:openlp

2018-10-13 Thread Tim Bentley 
Review: Needs Fixing

There should be a better way than adding and removing functions from the 
registry.
-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-t/+merge/356677
Your team OpenLP Core is subscribed to branch lp:openlp.

___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp