Re: [Openlp-core] [Merge] lp:~mikey74/openlp/dvdplayerfix into lp:openlp
Some how all this code is in trunk so not needed any more. -- https://code.launchpad.net/~mikey74/openlp/dvdplayerfix/+merge/320253 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~mikey74/openlp/dvdplayerfix into lp:openlp
This text is from: https://bugs.launchpad.net/openlp/+bug/1673986 Mike (mikey74) wrote 51 minutes ago: "Adding/Creating tests seems rather complicated. I am not really familiar with Python, so my venture into the code was limited to minor code changes. If someone wants to take the burden of completing the necessary tests, please feel free." -- https://code.launchpad.net/~mikey74/openlp/dvdplayerfix/+merge/320253 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~mikey74/openlp/dvdplayerfix into lp:openlp
Review: Needs Fixing Hi Mike, Thanks for your contribution! As per our merge criteria, you need a test in order for this to be merged into trunk. Also, you only added the fix to trunk, not to the 2.4 line, so if you wanted to see it in 2.4.6 then you'll need to backport these changes to the 2.4 branch. See the following links for more information: http://wiki.openlp.org/Development:Workflow#Run_Tests_Locally http://wiki.openlp.org/Development:Unit_Tests -- https://code.launchpad.net/~mikey74/openlp/dvdplayerfix/+merge/320253 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
