This is an automated email from Gerrit.
Paul Fertser (fercer...@gmail.com) just uploaded a new patch set to Gerrit,
which you can find at http://openocd.zylin.com/1948
-- gerrit
commit 548e0ac9ab040206f1cd78e3f4037eb8e79ee67f
Author: Paul Fertser <fercer...@gmail.com>
Date: Sat Feb 15 22:43:38 2014 +0400
drivers/ftdi: warn the user if he tries to use undefined reset signals
It is really an error to try to use a reset_config that doesn't match
adapter's capabilities, however OpenOCD has no way to specify them.
Using wrong reset_config might lead to very confusing behaviour, so I
think LOG_ERROR is justified here.
Change-Id: I1c6dcfa7c0d78829229a850189cad646b565dd66
Signed-off-by: Paul Fertser <fercer...@gmail.com>
diff --git a/src/jtag/drivers/ftdi.c b/src/jtag/drivers/ftdi.c
index a6070b1..81b27c2 100644
--- a/src/jtag/drivers/ftdi.c
+++ b/src/jtag/drivers/ftdi.c
@@ -472,8 +472,11 @@ static void ftdi_execute_reset(struct jtag_command *cmd)
tap_set_state(TAP_RESET);
struct signal *trst = find_signal_by_name("nTRST");
- if (trst && cmd->cmd.reset->trst == 1) {
- ftdi_set_signal(trst, '0');
+ if (cmd->cmd.reset->trst == 1) {
+ if (trst)
+ ftdi_set_signal(trst, '0');
+ else
+ LOG_ERROR("Can't assert TRST: nTRST signal is not
defined");
} else if (trst && cmd->cmd.reset->trst == 0) {
if (jtag_get_reset_config() & RESET_TRST_OPEN_DRAIN)
ftdi_set_signal(trst, 'z');
@@ -482,8 +485,11 @@ static void ftdi_execute_reset(struct jtag_command *cmd)
}
struct signal *srst = find_signal_by_name("nSRST");
- if (srst && cmd->cmd.reset->srst == 1) {
- ftdi_set_signal(srst, '0');
+ if (cmd->cmd.reset->srst == 1) {
+ if (srst)
+ ftdi_set_signal(srst, '0');
+ else
+ LOG_ERROR("Can't assert SRST: nSRST signal is not
defined");
} else if (srst && cmd->cmd.reset->srst == 0) {
if (jtag_get_reset_config() & RESET_SRST_PUSH_PULL)
ftdi_set_signal(srst, '1');
--
------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel
