[Openocd-development] Gerrit mail subject
Hello, is there any chance to reduce the gerrit subject line to a normal length with more information at the beginning? Currently the subject consist of 50% static text at the beginning. [Openocd-development] New patch to review for openocd: XXX bugfixes: Thanks, Mathias ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit mail subject
openocd-development-boun...@lists.berlios.de wrote: is there any chance to reduce the gerrit subject line to a normal length with more information at the beginning? Currently the subject consist of 50% static text at the beginning. [Openocd-development] New patch to review for openocd: XXX bugfixes: I agree. maybe one or two characters of the commit-id are all I see before the subject gets chopped off on my display. In fact I would get rid of [Openocd-development] too. There are headers for sorting mail, other mailing lists I use don't have this, and are more usable for that IMO. -- Jon Povey jon.po...@racelogic.co.uk Racelogic is a limited company registered in England. Registered number 2743719 . Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks, MK18 1TB . The information contained in this electronic mail transmission is intended by Racelogic Ltd for the use of the named individual or entity to which it is directed and may contain information that is confidential or privileged. If you have received this electronic mail transmission in error, please delete it from your system without copying or forwarding it, and notify the sender of the error by reply email so that the sender's address records can be corrected. The views expressed by the sender of this communication do not necessarily represent those of Racelogic Ltd. Please note that Racelogic reserves the right to monitor e-mail communications passing through its network ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] checkpatch enabled
Hi, All patches submitted to gerrit will be verified using checkpatch. Also just to give you insight on the jenkins setup: http://openocd.zylin.com/jenkins/ we have a few jobs configured: openocd - built whenever master branch changes. openocd-gerrit - run whenever a change is sent to gerrit - also runs checkpatch against change. openocd-clang - runs clang whenever openocd job changes openocd-build - runs various host builds whenever openocd job changes - currently linux32, mingw32 and mingw64 builds are checked. Cheers Spen ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit mail subject
Jon Povey wrote: is there any chance to reduce the gerrit subject line to a normal length with more information at the beginning? Currently the subject consist of 50% static text at the beginning. [Openocd-development] New patch to review for openocd: XXX bugfixes: I agree. maybe one or two characters of the commit-id are all I see before the subject gets chopped off on my display. I just changed it to New openocd patch: xxx In fact I would get rid of [Openocd-development] too. +1 but since this is a bit more established maybe give people time to change their filters? Or just change it and people will change after? //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Modify a git commit ?
HI, I have create a change in one of my patch that i have already sent. I commited it, but I forget to add the signed-off by... Is it possible to edit a commit message ? Jonathan ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Modify a git commit ?
On 28 October 2011 15:21, Jonathan Dumaresq jdumar...@cimeq.qc.ca wrote: HI, I have create a change in one of my patch that i have already sent. I commited it, but I forget to add the signed-off by... Is it possible to edit a commit message ? Jonathan git commit -s --amend Spen ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Modify a git commit ?
Hi spen, I'm pretty sure I have something wrong. I would like to only push the commit 7cc475d31a8289c35d41a377ddc54c55b352be80. I want to reedit it to add the signed off. Is it possible ? $ git log commit a8558a1a9bf558fea7dec027c424f010b2e97982 Merge: 7cc475d 9780683 Author: Jonathan Dumaresq jdumar...@cimeq.qc.ca Date: Fri Oct 28 10:05:30 2011 -0400 Merge branch 'master' of git://openocd.git.sourceforge.net/gitroot/openocd/o Change-Id: Ib5ae7f423c165add1190435cd874fcc80cd845d4 Signed-off-by: Jonathan Dumaresq jdumar...@cimeq.qc.ca modified: src/flash/nor/stm32f1x.c commit 97806831e25e8b75c02d61a30a98b18e090619f2 Author: Øyvind Harboe oyvind.har...@zylin.com Date: Thu Oct 27 23:51:50 2011 +0200 bugfixes: numerous bugs in error propagation found by clang Change-Id: I784068325b422d1918e28c08544bc5a1332d712f Signed-off-by: Øyvind Harboe oyvind.har...@zylin.com Reviewed-on: http://openocd.zylin.com/130 Tested-by: jenkins Reviewed-by: Øyvind Harboe oyvindhar...@gmail.com commit 7cc475d31a8289c35d41a377ddc54c55b352be80 Author: Jonathan Dumaresq jdumar...@cimeq.qc.ca Date: Thu Oct 27 14:50:36 2011 -0400 Correct a typo for page size Regards Jonathan Spencer Oliver wrote: On 28 October 2011 15:21, Jonathan Dumaresq jdumar...@cimeq.qc.ca wrote: HI, I have create a change in one of my patch that i have already sent. I commited it, but I forget to add the signed-off by... Is it possible to edit a commit message ? Jonathan git commit -s --amend Spen ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Modify a git commit ?
I have create a change in one of my patch that i have already sent. I commited it, but I forget to add the signed-off by... Is it possible to edit a commit message ? See here for more information about reworking patch series: http://book.git-scm.com/4_interactive_rebasing.html Yegor ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] openocd patch: 1533d9d cfi: unsupported code paths are now covered by asserts
This is an automated email from Gerrit.
?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit,
which you can find at http://openocd.zylin.com/133
-- gerrit
commit 1533d9d1fbb0c09e1fcc8d42a02402adaa4011ad
Author: Øyvind Harboe oyvind.har...@zylin.com
Date: Fri Oct 28 17:22:32 2011 +0200
cfi: unsupported code paths are now covered by asserts
Change-Id: If7d7aca8514575d229ed0b17378bf8b1bbf347c4
Signed-off-by: Øyvind Harboe oyvind.har...@zylin.com
diff --git a/src/flash/nor/cfi.c b/src/flash/nor/cfi.c
index f75efac..cd5b31f 100644
--- a/src/flash/nor/cfi.c
+++ b/src/flash/nor/cfi.c
@@ -1912,11 +1912,9 @@ static int cfi_spansion_write_block(struct flash_bank
*bank, uint8_t *buffer,
switch (bank-bus_width)
{
case 1 :
- if(armv4_5_info.common_magic == ARM_COMMON_MAGIC) /* armv4_5
target */
- {
- target_code_src = armv4_5_word_8_code;
- target_code_size = sizeof(armv4_5_word_8_code);
- }
+ assert(armv4_5_info.common_magic == ARM_COMMON_MAGIC);
+ target_code_src = armv4_5_word_8_code;
+ target_code_size = sizeof(armv4_5_word_8_code);
break;
case 2 :
/* Check for DQ5 support */
@@ -1931,24 +1929,20 @@ static int cfi_spansion_write_block(struct flash_bank
*bank, uint8_t *buffer,
{
target_code_src = armv7m_word_16_code;
target_code_size = sizeof(armv7m_word_16_code);
- }
+ } else assert(false);
}
else
{
/* No DQ5 support. Use DQ7 DATA# polling only. */
- if(armv4_5_info.common_magic == ARM_COMMON_MAGIC) //
armv4_5 target
- {
- target_code_src = armv4_5_word_16_code_dq7only;
- target_code_size =
sizeof(armv4_5_word_16_code_dq7only);
- }
+ assert(armv4_5_info.common_magic == ARM_COMMON_MAGIC);
+ target_code_src = armv4_5_word_16_code_dq7only;
+ target_code_size = sizeof(armv4_5_word_16_code_dq7only);
}
break;
case 4 :
- if(armv4_5_info.common_magic == ARM_COMMON_MAGIC) // armv4_5
target
- {
- target_code_src = armv4_5_word_32_code;
- target_code_size = sizeof(armv4_5_word_32_code);
- }
+ assert(armv4_5_info.common_magic == ARM_COMMON_MAGIC);
+ target_code_src = armv4_5_word_32_code;
+ target_code_size = sizeof(armv4_5_word_32_code);
break;
default:
LOG_ERROR(Unsupported bank buswidth %d, can't do block memory
writes, bank-bus_width);
--
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit mail subject
Hello, can you remove the magic incomplete number too? In this case the 1533d9d. This number is useless in the subject: [Openocd-development] openocd patch: 1533d9d cfi: unsupported code paths are now covered by asserts Now we have 2 times openocd as static text left. Do you think we need it? Regards, Mathias Am 28.10.2011 16:14, schrieb Peter Stuge: Jon Povey wrote: is there any chance to reduce the gerrit subject line to a normal length with more information at the beginning? Currently the subject consist of 50% static text at the beginning. [Openocd-development] New patch to review for openocd: XXX bugfixes: I agree. maybe one or two characters of the commit-id are all I see before the subject gets chopped off on my display. I just changed it to New openocd patch: xxx In fact I would get rid of [Openocd-development] too. +1 but since this is a bit more established maybe give people time to change their filters? Or just change it and people will change after? //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit mail subject
Hello, another case. Every user use [PATCH] if he send a patch to the mailinglist. Why we should not use [REVIEW] for the gerrit messages? [Openocd-development] [PATCH] cfi: unsupported code paths are now covered by asserts [Openocd-development] [REVIEW] cfi: unsupported code paths are now covered by asserts Regards, Mathias Am 28.10.2011 20:03, schrieb Mathias K.: Hello, can you remove the magic incomplete number too? In this case the 1533d9d. This number is useless in the subject: [Openocd-development] openocd patch: 1533d9d cfi: unsupported code paths are now covered by asserts Now we have 2 times openocd as static text left. Do you think we need it? Regards, Mathias Am 28.10.2011 16:14, schrieb Peter Stuge: Jon Povey wrote: is there any chance to reduce the gerrit subject line to a normal length with more information at the beginning? Currently the subject consist of 50% static text at the beginning. [Openocd-development] New patch to review for openocd: XXX bugfixes: I agree. maybe one or two characters of the commit-id are all I see before the subject gets chopped off on my display. I just changed it to New openocd patch: xxx In fact I would get rid of [Openocd-development] too. +1 but since this is a bit more established maybe give people time to change their filters? Or just change it and people will change after? //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit mail subject
Mathias K. wrote: can you remove the magic incomplete number too? In this case the 1533d9d. This number is useless in the subject: I disagree. This is an abbreviated commit hash, which identifies the commit that was pushed. There's also Gerrit's identifiers, but losing the commit hash would be impractical. [Openocd-development] openocd patch: 1533d9d cfi: unsupported code paths are now covered by asserts Now we have 2 times openocd as static text left. Do you think we need it? My idea is obviously that we'll remove the first one. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit mail subject
Hello, Am 28.10.2011 20:15, schrieb Peter Stuge: Mathias K. wrote: can you remove the magic incomplete number too? In this case the 1533d9d. This number is useless in the subject: I disagree. This is an abbreviated commit hash, which identifies the commit that was pushed. There's also Gerrit's identifiers, but losing the commit hash would be impractical. Okay, is it possible to change the commit message on a commit with the same commit hash? If so the hash make sense to sort the messages. [Openocd-development] openocd patch: 1533d9d cfi: unsupported code paths are now covered by asserts Now we have 2 times openocd as static text left. Do you think we need it? My idea is obviously that we'll remove the first one. When you move to sourceforge this can be done in this step. Maybe you can remove the prefix completely. I think the List-Id in the mail header is enough to filter the mail. Regards, Mathias ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
