This is an automated email from Gerrit.

?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/142

-- gerrit

commit 91a30acedbbd5477e7a22aba4785d7eb5e6b81b2
Author: Øyvind Harboe <oyvind.har...@zylin.com>
Date:   Mon Oct 31 21:21:35 2011 +0100

    warnings: null pointer check fix
    
    rewrite broken null pointer check code by reducing scope
    of variable.
    
    Change-Id: I8254f6849b187e5c9cd083053cdc11973c6fe339
    Signed-off-by: Øyvind Harboe <oyvind.har...@zylin.com>

diff --git a/src/target/target_request.c b/src/target/target_request.c
index 3cdca5e..1fedfb2 100644
--- a/src/target/target_request.c
+++ b/src/target/target_request.c
@@ -194,11 +194,9 @@ static int add_debug_msg_receiver(struct command_context 
*cmd_ctx, struct target
 static struct debug_msg_receiver* find_debug_msg_receiver(struct 
command_context *cmd_ctx, struct target *target)
 {
        int do_all_targets = 0;
-       struct debug_msg_receiver **p = &target->dbgmsg;
 
        /* if no target has been specified search all of them */
-       if (target == NULL)
-       {
+       if (target == NULL) {
                /* if no targets haven been specified */
                if (all_targets == NULL)
                        return NULL;
@@ -207,8 +205,9 @@ static struct debug_msg_receiver* 
find_debug_msg_receiver(struct command_context
                do_all_targets = 1;
        }
 
-       do
-       {
+       /* so we target != null */
+       struct debug_msg_receiver **p = &target->dbgmsg;
+       do {
                while (*p)
                {
                        if ((*p)->cmd_ctx == cmd_ctx)

-- 
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to