Re: [Openocd-development] openocd patch: 96c3cbf cortex_m: add missing error checking

2011-11-02 Thread Andreas Fritiofson 
On Tue, Nov 1, 2011 at 11:16 PM, Tomek CEDRO tomek.ce...@gmail.com wrote:

 Hey does this code is related anyhow to arm_adi_v5 or this is totally
 alternative solution?


Yes, it *uses* arm_adi_v5.

/Andreas
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

[Openocd-development] openocd patch: 96c3cbf cortex_m: add missing error checking

2011-11-01 Thread gerrit 
This is an automated email from Gerrit.

?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/152

-- gerrit

commit 96c3cbfab96ef837464189de0cbc66ce3400172a
Author: Øyvind Harboe oyvind.har...@zylin.com
Date:   Tue Nov 1 22:53:54 2011 +0100

cortex_m: add missing error checking

found by clang.

Change-Id: I099c6fe6b044dba36c20221cb439bdcba5a6bb6f
Signed-off-by: Øyvind Harboe oyvind.har...@zylin.com

diff --git a/src/target/cortex_m.c b/src/target/cortex_m.c
index 8000b9a..2a283cd 100644
--- a/src/target/cortex_m.c
+++ b/src/target/cortex_m.c
@@ -124,16 +124,20 @@ static int cortexm3_dap_write_coreregister_u32(struct 
adiv5_dap *swjdp,
if (retval != ERROR_OK)
return retval;
retval = dap_queue_ap_write(swjdp, AP_REG_BD0 | (DCB_DCRDR  0xC), 
value);
-   // XXX check retval
+   if (retval != ERROR_OK)
+   return retval;
 
/* mem_ap_write_u32(swjdp, DCB_DCRSR, i | DCRSR_WnR); */
retval = dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, 
DCB_DCRSR  0xFFF0);
if (retval != ERROR_OK)
return retval;
retval = dap_queue_ap_write(swjdp, AP_REG_BD0 | (DCB_DCRSR  0xC), 
regnum | DCRSR_WnR);
-   // XXX check retval
+   if (retval != ERROR_OK)
+   return retval;
 
retval = dap_run(swjdp);
+   if (retval != ERROR_OK)
+   return retval;
 
/* restore DCB_DCRDR - this needs to be in a seperate
 * transaction otherwise the emulated DCC channel breaks */

-- 
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] openocd patch: 96c3cbf cortex_m: add missing error checking

2011-11-01 Thread Tomek CEDRO 
Hey does this code is related anyhow to arm_adi_v5 or this is totally
alternative solution?

-- 
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development