Re: [Openocd-development] [PATCH] debug: debug entry error propagation

2010-07-19 Thread Andreas Fritiofson
Considering the huge number of identical if (retval != ERROR_OK)
return retval; added in this and your other patches, maybe we should
reuse the CHECK_RETVAL macro from arm11.h as a general mechanism to
reduce the clutter? It may not be the best of practices to return from
a macro, but rules are made to be broken, right?

--
Andreas
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] [PATCH] debug: debug entry error propagation

2010-07-19 Thread Øyvind Harboe
On Mon, Jul 19, 2010 at 9:56 PM, Andreas Fritiofson
andreas.fritiof...@gmail.com wrote:
 Considering the huge number of identical if (retval != ERROR_OK)
 return retval; added in this and your other patches, maybe we should
 reuse the CHECK_RETVAL macro from arm11.h as a general mechanism to
 reduce the clutter? It may not be the best of practices to return from
 a macro, but rules are made to be broken, right?

Of course with exception handling, even the CHECK_RETVAL clutter
would go away...

-- 
Øyvind Harboe
US toll free 1-866-980-3434 / International +47 51 63 25 00
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development