Re: [Openocd-development] [PATCH 1/5] ft2232: Clean up infinite loop condition in ft2232_init()

2011-06-09 Thread Øyvind Harboe
Can I commit?

Surely this one is straightforward!!!??? :-)




-- 
Øyvind Harboe

Can Zylin Consulting help on your project?

US toll free 1-866-980-3434 / International +47 51 87 40 27

http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] [PATCH 1/5] ft2232: Clean up infinite loop condition in ft2232_init()

2011-06-09 Thread Peter Stuge
Øyvind Harboe wrote:
 Can I commit?

Sorry - I messed up the sending a little, I'm resending the full
series right now. The patch is the same though.


 Surely this one is straightforward!!!??? :-)

Yes. Let's see what people think of the other ones. (There be goto.)


//Peter
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] [PATCH 1/5] ft2232: Clean up infinite loop condition in ft2232_init()

2011-06-09 Thread Andreas Fritiofson
On Thu, Jun 9, 2011 at 12:12 PM, Peter Stuge pe...@stuge.se wrote:

 -   for (int i = 0; 1; i++)
 +   for (int i = 0; ft2232_vid[i] || ft2232_pid[i]; i++)


What's the point? This condition can never become false, or the function
would have returned in the previous iteration.

/Andreas
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development