Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms
On Wed, Aug 31, 2011 at 1:21 AM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Tue, Aug 16, 2011 at 8:40 AM, Simon Barner bar...@gmx.de wrote: On 16.08.2011 01:25, Andreas Fritiofson wrote: On Wed, Aug 10, 2011 at 12:01 AM, Spencer Oliver s...@spen-soft.co.uk mailto:s...@spen-soft.co.uk wrote: On 09/08/2011 22:15, Øyvind Harboe wrote: Any objections? I would like to give this a test-run tomorrow. Did you (or anyone else for that matter) get a chance to test it? Yes, I tested it and got a speedup of about 50 percent. I intend to merge these patches in a few days. Objections? Well, s/days/weeks/ but they're merged now. /Andreas ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms
On Tue, Aug 16, 2011 at 8:40 AM, Simon Barner bar...@gmx.de wrote: On 16.08.2011 01:25, Andreas Fritiofson wrote: On Wed, Aug 10, 2011 at 12:01 AM, Spencer Oliver s...@spen-soft.co.uk mailto:s...@spen-soft.co.uk wrote: On 09/08/2011 22:15, Øyvind Harboe wrote: Any objections? I would like to give this a test-run tomorrow. Did you (or anyone else for that matter) get a chance to test it? Yes, I tested it and got a speedup of about 50 percent. I intend to merge these patches in a few days. Objections? /Andreas ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms
Any objections? I tried the command line below and it worked perfectly! :-) git checkout origin/master git pull --rebase http://repo.or.cz/r/openocd/andreasf.git async_algo -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms
On 09/08/2011 22:15, Øyvind Harboe wrote: Any objections? I would like to give this a test-run tomorrow. One observation - other targets that do not yet support the new functions will output a LOG_ERROR to the user. Maybe this should be a LOG_DEBUG as the user will have no idea what it means. Cheers Spen ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms
On Wed, Aug 10, 2011 at 12:01 AM, Spencer Oliver s...@spen-soft.co.ukwrote:
On 09/08/2011 22:15, Øyvind Harboe wrote:
Any objections?
I would like to give this a test-run tomorrow.
One observation - other targets that do not yet support the new functions
will output a LOG_ERROR to the user. Maybe this should be a LOG_DEBUG as the
user will have no idea what it means.
Cheers
Spen
+ if (!target-type-start_algorithm) {
+ LOG_ERROR(Target type '%s' does not support %s,
+ target_type_name(target), __func__);
Are you referring to this? That's in line with the corresponding check in
target_run_algorithm(), I think. If some code is executing
target_xxx_algorithm() when it isn't supported by the target in question,
that's clearly an error, right?
Well, I can see a scenario where for example an architecture specific
checksum_memory function had been (re-)written to make use of
target_start/wait_algorithm, and a target x of that architecture points to
that checksum_memory function as well as the architecture's
start/wait_algorithm functions. If another target of the same architecture
uses the same checksum_memory function but hasn't yet populated the
start/wait_algorithm pointers, then the user would get an ERROR when
checksumming on that target. On the other hand, maybe that's a good way to
make someone update the target's pointers. LOG_ERROR or LOG_DEBUG, I don't
care much. It shouldn't happen in the current tree anyway, unless I've
overlooked something.
/Andreas
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms
On 23:15 Tue 09 Aug , Øyvind Harboe wrote: Any objections? I tried the command line below and it worked perfectly! :-) git checkout origin/master git pull --rebase http://repo.or.cz/r/openocd/andreasf.git async_algo normaly it's, we do not rebase the code git merge http://repo.or.cz/r/openocd/andreasf.git async_algo no pull --rebase Best Regards, J. ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms
On Wed, Aug 10, 2011 at 1:02 AM, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On 23:15 Tue 09 Aug , Øyvind Harboe wrote: Any objections? I tried the command line below and it worked perfectly! :-) git checkout origin/master git pull --rebase http://repo.or.cz/r/openocd/andreasf.git async_algo normaly it's, we do not rebase the code If it works, why wouldn't we want a linear history? I don't object, but I am genuinely interested in an explanation. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
