Re: Spec file shtool/build policy
Thomas Lotterer wrote: I remember we put some efforts into moving almost every patch-like shtool subst construct into the %prep section to complement the %patch instructions. Besides developer's convenience I do not see a reason why automated source tweaking should be split and partially moved outside the %prep section. Deferring substitions to the %build section sometimes inhibits repetitive execution via rpm --short-circuit which means a shift would move the paint to a different location with no real cure. Hi, I would agree with Thomas here and I think we will have to consider two different scenarios in which the shtool subst is used. First usage is as a patch replacement for fixing bugs and general problems. Shtools would be used here for the change is simple, can be done easily and avoids adding an additional patch file to the distribution. I personally would expect such substitutions to be placed the same as the patch command. The second usage is for treating files to adhere to the OpenPKG layout standards, replacing pathnames , tweaking config files before and after configure has been run and the like. This should be done in the build section. So. to me it looks like there is no general don't use shtool subst in %prep possible. Just my two cents. Regards, Torsten -- Torsten Homeyer [EMAIL PROTECTED] http://www.homeyert.net __ The OpenPKG Projectwww.openpkg.org Developer Communication List openpkg-dev@openpkg.org
[OpenPKG] Version Tracking Report (2006-02-15 19:11)
OpenPKG Version Tracking Report === Reporting Time:2006-02-15 19:11 Tracking Duration: 1:22:33 (H:M:S) Tracking Input:1784 sources (929 packages) Tracking Result: 1610 up-to-date, 50 out-dated, 124 error The following 50 sources were determined to be out-dated because newer vendor versions were found. Upgrade the corresponding OpenPKG packages. - - - Package Old Version New Version - - - apache2 2.0.552.2.0 bochs 2.2.1 2.2.6 boost 1_33_01_33_1 coreutils:release 5.93 5.94 diogene87 1.0.0pre2 1.0.0pre3 expect:expect 5.43.05.44.1 firefox 1.0.7 1.5.0.1 freeradius1.0.5 1.1.0 ganttproject 1.10.32.0 gdb 6.3 6.4 glibmm2.8.4 2.9.1 gnupg 1.4.2 1.4.2.1 heartbeat 2.0.2 2.0.3 honeyd1.0 1.5 jboss 3.2.7 3.2.8 kde-arts 1.4.2 1.5.1 [1] kde-base 3.2.3 3.5.1 [2] kde-libs 3.4.2 3.5.1 [3] ksh 2005-02-022006-01-24 ksh:init 2005-02-022006-01-24 libdnet 1.10 1.11 libextractor 0.5.7 0.5.9 libnetdude0.7 0.8 libpcapnav0.6 0.7 libvncserver 0.7.1 0.8 lighttpd 1.4.9 1.4.10 mesa:MesaDemos6.2.1 6.4.2 mesa:MesaLib 6.2.1 6.4.2 mozilla-mplayer 3.15 3.21 opera:freebsd 851 852 opera:linux 851 852 opera:solaris 851 852 papyrus 1.4.4 1.5.2 parrot0.4.0 0.4.1 pax 2005-02-022006-01-24 pax:init 2005-02-022006-01-24 pearpc0.3.1 0.4 popt 1.10.21.10.4[4] qt4 4.0.1 4.1.0 scribus 1.3.1 1.3.2 [5] smokeping 2.0.6 2.0.7 taskjuggler 2.1.1 2.2.0 wine 0.9.6 0.9.8 x11vnc0.7.2 0.8 xalan-c 1_6 1_10_0 xine-ui 0.99.30.99.4 xorg 6.8.2 7.0 xpdf:patchlevel 1 2 zoem 06-01006-046 zope 2.8.5 2.9.0 - - - [1] kde-arts: thl/1.4.3: configure Qt (= Qt 3.3 and 4.0) (library qt-mt) not found, although qt-3.3.5 installed [2] kde-base: thl/3.4.3: requires kde-arts which is currently broken [3] kde-libs: thl/3.4.2: requires kde-arts which is currently broken [4] popt: rse: 1.10.3 has lots of files missing (depcomp, install.sh, ltmain, etc) [5] scribus: thl/1.3.1: scribus/libpostscript: No such file or directory The following 124 sources could not be successfully checked because an error occurred while processing. Keep at least an eye on them. - - - Package Old Version Error - - - apache:mod_security 1.8.7 regex didn't match (pro.. apachetop 0.12.5regex didn't match (pro.. calltree 2.3 connection failed or ti.. ccache2.4 regex didn't match (pro.. cdrecord:cdrtools 2.01 connection failed or ti.. cvs:cvslock 0.2
[OpenPKG] Version Tracking Report (2006-02-16 07:06)
OpenPKG Version Tracking Report === Reporting Time:2006-02-16 07:06 Tracking Duration: 0:54:45 (H:M:S) Tracking Input:1784 sources (929 packages) Tracking Result: 1109 up-to-date, 48 out-dated, 627 error The following 48 sources were determined to be out-dated because newer vendor versions were found. Upgrade the corresponding OpenPKG packages. - - - Package Old Version New Version - - - apache2 2.0.552.2.0 bash:patches 31-00731-008 bochs 2.2.1 2.2.6 boost 1_33_01_33_1 coreutils:release 5.93 5.94 diogene87 1.0.0pre2 1.0.0pre3 expect:expect 5.43.05.44.1 firefox 1.0.7 1.5.0.1 freeradius1.0.5 1.1.0 ganttproject 1.10.32.0 gdb 6.3 6.4 glibmm2.8.4 2.9.1 heartbeat 2.0.2 2.0.3 honeyd1.0 1.5 jboss 3.2.7 3.2.8 kde-arts 1.4.2 1.5.1 [1] kde-base 3.2.3 3.5.1 [2] kde-libs 3.4.2 3.5.1 [3] ksh 2005-02-022006-01-24 ksh:init 2005-02-022006-01-24 libdnet 1.10 1.11 libextractor 0.5.7 0.5.9 libnetdude0.7 0.8 libvncserver 0.7.1 0.8 lighttpd 1.4.9 1.4.10 mesa:MesaDemos6.2.1 6.4.2 mesa:MesaLib 6.2.1 6.4.2 mozilla-mplayer 3.15 3.21 papyrus 1.4.4 1.5.2 parrot0.4.0 0.4.1 pax 2005-02-022006-01-24 pax:init 2005-02-022006-01-24 pearpc0.3.1 0.4 php-eaccelerator 0.9.4-rc2 0.9.4 popt 1.10.21.10.4[4] qt4 4.0.1 4.1.0 scribus 1.3.1 1.3.2 [5] smokeping 2.0.6 2.0.7 taskjuggler 2.1.1 2.2.0 tin 1.8.0 1.8.1 top 3.6beta4 3.6beta5 wine 0.9.6 0.9.8 x11vnc0.7.2 0.8 xalan-c 1_6 1_10_0 xine-ui 0.99.30.99.4 xorg 6.8.2 7.0 xpdf:patchlevel 1 2 zope 2.8.5 2.9.0 - - - [1] kde-arts: thl/1.4.3: configure Qt (= Qt 3.3 and 4.0) (library qt-mt) not found, although qt-3.3.5 installed [2] kde-base: thl/3.4.3: requires kde-arts which is currently broken [3] kde-libs: thl/3.4.2: requires kde-arts which is currently broken [4] popt: rse: 1.10.3 has lots of files missing (depcomp, install.sh, ltmain, etc) [5] scribus: thl/1.3.1: scribus/libpostscript: No such file or directory The following 627 sources could not be successfully checked because an error occurred while processing. Keep at least an eye on them. - - - Package Old Version Error - - - apache:mod_security 1.8.7 regex didn't match (pro.. apachetop 0.12.5regex didn't match (pro.. aspell:aspell-perl0.05 regex didn't match (pro.. ccache2.4 regex didn't match (pro.. cvs:cvslock 0.2 connection failed or ti.. enscript 1.6.3 regex didn't match (p [1] epm 3.7 2nd connection failed [2]
