Re: [devel] [PATCH 0 of 1] Review Request for IMM: fix memory leak in saImmOmAccessorGet_2 [#549]
Hi zoran, Reviewed the patch. Ack Neel. On Wednesday 21 August 2013 05:51 PM, Zoran Milinkovic wrote: > Summary: IMM: fix memory leak in saImmOmAccessorGet_2 [#549] > Review request for Trac Ticket(s): 549 > Peer Reviewer(s): Neel > Pull request to: Zoran > Affected branch(es): default(4.4) > Development branch: default(4.4) > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesy > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > - > > changeset 1e990cf4235cec566e9f093b1331791e475d0ea7 > Author: Zoran Milinkovic > Date: Wed, 21 Aug 2013 14:11:16 +0200 > > IMM: fix memory leak in saImmOmAccessorGet_2 [#549] > > The fix frees a memory for an object name in saImmOmAccessorGet_2. > > > Complete diffstat: > -- > osaf/libs/agents/saf/imma/imma_om_api.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > > Testing Commands: > - > valgrind --leak-check=full immomtest > > > Testing, Expected Results: > -- > Run immomtest using valgrind. Memory leak in "immsv_evt_dec_inline_string" > should be gone. > > > Conditions of Submission: > - > Ack from Neel. > > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 0 of 5] Review Request for amfsv #533
It is not entirely wrong, SA-Forum talks about both AMF and SMF as a service in the "CPROG" document and specifies the DN: * Availability Management Framework "safApp=safAmfService" So we could use "amfsv" but "amf" is shorter and sweeter. So agree, "amf" it is. Do I have an ack? Thanks, Hans > -Original Message- > From: praveen malviya [mailto:praveen.malv...@oracle.com] > Sent: den 26 augusti 2013 08:51 > To: Hans Feldt > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 0 of 5] Review Request for amfsv #533 > > I think word "service" is not used for AMF and SMF. So instead of > renaming "avsv" to "amfsv", can it be renamed to "amf"? > > Thanks, > Praveen > On 23-Aug-13 6:28 PM, Hans Feldt wrote: > > Summary: rename avsv > > Review request for Trac Ticket(s): 533 > > Peer Reviewer(s): Praveen & Nags > > Pull request to: <> > > Affected branch(es): default > > Development branch: default > > > > > > Impacted area Impact y/n > > > > Docsn > > Build systemy > > RPM/packaging n > > Configuration files n > > Startup scripts n > > SAF servicesn > > OpenSAF servicesn > > Core libraries n > > Samples n > > Tests n > > Other n > > > > > > Comments (indicate scope for each "y" above): > > - > > > > changeset 1abf7f5a01dbf7d2936c2bb55ac711fec55e7f90 > > Author: Hans Feldt > > Date: Fri, 23 Aug 2013 14:44:51 +0200 > > > > rename avsv to amfsv [#533] > > > > In order to align AMF specification, ticket system and source code the > > avsv > > name is with this patch changed to amfsv. avsv is a relic from opensaf3 > > and > > earlier where avsv contained both clm and amf. > > > > changeset fa172b7214fec6d20c3ea85049a71967f149faa7 > > Author: Hans Feldt > > Date: Fri, 23 Aug 2013 14:45:32 +0200 > > > > amfsv: rename libavsv_common to libamfsv_common [#533] > > > > changeset f768c5f9650aa9a6c7919bab111072d5450a79fd > > Author: Hans Feldt > > Date: Fri, 23 Aug 2013 14:47:10 +0200 > > > > amfsv: rename common lib files [533] > > > > changeset 0445048b508dd303f2cbd6c238852ea2999a437d > > Author: Hans Feldt > > Date: Fri, 23 Aug 2013 14:47:22 +0200 > > > > amfsv: rename avsv xml files [#533] > > > > changeset 308d79cca35f9d1b274552ad962088804214debc > > Author: Hans Feldt > > Date: Fri, 23 Aug 2013 14:49:56 +0200 > > > > amfsv: remove avsv tests [#533] > > > > > > Complete diffstat: > > -- > > configure.ac | 34 > > +- > > osaf/libs/agents/saf/Makefile.am | 2 +- > > osaf/libs/agents/saf/ava/Makefile.am | 5 ++--- > > osaf/libs/agents/saf/ava/ava_api.c| 0 > > osaf/libs/agents/saf/ava/ava_hdl.c| 0 > > osaf/libs/agents/saf/ava/ava_init.c | 0 > > osaf/libs/agents/saf/ava/ava_mds.c| 0 > > osaf/libs/agents/saf/ava/ava_op.c | 0 > > osaf/libs/agents/saf/ava/include/Makefile.am | 0 > > osaf/libs/agents/saf/ava/include/ava.h| 8 > > osaf/libs/agents/saf/ava/include/ava_cb.h | 0 > > osaf/libs/agents/saf/ava/include/ava_def.h| 0 > > osaf/libs/agents/saf/ava/include/ava_dl_api.h | 0 > > osaf/libs/agents/saf/ava/include/ava_hdl.h| 0 > > osaf/libs/agents/saf/ava/include/ava_mds.h| 0 > > osaf/libs/common/Makefile.am | 2 +- > > osaf/libs/common/avsv/Makefile.am | 23 > > +++ > > osaf/libs/common/avsv/avsv_d2nedu.c | 8 > > osaf/libs/common/avsv/avsv_d2nmsg.c | 4 ++-- > > osaf/libs/common/avsv/avsv_eduutil.c | 6 +++--- > > osaf/libs/common/avsv/include/Makefile.am | 22 > > +++--- > > osaf/libs/common/avsv/include/avsv.h | 6 +++--- > > osaf/libs/common/avsv/include/avsv_amfparam.h | 0 > > osaf/libs/common/avsv/include/avsv_d2nedu.h | 0 > > osaf/libs/common/avsv/include/avsv_d2nmsg.h | 2 +- > > osaf/libs/common/avsv/include/avsv_defs.h | 0 > > osaf/libs/common/avsv/include/avsv_eduutil.h | 0 > > osaf/libs/common/avsv/include/avsv_ipc.h | 0 > > osaf/libs/common/avsv/include/avsv_n2avaedu.h | 0 > > osaf/libs/common/avsv/include/avsv_n2avamsg.h | 0 > > osaf/libs/common/avsv/include/avsv_nd2ndmsg.h | 2 +- > > osaf/libs/common/avsv/include/avsv_util.h | 2 +- > > osaf/lib
Re: [devel] [PATCH 1 of 1] pyosaf: correct python bindings for saImmOi [#548]
Ack with comments: - Please remove all remains of A_01_01 - inline As a side note, pylint and pep8 finds many errors and warnings for this file. Guess you should have a look and correct that. Thanks, Hans > -Original Message- > From: Hans Nordebäck > Sent: den 19 augusti 2013 15:45 > To: Hans Feldt; Hans Nordebäck > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] pyosaf: correct python bindings for saImmOi [#548] > > python/pyosaf/saImmOi.py | 225 > +++--- > 1 files changed, 172 insertions(+), 53 deletions(-) > > > Correct python bindings for saImmOi, see also > http://devel.opensaf.org/ticket/2905. > > diff --git a/python/pyosaf/saImmOi.py b/python/pyosaf/saImmOi.py > --- a/python/pyosaf/saImmOi.py > +++ b/python/pyosaf/saImmOi.py > @@ -112,24 +112,13 @@ class SaImmOiCallbacksT_2(Structure): > ('saImmOiRtAttrUpdateCallback', > SaImmOiRtAttrUpdateCallbackT)] > > -#ifdef IMM_A_01_01 > -def saImmOiInitialize(immOiHandle, immOiCallbacks, version): > +class SaImmAdminOperationParamsT_2(Structure): > """ > - Register invoking process with IMM. > + """ > + _fields_ = [('paramName', SaStringT), > + ('paramType', SaImmValueTypeT), > + ('paramBuffer', SaImmAttrValueT)] > > - type arguments: > - SaImmOiHandleT immOiHandle > - SaImmOiCallbacksT immOiCallbacks > - SaVersionT version > - > - returns: > - SaAisErrorT > - > - """ > - return oidll.saImmOiInitialize(BYREF(immOiHandle), > - BYREF(immOiCallbacks), > - BYREF(version)) > -#endif > > def saImmOiInitialize_2(immOiHandle, immOiCallbacks, version): > """ > @@ -144,6 +133,11 @@ def saImmOiInitialize_2(immOiHandle, imm > SaAisErrorT > > """ > + oidll.saImmOiInitialize_2.argtypes = [POINTER(SaImmOiHandleT), > + > POINTER(SaImmOiCallbacksT_2), > + > POINTER(SaVersionT)] > + oidll.saImmOiInitialize_2.restype = SaAisErrorT > + > return oidll.saImmOiInitialize_2(BYREF(immOiHandle), > BYREF(immOiCallbacks), > BYREF(version)) > @@ -160,6 +154,12 @@ def saImmOiSelectionObjectGet(immOiHandl > SaAisErrorT > > """ > + > + oidll.saImmOiSelectionObjectGet.argtypes = [SaImmOiHandleT, > + > POINTER(SaSelectionObjectT)] > + > + oidll.saImmOiSelectionObjectGet.restype = SaAisErrorT > + > return oidll.saImmOiSelectionObjectGet(immOiHandle, > BYREF(selectionObject)) > > @@ -174,6 +174,11 @@ def saImmOiDispatch(immOiHandle, dispatc > SaAisErrorT > > """ > + > + oidll.saImmOiDispatch.argtypes = [SaImmOiHandleT,SaDispatchFlagsT] > + > + oidll.saImmOiDispatch.restype = SaAisErrorT > + > return oidll.saImmOiDispatch(immOiHandle, dispatchFlags) > > def saImmOiFinalize(immOiHandle): > @@ -186,6 +191,11 @@ def saImmOiFinalize(immOiHandle): > SaAisErrorT > > """ > + > + oidll.saImmOiFinalize.argtypes = [SaImmOiHandleT] > + > + oidll.saImmOiFinalize.restype = SaAisErrorT > + > return oidll.saImmOiFinalize(immOiHandle) > > def saImmOiImplementerSet(immOiHandle, implementerName): > @@ -200,6 +210,11 @@ def saImmOiImplementerSet(immOiHandle, i > SaAisErrorT > > """ > + > + oidll.saImmOiImplementerSet.argtypes = [SaImmOiHandleT, > + > SaImmOiImplementerNameT] > + oidll.saImmOiImplementerSet.restype = SaAisErrorT > + > return oidll.saImmOiImplementerSet(immOiHandle, implementerName) > > def saImmOiImplementerClear(immOiHandle): > @@ -213,6 +228,9 @@ def saImmOiImplementerClear(immOiHandle) > SaAisErrorT > > """ > + oidll.saImmOiImplementerClear.argtypes = [SaImmOiHandleT] > + oidll.saImmOiImplementerClear.restype = SaAisErrorT > + > return oidll.saImmOiImplementerClear(immOiHandle) > > def saImmOiClassImplementerSet(immOiHandle, className): > @@ -228,6 +246,11 @@ def saImmOiClassImplementerSet(immOiHand > SaAisErrorT > > """ > + oidll.saImmOiClassImplementerSet.argtypes = [SaImmOiHandleT, > + > SaImmClassNameT] > + > + oidll.saImmOiClassImplementerSet.restype = SaAisErrorT > + > return oidll.saImmOiClassImplementerSet(immOiHandle, className) > > def saImmOiClassImplementerRelease(immOiHandle, className): > @@ -243,6 +266,12 @@ def saImmOiClassImplementerRelease(immO
[devel] New BASE component for common code
Hi! I would like to announce that we have renamed the LEAP component to BASE in the ticket system. I will soon also update the documentation to reflect this change. The idea with this name change is to emphasize that we no longer have a portability layer (since we only support LSB-compliant Linux systems), but rather we have a collection of common code and utility functions shared by all the OpenSAF services. To make it possible to have common code written in C++, we will also create a new shared library alongside libopensaf_core. C++ code cannot be put in libopensaf_core, since the agent libraries are linked with that library. regards, Anders Widell -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 0 of 1] Review Request for IMM: fix memory leak when SaAnyT atrribute is size of 0 [#550]
Hi zoran, reviewed and tested the patch. Ack. Neel. On Thursday 22 August 2013 04:51 PM, Zoran Milinkovic wrote: > Summary: IMM: fix memory leak when SaAnyT atrribute is size of 0 [#550] > Review request for Trac Ticket(s): 550 > Peer Reviewer(s): Neel > Pull request to: Zoran > Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, default(4.4) > Development branch: default(4.4) > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesy > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > - > > changeset ad9c0007a7bbe0ea58fc692d213f78a002ed5b24 > Author: Zoran Milinkovic > Date: Wed, 21 Aug 2013 15:00:12 +0200 > > IMM: fix memory leak when SaAnyT atrribute is size of 0 [#550] > > > Complete diffstat: > -- > osaf/libs/agents/saf/imma/imma_init.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > > Testing Commands: > - > valgrind --leak-check=full immomtest 6 16 > > > Testing, Expected Results: > -- > Run immomtest using valgrind, and check that there is no memory leaks in > immsv_evt_dec_att_val. > > > Conditions of Submission: > - > Ack from Neel. > > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 0 of 5] Review Request for amfsv #533
Ack. Tested : 1) Applied patch1 and then renamed paths manually by using "hg rename". After this applied rest of the patches. Build and brought up controller. 2) make distclean, hg update 4.3 and then recompile. Thanks, Praveen On 26-Aug-13 6:01 PM, Hans Feldt wrote: > It is not entirely wrong, SA-Forum talks about both AMF and SMF as a service > in the "CPROG" document and specifies the DN: > * Availability Management Framework "safApp=safAmfService" > > So we could use "amfsv" but "amf" is shorter and sweeter. > > So agree, "amf" it is. > > Do I have an ack? > > Thanks, > Hans > >> -Original Message- >> From: praveen malviya [mailto:praveen.malv...@oracle.com] >> Sent: den 26 augusti 2013 08:51 >> To: Hans Feldt >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: Re: [PATCH 0 of 5] Review Request for amfsv #533 >> >> I think word "service" is not used for AMF and SMF. So instead of >> renaming "avsv" to "amfsv", can it be renamed to "amf"? >> >> Thanks, >> Praveen >> On 23-Aug-13 6:28 PM, Hans Feldt wrote: >>> Summary: rename avsv >>> Review request for Trac Ticket(s): 533 >>> Peer Reviewer(s): Praveen & Nags >>> Pull request to: <> >>> Affected branch(es): default >>> Development branch: default >>> >>> >>> Impacted area Impact y/n >>> >>>Docsn >>>Build systemy >>>RPM/packaging n >>>Configuration files n >>>Startup scripts n >>>SAF servicesn >>>OpenSAF servicesn >>>Core libraries n >>>Samples n >>>Tests n >>>Other n >>> >>> >>> Comments (indicate scope for each "y" above): >>> - >>> >>> changeset 1abf7f5a01dbf7d2936c2bb55ac711fec55e7f90 >>> Author: Hans Feldt >>> Date: Fri, 23 Aug 2013 14:44:51 +0200 >>> >>> rename avsv to amfsv [#533] >>> >>> In order to align AMF specification, ticket system and source code the >>> avsv >>> name is with this patch changed to amfsv. avsv is a relic from opensaf3 >>> and >>> earlier where avsv contained both clm and amf. >>> >>> changeset fa172b7214fec6d20c3ea85049a71967f149faa7 >>> Author: Hans Feldt >>> Date: Fri, 23 Aug 2013 14:45:32 +0200 >>> >>> amfsv: rename libavsv_common to libamfsv_common [#533] >>> >>> changeset f768c5f9650aa9a6c7919bab111072d5450a79fd >>> Author: Hans Feldt >>> Date: Fri, 23 Aug 2013 14:47:10 +0200 >>> >>> amfsv: rename common lib files [533] >>> >>> changeset 0445048b508dd303f2cbd6c238852ea2999a437d >>> Author: Hans Feldt >>> Date: Fri, 23 Aug 2013 14:47:22 +0200 >>> >>> amfsv: rename avsv xml files [#533] >>> >>> changeset 308d79cca35f9d1b274552ad962088804214debc >>> Author: Hans Feldt >>> Date: Fri, 23 Aug 2013 14:49:56 +0200 >>> >>> amfsv: remove avsv tests [#533] >>> >>> >>> Complete diffstat: >>> -- >>>configure.ac | 34 >>> +- >>>osaf/libs/agents/saf/Makefile.am | 2 +- >>>osaf/libs/agents/saf/ava/Makefile.am | 5 ++--- >>>osaf/libs/agents/saf/ava/ava_api.c| 0 >>>osaf/libs/agents/saf/ava/ava_hdl.c| 0 >>>osaf/libs/agents/saf/ava/ava_init.c | 0 >>>osaf/libs/agents/saf/ava/ava_mds.c| 0 >>>osaf/libs/agents/saf/ava/ava_op.c | 0 >>>osaf/libs/agents/saf/ava/include/Makefile.am | 0 >>>osaf/libs/agents/saf/ava/include/ava.h| 8 >>>osaf/libs/agents/saf/ava/include/ava_cb.h | 0 >>>osaf/libs/agents/saf/ava/include/ava_def.h| 0 >>>osaf/libs/agents/saf/ava/include/ava_dl_api.h | 0 >>>osaf/libs/agents/saf/ava/include/ava_hdl.h| 0 >>>osaf/libs/agents/saf/ava/include/ava_mds.h| 0 >>>osaf/libs/common/Makefile.am | 2 +- >>>osaf/libs/common/avsv/Makefile.am | 23 >>> +++ >>>osaf/libs/common/avsv/avsv_d2nedu.c | 8 >>>osaf/libs/common/avsv/avsv_d2nmsg.c | 4 ++-- >>>osaf/libs/common/avsv/avsv_eduutil.c | 6 +++--- >>>osaf/libs/common/avsv/include/Makefile.am | 22 >>> +++--- >>>osaf/libs/common/avsv/include/avsv.h | 6 +++--- >>>osaf/libs/common/avsv/include/avsv_amfparam.h | 0 >>>osaf/libs/common/avsv/include/avsv_d2nedu.h | 0 >>>osaf/libs/common/avsv/include/avsv_d2nmsg.h | 2 +- >>>osaf/libs/common/avsv/include/avsv_defs.h | 0 >>>osaf/libs/common/avsv/include/avsv_eduutil.h | 0 >>>