Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOL: add missing library to Makefile.am of immcfg [#20]
Hi zoran, Reviewed the patch. Ack. while adding help message to immcfg, add the ctrl+c and ctrl+d behavior with transaction mode. /Neel. On Friday 06 September 2013 08:23 PM, Zoran Milinkovic wrote: > Summary: IMMTOOL: add missing library to Makefile.am of immcfg [#20] > Review request for Trac Ticket(s): 20 > Peer Reviewer(s): Neel, Hans > Pull request to: Zoran > Affected branch(es): default(4.4) > Development branch: > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesy > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > - > > changeset e4cce0be0c180ff2448e11557defb7d142e30886 > Author: Zoran Milinkovic > Date: Fri, 06 Sep 2013 16:49:40 +0200 > > IMMTOOL: add missing library to Makefile.am of immcfg [#20] > > Add libdl library to Makefile.am for immcfg. On Ubuntu 13.04 with gcc > 4.7.3, > it's not possible to link files without missing library. > > > Complete diffstat: > -- > osaf/tools/safimm/immcfg/Makefile.am | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > > Testing Commands: > - > > > Testing, Expected Results: > -- > After applying the patch, it should be possible to compile OpenSAF on Ubuntu > 13.04. > > > Conditions of Submission: > - > Ack from Neel > > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > -- How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=5127&iu=/4140/ostg.clktrk ___ Opensaf-devel mailing list Opensaf-devel@lis
Re: [devel] [PATCH 0 of 1] Review Request for IMM: fix memory leak in imma_search_node_delete function [#549]
Guess you should add a new test case? Sent from my smart phone Zoran Milinkovic skrev: Summary: IMM: fix memory leak in imma_search_node_delete function [#549] Review request for Trac Ticket(s): 549 Peer Reviewer(s): Neel Pull request to: Zoran Affected branch(es): opensaf-4.2.x, opensaf-4.3.x Development branch: opensaf-4.2.x Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 98d90041a07d10622a16883cdd3d934512401b5e Author: Zoran Milinkovic Date: Mon, 09 Sep 2013 14:58:45 +0200 IMM: fix memory leak in imma_search_node_delete function [#549] Complete diffstat: -- osaf/libs/agents/saf/imma/imma_db.c | 33 + osaf/libs/agents/saf/imma/imma_om_api.c | 27 --- 2 files changed, 33 insertions(+), 27 deletions(-) Testing Commands: - valgrind --leak-check=full immomtest Testing, Expected Results: -- Valgrind should not report any memory leak in immomtest for OpenSAF 4.2 and OpenSAF 4.3. Conditions of Submission: - Ack from Neel. Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft tech
[devel] [PATCH 0 of 1] Review Request for IMM: fix memory leak in imma_search_node_delete function [#549]
Summary: IMM: fix memory leak in imma_search_node_delete function [#549] Review request for Trac Ticket(s): 549 Peer Reviewer(s): Neel Pull request to: Zoran Affected branch(es): opensaf-4.2.x, opensaf-4.3.x Development branch: opensaf-4.2.x Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 98d90041a07d10622a16883cdd3d934512401b5e Author: Zoran Milinkovic Date: Mon, 09 Sep 2013 14:58:45 +0200 IMM: fix memory leak in imma_search_node_delete function [#549] Complete diffstat: -- osaf/libs/agents/saf/imma/imma_db.c | 33 + osaf/libs/agents/saf/imma/imma_om_api.c | 27 --- 2 files changed, 33 insertions(+), 27 deletions(-) Testing Commands: - valgrind --leak-check=full immomtest Testing, Expected Results: -- Valgrind should not report any memory leak in immomtest for OpenSAF 4.2 and OpenSAF 4.3. Conditions of Submission: - Ack from Neel. Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 1 of 1] IMM: fix memory leak in imma_search_node_delete function [#549]
osaf/libs/agents/saf/imma/imma_db.c | 33 +
osaf/libs/agents/saf/imma/imma_om_api.c | 27 ---
2 files changed, 33 insertions(+), 27 deletions(-)
diff --git a/osaf/libs/agents/saf/imma/imma_db.c
b/osaf/libs/agents/saf/imma/imma_db.c
--- a/osaf/libs/agents/saf/imma/imma_db.c
+++ b/osaf/libs/agents/saf/imma/imma_db.c
@@ -1183,6 +1183,11 @@ uint32_t imma_search_node_delete(IMMA_CB
if (search_node == NULL)
return NCSCC_RC_FAILURE;
+ if (search_node->mLastAttributes) {
+ imma_freeSearchAttrs(search_node->mLastAttributes);
+ search_node->mLastAttributes = NULL;
+ }
+
/* Remove the Node from the tree */
if (ncs_patricia_tree_del(&cb->search_tree, &search_node->patnode) !=
NCSCC_RC_SUCCESS) {
rc = NCSCC_RC_FAILURE;
@@ -1345,3 +1350,31 @@ SaStringT* imma_getErrorStrings(IMMSV_SA
done:
return errStringArr;
}
+
+void imma_freeSearchAttrs(SaImmAttrValuesT_2 **attr)
+{
+ SaImmAttrValuesT_2 *att = NULL;
+ int ix;
+ for (ix = 0; attr[ix]; ++ix) {
+ int ix2;
+
+ att = attr[ix];
+ free(att->attrName);/*free-3 */
+ att->attrName = NULL;
+
+ for (ix2 = 0; ix2 < att->attrValuesNumber; ++ix2) {
+ SaImmAttrValueT aval = att->attrValues[ix2];
+ imma_freeAttrValue3(aval, att->attrValueType);
/*free-5 */
+ }
+ free(att->attrValues); /*free-4 */
+ att->attrValues = NULL;
+ att->attrValuesNumber = 0;
+ att->attrValueType = 0;
+
+ free(att); /*free-2 */
+ attr[ix] = NULL;
+ }
+
+ free(attr); /*free-1 */
+}
+
diff --git a/osaf/libs/agents/saf/imma/imma_om_api.c
b/osaf/libs/agents/saf/imma/imma_om_api.c
--- a/osaf/libs/agents/saf/imma/imma_om_api.c
+++ b/osaf/libs/agents/saf/imma/imma_om_api.c
@@ -6287,33 +6287,6 @@ SaAisErrorT saImmOmSearchNext_2(SaImmSea
return error;
}
-void imma_freeSearchAttrs(SaImmAttrValuesT_2 **attr)
-{
- SaImmAttrValuesT_2 *att = NULL;
- int ix;
- for (ix = 0; attr[ix]; ++ix) {
- int ix2;
-
- att = attr[ix];
- free(att->attrName);/*free-3 */
- att->attrName = NULL;
-
- for (ix2 = 0; ix2 < att->attrValuesNumber; ++ix2) {
- SaImmAttrValueT aval = att->attrValues[ix2];
- imma_freeAttrValue3(aval, att->attrValueType);
/*free-5 */
- }
- free(att->attrValues); /*free-4 */
- att->attrValues = NULL;
- att->attrValuesNumber = 0;
- att->attrValueType = 0;
-
- free(att); /*free-2 */
- attr[ix] = NULL;
- }
-
- free(attr); /*free-1 */
-}
-
SaAisErrorT saImmOmSearchFinalize(SaImmSearchHandleT searchHandle)
{
SaAisErrorT error = SA_AIS_OK;
--
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 1 of 1] Amfd: Allow admin operation on middleware only when originated from SMF [#477]
osaf/services/saf/amf/amfd/avd_su.cc | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/avd_su.cc
b/osaf/services/saf/amf/amfd/avd_su.cc
--- a/osaf/services/saf/amf/amfd/avd_su.cc
+++ b/osaf/services/saf/amf/amfd/avd_su.cc
@@ -953,6 +953,33 @@ static void su_admin_op_cb(SaImmOiHandle
goto done;
}
+ /* Allow admin operations on middleware sus, if
saAmfSUMaintenanceCampaign is set on
+ any SU hosted on the same node.*/
+ if (su->sg_of_su->sg_ncs_spec == true) {
+ for (su_ptr = node->list_of_su; su_ptr != NULL; su_ptr =
su_ptr->avnd_list_su_next) {
+ if (su_ptr->saAmfSUMaintenanceCampaign.length == 0) {
+ LOG_ER("saAmfSUMaintenanceCampaign not set for
%s, rejecting operation",
+ su_ptr->name.value);
+ rc = SA_AIS_ERR_BAD_OPERATION;
+ goto done;
+ } else {
+ sumaintenance_set = true;
+ break;
+ }
+ }
+ for (su_ptr = node->list_of_ncs_su; (su_ptr != NULL) &&
(!sumaintenance_set);
+ su_ptr = su_ptr->avnd_list_su_next) {
+ if (su_ptr->saAmfSUMaintenanceCampaign.length == 0) {
+ LOG_ER("saAmfSUMaintenanceCampaign not set for
%s, rejecting operation",
+ su_ptr->name.value);
+ rc = SA_AIS_ERR_BAD_OPERATION;
+ goto done;
+ } else {
+ break;
+ }
+ }
+ }
+
/* Validation has passed and admin operation should be done. Proceed
with it... */
switch (op_id) {
case SA_AMF_ADMIN_UNLOCK:
--
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 0 of 1] Review Request for Amfd: Allow admin operation on middleware only when originated from SMF [#477]
Summary: Amfd: Allow admin operation on middleware only when originated from SMF [#477] Review request for Trac Ticket(s): #477 Peer Reviewer(s): Mathi, Hans F, Hans N, Praveen Pull request to: <> Affected branch(es): All Development branch: Default Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset a8b1bdde0bf7533cda8149d49dd9c8d79f2680ac Author: Nagendra Kumar Date: Mon, 09 Sep 2013 17:21:05 +0530 Amfd: Allow admin operation on middleware only when originated from SMF [#477] Complete diffstat: -- osaf/services/saf/amf/amfd/avd_su.cc | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) Testing Commands: - 1. amf-adm lock safSu=SC-2\,safSg=NoRed\,safApp=OpenSAF will fail with : Sep 9 17:15:33 PM_SC-180 osafamfd[6634]: ER saAmfSUMaintenanceCampaign not set for safSu=SC-2,safSg=2N,safApp=OpenSAF, rejecting operation 2. Set immcfg -a saAmfSUMaintenanceCampaign+=1 safSu=SC-2\,safSg=NoRed\,safApp=OpenSAF amf-adm lock safSu=SC-2\,safSg=NoRed\,safApp=OpenSAF suceeds. Testing, Expected Results: -- Please check above. Conditions of Submission: - Ack from peers Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOLS: add transactions to immcfg [#20]
I will add the description and examples with the next patch. Will be added to DESCRIPTION: Running immcfg without arguments, immcfg starts in explicit commit mode where is possible to perform more IMM operations within one CCB. In explicit commit mode, immcfg accepts immcfg commands from stdin, pipe or a file. Will be added to EXAMPLE: cat test.cfg | immcfg Running immcfg in explicit commit mode where immfg accepts immcfg commands from a pipe immcfg < test.cfg Running immcfg in explicit commit mode where immcfg accepts immcfg commands from test.cfg file immcfg Running immcfg in explicit commit mode where immcfg accepts immcfg commands from command line BR, Zoran -Original Message- From: Hans Feldt Sent: den 9 september 2013 09:01 To: Zoran Milinkovic Cc: reddy.neelaka...@oracle.com; opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOLS: add transactions to immcfg [#20] Hi, I think some help text is missing (even better a man page but that is for later). I don't understand how to use this feature. Could you explain here first and add into the help text of immcfg? Thanks, Hans On 07/18/2013 03:27 PM, Zoran Milinkovic wrote: > Summary: IMMTOOLS: add transactions to immcfg [#20] Review request for > Trac Ticket(s): 20 Peer Reviewer(s): Neel, Anders Pull request to: > Zoran Affected branch(es): default(4.4) Development branch: > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesy > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > - > > changeset 0ed7f10cc24733dde0f99720aacec7e9ff6b4bdd > Author: Zoran Milinkovic > Date: Thu, 18 Jul 2013 15:13:34 +0200 > > IMMTOOLS: add transactions to immcfg [#20] > > immcfg without parameters runs in transaction mode. immcfg operations in > transaction mode can be accepted from a pipe, a file or stdin (command > line). Ctrl+D commit a transaction and exit. Ctrl+C abort a transaction > and > exit. > > > Complete diffstat: > -- > osaf/tools/safimm/immcfg/imm_cfg.c | 794 > > osaf/tools/safimm/immcfg/imm_import.cc | 908 > + > 2 files changed, 1238 insertions(+), 464 deletions(-) > > > Testing Commands: > - > immcfg > cat testfile.cfg | immcfg > immcfg < testfile.cfg > > > Testing, Expected Results: > -- > Run immcfg in a command line mode, ex: "immcfg" > Use a pipe as the input, ex: "cat testfile.cfg | immcfg" > Use a file as the input, ex: "immcfg < testfile.cfg" > > > Conditions of Submission: > - > Ack from Neel and Anders > > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any > checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there
[devel] [PATCH 0 of 1] Review Request for amfnd #94
Summary: amfnd: Convert amfnd to C++ and remove avnd prefix from files [#94] Review request for Trac Ticket(s): #94 Peer Reviewer(s): hansf, nagendra, praveen Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 78a5f68a153c0834e3548bb083c852ddce2ea98a Author: Hans Nordeback Date: Mon, 09 Sep 2013 09:34:12 +0200 amfnd: Convert amfnd to C++ and remove avnd prefix from files [#94] Convert amfnd to C++ and remove avnd prefix from filenames [#94] Added Files: osaf/services/saf/amf/amfnd/main.cc Removed Files: -- osaf/services/saf/amf/amfnd/amfnd_main.c osaf/services/saf/amf/amfnd/avnd.c osaf/services/saf/amf/amfnd/avnd_proc.c Complete diffstat: -- osaf/libs/common/amf/include/amf_eduutil.h |7 + osaf/libs/common/amf/include/amf_n2avaedu.h|8 + osaf/libs/common/amf/include/amf_n2avamsg.h|8 + osaf/libs/common/amf/include/amf_nd2ndmsg.h|7 + osaf/services/saf/amf/amfnd/Makefile.am| 70 +++--- osaf/services/saf/amf/amfnd/amfnd_main.c | 64 - osaf/services/saf/amf/amfnd/avnd.c | 629 -- osaf/services/saf/amf/amfnd/avnd_avnd.c|2 +- osaf/services/saf/amf/amfnd/avnd_proc.c| 315 --- osaf/services/saf/amf/amfnd/avnd_cam.c |4 +- osaf/services/saf/amf/amfnd/avnd_cbq.c | 16 +- osaf/services/saf/amf/amfnd/avnd_chc.c |8 +- osaf/services/saf/amf/amfnd/avnd_ckpt_dec.c| 158 ++-- osaf/services/saf/amf/amfnd/avnd_ckpt_edu.c| 18 +- osaf/services/saf/amf/amfnd/avnd_ckpt_enc.c| 158 ++-- osaf/services/saf/amf/amfnd/avnd_ckpt_updt.c |0 osaf/services/saf/amf/amfnd/avnd_clc.c | 28 +- osaf/services/saf/amf/amfnd/avnd_clm.c |7 +- osaf/services/saf/amf/amfnd/avnd_comp.c| 28 +- osaf/services/saf/amf/amfnd/avnd_compdb.c | 105 osaf/services/saf/amf/amfnd/avnd_cpm.c |2 +- osaf/services/saf/amf/amfnd/avnd_di.c | 20 +- osaf/services/saf/amf/amfnd/avnd_err.c | 36 +- osaf/services/saf/amf/amfnd/avnd_evt.c |2 +- osaf/services/saf/amf/amfnd/avnd_hcdb.c| 18 +- osaf/services/saf/amf/amfnd/include/avnd_mds.h |2 +- osaf/services/saf/amf/amfnd/include/avnd_mon.h |3 - osaf/services/saf/amf/amfnd/main.cc| 925 osaf/services/saf/amf/amfnd/avnd_mbcsv.c | 22 +- osaf/services/saf/amf/amfnd/avnd_mds.c | 28 +- osaf/services/saf/amf/amfnd/avnd_mon.c |2 + osaf/services/saf/amf/amfnd/avnd_pg.c |8 +- osaf/services/saf/amf/amfnd/avnd_pgdb.c|8 +- osaf/services/saf/amf/amfnd/avnd_proxy.c | 10 +- osaf/services/saf/amf/amfnd/avnd_proxydb.c |4 +- osaf/services/saf/amf/amfnd/avnd_sidb.c| 12 +- osaf/services/saf/amf/amfnd/avnd_su.c |2 +- osaf/services/saf/amf/amfnd/avnd_sudb.c|8 +- osaf/services/saf/amf/amfnd/avnd_susm.c| 30 +- osaf/services/saf/amf/amfnd/avnd_term.c|2 +- osaf/services/saf/amf/amfnd/avnd_tmr.c |8 +- osaf/services/saf/amf/amfnd/avnd_util.c|6 +- osaf/services/saf/amf/amfnd/avnd_verify.c |0 43 files changed, 1374 insertions(+), 1424 deletions(-) Testing Commands: - <> Testing, Expected Results: -- <> Conditions of Submission: - <> Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ti
Re: [devel] [PATCH 0 of 1] Review Request for IMMTOOLS: add transactions to immcfg [#20]
Hi, I think some help text is missing (even better a man page but that is for later). I don't understand how to use this feature. Could you explain here first and add into the help text of immcfg? Thanks, Hans On 07/18/2013 03:27 PM, Zoran Milinkovic wrote: > Summary: IMMTOOLS: add transactions to immcfg [#20] > Review request for Trac Ticket(s): 20 > Peer Reviewer(s): Neel, Anders > Pull request to: Zoran > Affected branch(es): default(4.4) > Development branch: > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesy > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > - > > changeset 0ed7f10cc24733dde0f99720aacec7e9ff6b4bdd > Author: Zoran Milinkovic > Date: Thu, 18 Jul 2013 15:13:34 +0200 > > IMMTOOLS: add transactions to immcfg [#20] > > immcfg without parameters runs in transaction mode. immcfg operations in > transaction mode can be accepted from a pipe, a file or stdin (command > line). Ctrl+D commit a transaction and exit. Ctrl+C abort a transaction > and > exit. > > > Complete diffstat: > -- > osaf/tools/safimm/immcfg/imm_cfg.c | 794 > > osaf/tools/safimm/immcfg/imm_import.cc | 908 > + > 2 files changed, 1238 insertions(+), 464 deletions(-) > > > Testing Commands: > - > immcfg > cat testfile.cfg | immcfg > immcfg < testfile.cfg > > > Testing, Expected Results: > -- > Run immcfg in a command line mode, ex: "immcfg" > Use a pipe as the input, ex: "cat testfile.cfg | immcfg" > Use a file as the input, ex: "immcfg < testfile.cfg" > > > Conditions of Submission: > - > Ack from Neel and Anders > > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability
