Summary: amfa: return NOT_SUPPORTED for PM_ABNORMAL_END [#181]
Review request for Trac Ticket(s): #181
Peer Reviewer(s): Praveen, Hans N
Pull request to:
Affected branch(es): Default
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset b7d495faec01256b24916a1b7df5ff6666c0b28a
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Wed, 26 Aug 2015 10:40:00 +0530
amfa: return NOT_SUPPORTED for PM_ABNORMAL_END [#181] Amf is returning
SA_AIS_ERR_INVALID_PARAM for SA_AMF_PM_ABNORMAL_END and its combination
with
other SaAmfPmErrorsT flags. This is incorrect behaviour because
SA_AMF_PM_ABNORMAL_END and its combination with other SaAmfPmErrorsT
flags
are valid input to APIs saAmfPmStart and saAmfPmStop. Since these
combinations feature is not supported in Amf as of now, so, Amf should
return SA_AIS_ERR_NOT_SUPPORTED for such combinations. The fix provides
the
same.
Complete diffstat:
------------------
osaf/libs/agents/saf/amfa/ava_api.c | 28 ++++++++++++++++++++++------
1 files changed, 22 insertions(+), 6 deletions(-)
Testing Commands:
-----------------
Start amf demo appl with saAmfPmStart and saAmfPmStop.
1. Pass pmErr as 1, 2, 3 in saAmfPmStart(Combination of
SA_AMF_PM_NON_ZERO_EXIT, SA_AMF_PM_ZERO_EXIT).
2. Pass pmErr as 4, 5, 6, 7 in saAmfPmStart(Combination of
SA_AMF_PM_NON_ZERO_EXIT,
SA_AMF_PM_ZERO_EXIT and SA_AMF_PM_ABNORMAL_END).
3. Pass pmErr as 8, 10, 16 in saAmfPmStart(Some random values).
4. Perform #1, #2, #3 test cases for saAmfPmStart_3(It needs some modification
in demo code for using B4.1 API).
5. Perform #1, #2, #3 test cases for saAmfPmStop.
Testing, Expected Results:
--------------------------
1. Return value is 1(SA_AIS_OK).
2. Return value is 19(SA_AIS_ERR_NOT_SUPPORTED).
3. Return value is 7(SA_AIS_ERR_INVALID_PARAM).
3. Same result as #1, #2, #3.
4. Same result as #1, #2, #3.
Conditions of Submission:
-------------------------
Ack from reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
