Summary: amfd: log about invalid configuration of
saAmfSGNumPrefActiveSUs/StandbySUs [#296]
Review request for Trac Ticket(s): #296
Peer Reviewer(s): Praveen, Hans N
Pull request to:
Affected branch(es): All
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset b96305e3c94daa8eeb0af734daa961eed6406c1f
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Thu, 02 Jul 2015 13:44:30 +0530
amfd: log about invalid configuration of
saAmfSGNumPrefActiveSUs/StandbySUs
[#296] For NpM, saAmfSGNumPrefActiveSUs and saAmfSGNumPrefStandbySUs are
mandatory attributes to configure. Specs states that there should not
be any
default values for these attributes. But in existing code, we are
marking
them to 1. If we keep check and reject the configuration without
saAmfSGNumPrefActiveSUs and saAmfSGNumPrefStandbySUs, then there may be
backward compatibility issue. So, in the fix, we just added logs stating
that these configurations are missing. If they are missing, we are
setting
the values to 1. But for NpM, setting them to 1 means configuration is
almost equivalent to 2N. So, the fix also throws notice that, setting
them
to 1 is of not much use.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/sg.cc | 26 +++++++++++++++++++++-----
1 files changed, 21 insertions(+), 5 deletions(-)
Testing Commands:
-----------------
1. Start SC-1 and upload Amf demo with saAmfSgtRedundancyModel as 2(NpM) and
without configuring saAmfSGNumPrefActiveSUs and saAmfSGNumPrefStandbySUs.
2. Start SC-1 and upload Amf demo with saAmfSgtRedundancyModel as 2(NpM) and
with saAmfSGNumPrefActiveSUs as 10 and without configuring
saAmfSGNumPrefStandbySUs.
3. Start SC-1 and upload Amf demo with saAmfSgtRedundancyModel as 2(NpM) and
with saAmfSGNumPrefStandbySUs as 10 and without configuring
saAmfSGNumPrefActiveSUs.
4. Start SC-1 and upload Amf demo with saAmfSgtRedundancyModel as 2(NpM) and
with configuring saAmfSGNumPrefActiveSUs(10) and
saAmfSGNumPrefStandbySUs(10).
5. Start SC-1 and upload Amf demo with saAmfSgtRedundancyModel as 1(2N) and
with saAmfSGNumPrefStandbySUs as 10 and without configuring
saAmfSGNumPrefActiveSUs.
Testing, Expected Results:
--------------------------
In all the cases, CCB will be committed.
1. The following log will come:
osafamfd[16914]: NO 'saAmfSGNumPrefActiveSUs' is set to 1, not useful for NpM
osafamfd[16914]: NO 'saAmfSGNumPrefStandbySUs' is set to 1, not useful for NpM
2. The following log will come:
amfd[16914]: NO 'saAmfSGNumPrefStandbySUs' is set to 1, not useful for NpM
3. The following log will come:
osafamfd[16914]: NO 'saAmfSGNumPrefActiveSUs' is set to 1, not useful for NpM
4. No log will come.
5. No log will come.
Conditions of Submission:
-------------------------
Ack from reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
