Summary: base: Use default scheduling policy when configured policy is invalid
[#690]
Review request for Trac Ticket(s): 690
Peer Reviewer(s): Ramesh
Pull request to:
Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, opensaf-4.4.x, default(4.5)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset b030f158fa19817ac62b65cebf371a8b7167b2b6
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 17 Jan 2014 15:43:56 +0100
base: Use default scheduling policy when configured policy is invalid
[#690]
OpenSAF would fail to start when an invalid thread scheduling policy has
been configured, e.g. using the following configuration options for one
of
the OpenSAF services:
export OSAF_MDS_SCHED_PRIORITY=0 export OSAF_MDS_SCHED_POLICY=3
The OpenSAF services fail with the following messages:
Dec 24 14:40:02 SLES_NEW2 opensafd[15010]: ER Timed-out for response
from
RDE Dec 24 14:40:02 SLES_NEW2 opensafd[15010]: ER Dec 24 14:40:02
SLES_NEW2
opensafd[15010]: ER Going for recovery Dec 24 14:40:02 SLES_NEW2
opensafd[15010]: ER Trying To RESPAWN
/usr/lib64/opensaf/clc-cli/osaf-rded
attempt #1 Dec 24 14:40:02 SLES_NEW2 opensafd[15010]: ER Sending
SIGKILL to
RDE, pid=15031
The reason is that scheduling policy 3 (SCHED_BATCH) is not a valid
parameter to the pthread_attr_setschedpolicy() function, and OpenSAF
passes
the configured policy to this function without whecking that it is
valid.
A check for this case has been added, so that we fall back to the
default
scheduling policy when an invalid policy has been configured.
Complete diffstat:
------------------
osaf/libs/core/leap/os_defs.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
Testing Commands:
-----------------
Add the following lines to nid.conf and then start OpenSAF:
export OSAF_MDS_SCHED_PRIORITY=0
export OSAF_MDS_SCHED_POLICY=3
Testing, Expected Results:
--------------------------
OpenSAF should start up successfully.
Conditions of Submission:
-------------------------
Ack from Ramesh
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
