Re: [devel] [PATCH 0 of 1] Review Request for uml: Update UML environment to Linux 3.13.1, busybox 1.21.1 [#762]
Tested Ok, Ack /Lennart > -Original Message- > From: Anders Widell > Sent: den 31 januari 2014 14:10 > To: Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 0 of 1] Review Request for uml: Update UML environment > to Linux 3.13.1, busybox 1.21.1 [#762] > > Summary: uml: Update UML environment to Linux 3.13.1, busybox 1.21.1 > [#762] > Review request for Trac Ticket(s): 762 > Peer Reviewer(s): Lennart > Pull request to: > Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, opensaf-4.4.x, > default(4.5) > Development branch: default > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesn > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other y > > > Comments (indicate scope for each "y" above): > - > changeset 8631919bdd815be3e70e9fc389d84c5911cc2b54 > Author: Anders Widell > Date: Fri, 31 Jan 2014 14:06:00 +0100 > > uml: Update UML environment to Linux 3.13.1, busybox 1.21.1 [#762] > > Update the kernel version used in UML, so that it starts up properly > on > Fedora 20. The new kernel version also fixes the problem that UML > did not > work with a memory size larger than the default 128 MiB. > > > Complete diffstat: > -- > tools/cluster_sim_uml/uml/build_uml |15 +- > tools/cluster_sim_uml/uml/config/busybox-1.19.4 | 1001 > --- > > tools/cluster_sim_uml/uml/config/busybox-1.21.1 | 1022 > ++ > +++ > tools/cluster_sim_uml/uml/config/linux-3.13.1-i686 | 1044 > ++ > ++ > tools/cluster_sim_uml/uml/config/linux-3.13.1-x86_64 | 1013 > ++ > ++ > tools/cluster_sim_uml/uml/config/linux-3.4.2-i686| 947 > - > > tools/cluster_sim_uml/uml/config/linux-3.4.2-x86_64 | 918 > --- > --- > 7 files changed, 3090 insertions(+), 2870 deletions(-) > > > Testing Commands: > - > Build the UML environment and start it. > > > Testing, Expected Results: > -- > UML should build and start successfully. > > > Conditions of Submission: > - > Ack from reviewer. > > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 y y > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You hav
[devel] [PATCH 0 of 1] Review Request for uml: Update UML environment to Linux 3.13.1, busybox 1.21.1 [#762]
Summary: uml: Update UML environment to Linux 3.13.1, busybox 1.21.1 [#762] Review request for Trac Ticket(s): 762 Peer Reviewer(s): Lennart Pull request to: Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, opensaf-4.4.x, default(4.5) Development branch: default Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesn OpenSAF servicesn Core libraries n Samples n Tests n Other y Comments (indicate scope for each "y" above): - changeset 8631919bdd815be3e70e9fc389d84c5911cc2b54 Author: Anders Widell Date: Fri, 31 Jan 2014 14:06:00 +0100 uml: Update UML environment to Linux 3.13.1, busybox 1.21.1 [#762] Update the kernel version used in UML, so that it starts up properly on Fedora 20. The new kernel version also fixes the problem that UML did not work with a memory size larger than the default 128 MiB. Complete diffstat: -- tools/cluster_sim_uml/uml/build_uml |15 +- tools/cluster_sim_uml/uml/config/busybox-1.19.4 | 1001 --- tools/cluster_sim_uml/uml/config/busybox-1.21.1 | 1022 + tools/cluster_sim_uml/uml/config/linux-3.13.1-i686 | 1044 tools/cluster_sim_uml/uml/config/linux-3.13.1-x86_64 | 1013 tools/cluster_sim_uml/uml/config/linux-3.4.2-i686| 947 - tools/cluster_sim_uml/uml/config/linux-3.4.2-x86_64 | 918 -- 7 files changed, 3090 insertions(+), 2870 deletions(-) Testing Commands: - Build the UML environment and start it. Testing, Expected Results: -- UML should build and start successfully. Conditions of Submission: - Ack from reviewer. Arch Built StartedLinux distro --- mipsn n mips64 n n x86 y y x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review.
