Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

2016-08-23 Thread A V Mahesh
Hi Hoang,

Please send the all update patches 1 to 8  & README in single tar,
so that I can commit.

-AVM


On 8/23/2016 12:48 PM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> I updated README file and sent as attachment to this email.
> I also sent update patches following your comments.
>
> Please help me push these items if there is no further problem.
>
> Thank you and best regards,
> Hoang
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Monday, August 22, 2016 1:53 PM
> To: Hoang Vo 
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than
> 255 bytes [#1574] v5
>
> Hi Hoang,
>
> ACK, Please Update README
>
> Note : tested default functionality , LONG DN functionality not tested in
> full fledged.
>
> -AVM
>
>
> On 8/18/2016 12:48 PM, Hoang Vo wrote:
>> Summary: CKPT: Support DNs longer than 255 bytes {#1574} Review
>> request for Trac Ticket(s): 1574 Peer Reviewer(s):
>> mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to:
>> mahesh.va...@oracle.com Affected branch(es): default Development
>> branch: default
>>
>> 
>> Impacted area   Impact y/n
>> 
>>Docsn
>>Build systemn
>>RPM/packaging   n
>>Configuration files n
>>Startup scripts n
>>SAF servicesy
>>OpenSAF servicesn
>>Core libraries  n
>>Samples n
>>Tests   n
>>Other   n
>>
>>
>> Comments (indicate scope for each "y" above):
>> -
>>
>> changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpd: Add support for extended SaNameT [#1574] v3
>>
>> changeset cecabec5b6be73e731e540fd439e1d0e3534809f
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpnd: Add support for extended SaNameT [#1574] v3
>>
>> changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpa: Add support for extended SaNameT [#1574] v1
>>
>> changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpsv: Add new message to support extended SaNameT [#1574] v3
>>
>> changeset 29df19302186b3275ad06db00dc62f275dea25e1
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2
>>
>> changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpsv: Apply new messages supporting extended SaNameT to CPD, CPND,
> and CPA
>>  [#1574] v4
>>
>> changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  ckpt: Add new test cases to verify long DN feature on CPSV [#1574]
> v1
>> changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpnd: add support for shm recovery for in-service update without
> restarting
>>  node [#1574] v1
>>
>>
>> Complete diffstat:
>> --
>>osaf/libs/agents/saf/cpa/Makefile.am  |1 +
>>osaf/libs/agents/saf/cpa/cpa_api.c|   48 --
>>osaf/libs/agents/saf/cpa/cpa_db.c |2 +
>>osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
>>osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
>>osaf/libs/common/cpsv/cpsv_evt.c  |  440
> ++---
>>osaf/libs/common/cpsv/include/cpa.h   |1 +
>>osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
>>osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
>>osaf/libs/common/cpsv/include/cpd.h   |1 +
>>osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
>>osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
>>osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
>>osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
>>osaf/libs/common/cpsv/include/cpnd.h  |1 +
>>osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
>>osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
>>osaf/libs/common/cpsv/include/cpsv_evt.h  |   10 +
>>osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
>>osaf/services/saf/cpsv/cpd/Makefile.am|1 +
>>osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
>>

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

2016-08-23 Thread Vo Minh Hoang
Dear Mahesh,

I updated README file and sent as attachment to this email.
I also sent update patches following your comments.

Please help me push these items if there is no further problem.

Thank you and best regards,
Hoang

-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com] 
Sent: Monday, August 22, 2016 1:53 PM
To: Hoang Vo 
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than
255 bytes [#1574] v5

Hi Hoang,

ACK, Please Update README

Note : tested default functionality , LONG DN functionality not tested in
full fledged.

-AVM


On 8/18/2016 12:48 PM, Hoang Vo wrote:
> Summary: CKPT: Support DNs longer than 255 bytes {#1574} Review 
> request for Trac Ticket(s): 1574 Peer Reviewer(s): 
> mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: 
> mahesh.va...@oracle.com Affected branch(es): default Development 
> branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesy
>   OpenSAF servicesn
>   Core libraries  n
>   Samples n
>   Tests   n
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>
> changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpd: Add support for extended SaNameT [#1574] v3
>
> changeset cecabec5b6be73e731e540fd439e1d0e3534809f
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpnd: Add support for extended SaNameT [#1574] v3
>
> changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpa: Add support for extended SaNameT [#1574] v1
>
> changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpsv: Add new message to support extended SaNameT [#1574] v3
>
> changeset 29df19302186b3275ad06db00dc62f275dea25e1
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2
>
> changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpsv: Apply new messages supporting extended SaNameT to CPD, CPND,
and CPA
>   [#1574] v4
>
> changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   ckpt: Add new test cases to verify long DN feature on CPSV [#1574]
v1
>
> changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpnd: add support for shm recovery for in-service update without
restarting
>   node [#1574] v1
>
>
> Complete diffstat:
> --
>   osaf/libs/agents/saf/cpa/Makefile.am  |1 +
>   osaf/libs/agents/saf/cpa/cpa_api.c|   48 --
>   osaf/libs/agents/saf/cpa/cpa_db.c |2 +
>   osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
>   osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
>   osaf/libs/common/cpsv/cpsv_evt.c  |  440
++---
>   osaf/libs/common/cpsv/include/cpa.h   |1 +
>   osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
>   osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpd.h   |1 +
>   osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
>   osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
>   osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
>   osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpnd.h  |1 +
>   osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
>   osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
>   osaf/libs/common/cpsv/include/cpsv_evt.h  |   10 +
>   osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
>   osaf/services/saf/cpsv/cpd/Makefile.am|1 +
>   osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
>   osaf/services/saf/cpsv/cpd/cpd_db.c   |   95 +++---
>   osaf/services/saf/cpsv/cpd/cpd_evt.c  |  103 ++-
>   osaf/services/saf/cpsv/cpd/cpd_imm.c  |  268
++
>   osaf/services/saf/cpsv/cpd/cpd_main.c |7 +
>   osaf/services/saf/cpsv/cpd/cpd_mbcsv.c|   31 -
>   osaf/services/saf/cpsv/cpd/cpd_mds.c  | 

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

2016-08-22 Thread A V Mahesh
Hi Hoang,

ACK, Please Update README

Note : tested default functionality , LONG DN functionality not tested
in full fledged.

-AVM


On 8/18/2016 12:48 PM, Hoang Vo wrote:
> Summary: CKPT: Support DNs longer than 255 bytes {#1574}
> Review request for Trac Ticket(s): 1574
> Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
> Pull request to: mahesh.va...@oracle.com
> Affected branch(es): default
> Development branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesy
>   OpenSAF servicesn
>   Core libraries  n
>   Samples n
>   Tests   n
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>
> changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpd: Add support for extended SaNameT [#1574] v3
>
> changeset cecabec5b6be73e731e540fd439e1d0e3534809f
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpnd: Add support for extended SaNameT [#1574] v3
>
> changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpa: Add support for extended SaNameT [#1574] v1
>
> changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpsv: Add new message to support extended SaNameT [#1574] v3
>
> changeset 29df19302186b3275ad06db00dc62f275dea25e1
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2
>
> changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and 
> CPA
>   [#1574] v4
>
> changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   ckpt: Add new test cases to verify long DN feature on CPSV [#1574] v1
>
> changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpnd: add support for shm recovery for in-service update without 
> restarting
>   node [#1574] v1
>
>
> Complete diffstat:
> --
>   osaf/libs/agents/saf/cpa/Makefile.am  |1 +
>   osaf/libs/agents/saf/cpa/cpa_api.c|   48 --
>   osaf/libs/agents/saf/cpa/cpa_db.c |2 +
>   osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
>   osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
>   osaf/libs/common/cpsv/cpsv_evt.c  |  440 
> ++---
>   osaf/libs/common/cpsv/include/cpa.h   |1 +
>   osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
>   osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpd.h   |1 +
>   osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
>   osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
>   osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
>   osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpnd.h  |1 +
>   osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
>   osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
>   osaf/libs/common/cpsv/include/cpsv_evt.h  |   10 +
>   osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
>   osaf/services/saf/cpsv/cpd/Makefile.am|1 +
>   osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
>   osaf/services/saf/cpsv/cpd/cpd_db.c   |   95 +++---
>   osaf/services/saf/cpsv/cpd/cpd_evt.c  |  103 ++-
>   osaf/services/saf/cpsv/cpd/cpd_imm.c  |  268 
> ++
>   osaf/services/saf/cpsv/cpd/cpd_main.c |7 +
>   osaf/services/saf/cpsv/cpd/cpd_mbcsv.c|   31 -
>   osaf/services/saf/cpsv/cpd/cpd_mds.c  |   84 -
>   osaf/services/saf/cpsv/cpd/cpd_proc.c |  180 
> ++--
>   osaf/services/saf/cpsv/cpd/cpd_red.c  |6 +-
>   osaf/services/saf/cpsv/cpd/cpd_sbevt.c|   57 +++-
>   osaf/services/saf/cpsv/cpnd/Makefile.am   |1 +
>   osaf/services/saf/cpsv/cpnd/cpnd_db.c |6 +-
>   osaf/services/saf/cpsv/cpnd/cpnd_evt.c|   73 ---
>   osaf/services/saf/cpsv/cpnd/cpnd_main.c   |7 +
>   osaf/services/saf/cpsv/cpnd/cpnd_mds.c|   86 

[devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

2016-08-18 Thread Hoang Vo
Summary: CKPT: Support DNs longer than 255 bytes {#1574}
Review request for Trac Ticket(s): 1574
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default
Development branch: default


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-

changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpd: Add support for extended SaNameT [#1574] v3

changeset cecabec5b6be73e731e540fd439e1d0e3534809f
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpnd: Add support for extended SaNameT [#1574] v3

changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpa: Add support for extended SaNameT [#1574] v1

changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpsv: Add new message to support extended SaNameT [#1574] v3

changeset 29df19302186b3275ad06db00dc62f275dea25e1
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2

changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and 
CPA
[#1574] v4

changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

ckpt: Add new test cases to verify long DN feature on CPSV [#1574] v1

changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpnd: add support for shm recovery for in-service update without 
restarting
node [#1574] v1


Complete diffstat:
--
 osaf/libs/agents/saf/cpa/Makefile.am  |1 +
 osaf/libs/agents/saf/cpa/cpa_api.c|   48 --
 osaf/libs/agents/saf/cpa/cpa_db.c |2 +
 osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
 osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
 osaf/libs/common/cpsv/cpsv_evt.c  |  440 
++---
 osaf/libs/common/cpsv/include/cpa.h   |1 +
 osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
 osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
 osaf/libs/common/cpsv/include/cpd.h   |1 +
 osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
 osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
 osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
 osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
 osaf/libs/common/cpsv/include/cpnd.h  |1 +
 osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
 osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
 osaf/libs/common/cpsv/include/cpsv_evt.h  |   10 +
 osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
 osaf/services/saf/cpsv/cpd/Makefile.am|1 +
 osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
 osaf/services/saf/cpsv/cpd/cpd_db.c   |   95 +++---
 osaf/services/saf/cpsv/cpd/cpd_evt.c  |  103 ++-
 osaf/services/saf/cpsv/cpd/cpd_imm.c  |  268 
++
 osaf/services/saf/cpsv/cpd/cpd_main.c |7 +
 osaf/services/saf/cpsv/cpd/cpd_mbcsv.c|   31 -
 osaf/services/saf/cpsv/cpd/cpd_mds.c  |   84 -
 osaf/services/saf/cpsv/cpd/cpd_proc.c |  180 ++--
 osaf/services/saf/cpsv/cpd/cpd_red.c  |6 +-
 osaf/services/saf/cpsv/cpd/cpd_sbevt.c|   57 +++-
 osaf/services/saf/cpsv/cpnd/Makefile.am   |1 +
 osaf/services/saf/cpsv/cpnd/cpnd_db.c |6 +-
 osaf/services/saf/cpsv/cpnd/cpnd_evt.c|   73 ---
 osaf/services/saf/cpsv/cpnd/cpnd_main.c   |7 +
 osaf/services/saf/cpsv/cpnd/cpnd_mds.c|   86 -
 osaf/services/saf/cpsv/cpnd/cpnd_proc.c   |   84 +---
 osaf/services/saf/cpsv/cpnd/cpnd_res.c|  823 
++
 tests/cpsv/Makefile.am|1 +
 tests/cpsv/test_cpa.c |  180 -
 tests/cpsv/test_cpa_util.c|   16 ++-
 

[devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

2016-08-02 Thread Hoang Vo
Summary: CKPT: Support DNs longer than 255 bytes [#1574]
Review request for Trac Ticket(s): 1574
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default
Development branch: default


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-

changeset 4d12e373df37e584ef89ab2de425da2aca605234
Author: Hoang Vo 
Date:   Tue, 02 Aug 2016 15:16:03 +0700

cpd: Add support for extended SaNameT [#1574]

changeset fff91d9209edc72d57fdaf2b7eae4f139f6e882b
Author: Hoang Vo 
Date:   Tue, 02 Aug 2016 15:16:03 +0700

cpnd: Add support for extended SaNameT v1 [#1574]

changeset 1514ff6d5f37070c5faa776409f3455d257e188d
Author: Hoang Vo 
Date:   Tue, 02 Aug 2016 15:16:03 +0700

cpa: Add support for extended SaNameT v1 [#1574]

changeset 0d2ab3645b20083a65838d666e3c0778e1e715ef
Author: Hoang Vo 
Date:   Tue, 02 Aug 2016 15:16:03 +0700

cpsv: Add new message to support extended SaNameT v1 [#1574] New 
messages
supporting extended SaNameT are introduce. Encoding and decoding 
funtions
for them are also included.

changeset 13de643d5e887f68178651ba9610c486dbfde82b
Author: Hoang Vo 
Date:   Tue, 02 Aug 2016 15:16:03 +0700

cpd: Add new mbcsv messages supporting extended SaNameT v1 [#1574] New 
MBCSV
messages supporting extended SaNameT and their encoding/decoding 
functions
are included.

changeset de69ca58258b72dc4a97f48ca2e68e9b023d0e5f
Author: Hoang Vo 
Date:   Tue, 02 Aug 2016 15:16:03 +0700

cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and 
CPA
v1 [#1574]

changeset 9d469821de69d8b5252010bf3b5d04ab84b00ba9
Author: Hoang Vo 
Date:   Tue, 02 Aug 2016 15:16:03 +0700

ckpt: Add new test cases to verify long DN feature on CPSV v1 [#1574]

changeset 3f57a04ecd76a5449add80ea5898cc441d968103
Author: Hoang Vo 
Date:   Tue, 02 Aug 2016 15:16:03 +0700

imported patch 1574_cpnd_support_recover_shm_version_0_v3.patch


Complete diffstat:
--
 osaf/libs/agents/saf/cpa/Makefile.am  |1 +
 osaf/libs/agents/saf/cpa/cpa_api.c|   68 +++---
 osaf/libs/agents/saf/cpa/cpa_db.c |2 +
 osaf/libs/agents/saf/cpa/cpa_mds.c|8 +-
 osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
 osaf/libs/common/cpsv/cpsv_evt.c  |  505 
+--
 osaf/libs/common/cpsv/include/cpa.h   |1 +
 osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
 osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
 osaf/libs/common/cpsv/include/cpd.h   |1 +
 osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
 osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
 osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
 osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
 osaf/libs/common/cpsv/include/cpnd.h  |1 +
 osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
 osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
 osaf/libs/common/cpsv/include/cpsv_evt.h  |   24 +++
 osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
 osaf/services/saf/cpsv/cpd/Makefile.am|1 +
 osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
 osaf/services/saf/cpsv/cpd/cpd_db.c   |   95 +++---
 osaf/services/saf/cpsv/cpd/cpd_evt.c  |  107 +++-
 osaf/services/saf/cpsv/cpd/cpd_imm.c  |  268 
++
 osaf/services/saf/cpsv/cpd/cpd_main.c |7 +
 osaf/services/saf/cpsv/cpd/cpd_mbcsv.c|   31 -
 osaf/services/saf/cpsv/cpd/cpd_mds.c  |   86 -
 osaf/services/saf/cpsv/cpd/cpd_proc.c |  184 +++--
 osaf/services/saf/cpsv/cpd/cpd_red.c  |6 +-
 osaf/services/saf/cpsv/cpd/cpd_sbevt.c|   57 +++-
 osaf/services/saf/cpsv/cpnd/Makefile.am   |1 +
 osaf/services/saf/cpsv/cpnd/cpnd_db.c |6 +-
 osaf/services/saf/cpsv/cpnd/cpnd_evt.c|  101 +++
 osaf/services/saf/cpsv/cpnd/cpnd_main.c   |7 +
 osaf/services/saf/cpsv/cpnd/cpnd_mds.c|   86 -
 osaf/services/saf/cpsv/cpnd/cpnd_proc.c   |   92 ++---
 osaf/services/saf/cpsv/cpnd/cpnd_res.c|  823 

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

2016-07-05 Thread A V Mahesh
Hi Hoang,

Except  [PATCH 8 of 8] ,  I am done with code review , please try to 
optimize  the [PATCH 8 of 8]  logic with single function , with three 
different version arguments.

Please provide updated V2 patch with review comments along with README, 
so that we can move for testing.

-AVM


On 7/1/2016 9:59 AM, A V Mahesh wrote:
> Hi Hoang,
>
> Thanks for the clarifications.
>
> Please hold on publishing new version of patch, I am in process of 
> reviewing[PATCH 2 to  8] ,
>
> so we may  have some more comments , so we can have on single 
> consolidated patch V2.
>
> -AVM
>
>
> On 7/1/2016 9:27 AM, Vo Minh Hoang wrote:
>> Dear Mahesh,
>>
>> I would like to answer to your comments.
>>
 Comment 1 :
>> I will update PR document so there is not a README file.
>>
 Comment 2:
>> I thought that we should keep current implementation even it is not
>> beautiful. The reasons are:
>> - keep a consistence way to access string value.
>> - 2 pointers to one string brings potential problem for future 
>> maintenance.
>> - For near future changing to CPP,  this implementation can easily 
>> change to
>> nicer way.
>>
 Comment 3 :
>> I'm agreed with your comments, will work on that in next version of 
>> patch.
>>
 Comment 4 :
>> Firstly, I tried to look for ckpt_name usage in source code but found
>> nothing.
>> Secondly, struct cpd_cpnd_info_node contains cpnd node info so it 
>> does not
>> have any ckpt_name related sematic. And struct cpd_cpnd_info_node 
>> also have
>> ckpt_ref_list to refer all its check points.
>> So ckpt_name seems redundant and need to be removed.
>>
 Comment 5 :
>> I'm agreed. This work has lower priority and will be submitted in 
>> different
>> patch/ticket.
>>
>> P.S. About the problem #1574 patches cannot apply on today's staging. I
>> tested and found that it need to be applied after #1874. I skip 
>> sending new
>> version for updating patch following your comments.
>>
>> Thank you and best regards,
>> Hoang
>>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: Thursday, June 30, 2016 11:41 AM
>> To: Vo Minh Hoang 
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: Re: [PATCH 0 of 8] Review Request for CKPT: Support DNs 
>> longer than
>> 255 bytes [#1574]
>>
>> Hi  Hoang ,
>>
>> On 6/30/2016 9:22 AM, Vo Minh Hoang wrote:
>>> Dear Mahesh,
>>>
>>> Now I am updating documents related to CKPT long DN.
>>> It will be submitted soon.
>> Ok you can ignore comment one.
>>
>> I will provide patch by patch clarification & review comments, please 
>> find
>> them  for  [PATCH 1 of 8]
>>
>>
>> Comment 1 :
>>
>> ==
>> @@ -26,6 +27,12 @@ static int __init_cpd(void)
>>{
>>NCS_LIB_REQ_INFO lib_create;
>>
>> +/* Enable extended SaNameT */
>> +if (setenv("SA_ENABLE_EXTENDED_NAMES", "1", 1) != 0) {
>> +LOG_ER("Failed to set environment variable:
>> SA_ENABLE_EXTENDED_NAMES");
>> +return m_LEAP_DBG_SINK(NCSCC_RC_FAILURE);
>> +}
>> +
>> ==
>>
>> Can you please  provide   README about  long DN  Support , which will
>> consist information such as `how steps to enable long DN setting`
>>
>> similar to   LOG service,  please find  reference LOG service README
>> Support Long DN
>> `https://sourceforge.net/p/opensaf/tickets/_discuss/thread/6ba7a0c9/8103/att 
>>
>> achment/README_LONGDN_R2`
>>
>>
>> Comment 2 :
>>
>> ==
>> @@ -334,10 +334,10 @@ uint32_t cpd_amf_register(CPD_CB *cpd_cb
>>
>>}
>>if (saAmfComponentRegister(cpd_cb->amf_hdl, _cb->comp_name,
>> (SaNameT *)NULL) == SA_AIS_OK) {
>> -TRACE_LEAVE2("cpd amf register success for
>> %s",cpd_cb->comp_name.value);
>> +TRACE_LEAVE2("cpd amf register success for %s",
>> osaf_extended_name_borrow(_cb->comp_name));
>>
>> ==
>>
>> I think `cpd_cb->comp_name` `cluster_node.nodeName` kind of variables
>> are fill once and thy are consistent ,
>> so is it possible to store such variable once by using
>> `osaf_extended_name_borrow()` when the intial value getting assigned?
>> this comment applies to all other consistent variables .
>>
>> Comment 3 :
>>
>> ==
>>
>> @@ -166,6 +162,9 @@ uint32_t cpd_ckpt_node_delete(CPD_CB *cb
>>rc = NCSCC_RC_FAILURE;
>>}
>>
>> +if (ckpt_node->ckpt_name != NULL)
>> +free((void *)ckpt_node->ckpt_name);
>> +
>> ==
>>
>> Ideally frees can be part of m_MMGR_FREE_CPD_CKPT_INFO_NODE() , so that
>> we can avoid multiple free calls ( code readability )
>> this comment applies to all other free chances.
>>
>> Comment 4 :
>>
>> ==
>>
>> @@ -123,8 +123,7 @@ typedef 

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

2016-06-30 Thread A V Mahesh
Hi Hoang,

Thanks for the clarifications.

Please hold on publishing new version of patch, I am in process of 
reviewing[PATCH 2 to  8] ,

so we may  have some more comments , so we can have on single 
consolidated patch V2.

-AVM


On 7/1/2016 9:27 AM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> I would like to answer to your comments.
>
>>> Comment 1 :
> I will update PR document so there is not a README file.
>
>>> Comment 2:
> I thought that we should keep current implementation even it is not
> beautiful. The reasons are:
> - keep a consistence way to access string value.
> - 2 pointers to one string brings potential problem for future maintenance.
> - For near future changing to CPP,  this implementation can easily change to
> nicer way.
>
>>> Comment 3 :
> I'm agreed with your comments, will work on that in next version of patch.
>
>>> Comment 4 :
> Firstly, I tried to look for ckpt_name usage in source code but found
> nothing.
> Secondly, struct cpd_cpnd_info_node contains cpnd node info so it does not
> have any ckpt_name related sematic. And struct cpd_cpnd_info_node also have
> ckpt_ref_list to refer all its check points.
> So ckpt_name seems redundant and need to be removed.
>
>>> Comment 5 :
> I'm agreed. This work has lower priority and will be submitted in different
> patch/ticket.
>
> P.S. About the problem #1574 patches cannot apply on today's staging. I
> tested and found that it need to be applied after #1874. I skip sending new
> version for updating patch following your comments.
>
> Thank you and best regards,
> Hoang
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Thursday, June 30, 2016 11:41 AM
> To: Vo Minh Hoang 
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than
> 255 bytes [#1574]
>
> Hi  Hoang ,
>
> On 6/30/2016 9:22 AM, Vo Minh Hoang wrote:
>> Dear Mahesh,
>>
>> Now I am updating documents related to CKPT long DN.
>> It will be submitted soon.
> Ok you can ignore comment one.
>
> I will provide patch by patch clarification & review comments, please find
> them  for  [PATCH 1 of 8]
>
>
> Comment 1 :
>
> ==
> @@ -26,6 +27,12 @@ static int __init_cpd(void)
>{
>NCS_LIB_REQ_INFO lib_create;
>
> +/* Enable extended SaNameT */
> +if (setenv("SA_ENABLE_EXTENDED_NAMES", "1", 1) != 0) {
> +LOG_ER("Failed to set environment variable:
> SA_ENABLE_EXTENDED_NAMES");
> +return m_LEAP_DBG_SINK(NCSCC_RC_FAILURE);
> +}
> +
> ==
>
> Can you please  provide   README about  long DN  Support , which will
> consist information such as `how steps to enable long DN setting`
>
> similar to   LOG service,  please find  reference LOG service README
> Support Long DN
> `https://sourceforge.net/p/opensaf/tickets/_discuss/thread/6ba7a0c9/8103/att
> achment/README_LONGDN_R2`
>
>
> Comment 2 :
>
> ==
> @@ -334,10 +334,10 @@ uint32_t cpd_amf_register(CPD_CB *cpd_cb
>
>}
>if (saAmfComponentRegister(cpd_cb->amf_hdl, _cb->comp_name,
> (SaNameT *)NULL) == SA_AIS_OK) {
> -TRACE_LEAVE2("cpd amf register success for
> %s",cpd_cb->comp_name.value);
> +TRACE_LEAVE2("cpd amf register success for %s",
> osaf_extended_name_borrow(_cb->comp_name));
>
> ==
>
> I think `cpd_cb->comp_name` `cluster_node.nodeName` kind of variables
> are fill once and thy are consistent ,
> so is it possible to store such variable once by using
> `osaf_extended_name_borrow()` when the intial value getting assigned?
> this comment applies to all other consistent variables .
>
> Comment 3 :
>
> ==
>
> @@ -166,6 +162,9 @@ uint32_t cpd_ckpt_node_delete(CPD_CB *cb
>rc = NCSCC_RC_FAILURE;
>}
>
> +if (ckpt_node->ckpt_name != NULL)
> +free((void *)ckpt_node->ckpt_name);
> +
> ==
>
> Ideally frees can be part of m_MMGR_FREE_CPD_CKPT_INFO_NODE() , so that
> we can avoid multiple free calls ( code readability )
> this comment applies to all other free chances.
>
> Comment 4 :
>
> ==
>
> @@ -123,8 +123,7 @@ typedef struct cpd_cpnd_info_node {
>uint32_t timer_state;
>bool ckpt_cpnd_scxb_exist;
>/* for imm */
> -SaNameT node_name;
> -SaNameT ckpt_name;
> +SaConstStringT node_name;
> ===
>
> why ckpt_name removed form struct cpd_cpnd_info_node ?
> is it no more used in this struct ?
>
>
> Comment 5 :
>
> It will be more useful to provide or change the cpsv_demo application to
> use LONG DN
>
> /staging/samples/cpsv
>
> -AVM
>
>> Thank you 

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

2016-06-29 Thread A V Mahesh
Hi  Hoang ,

On 6/30/2016 9:22 AM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> Now I am updating documents related to CKPT long DN.
> It will be submitted soon.
Ok you can ignore comment one.

I will provide patch by patch clarification & review comments, please 
find them  for  [PATCH 1 of 8]


Comment 1 :

==
@@ -26,6 +27,12 @@ static int __init_cpd(void)
  {
  NCS_LIB_REQ_INFO lib_create;

+/* Enable extended SaNameT */
+if (setenv("SA_ENABLE_EXTENDED_NAMES", "1", 1) != 0) {
+LOG_ER("Failed to set environment variable: 
SA_ENABLE_EXTENDED_NAMES");
+return m_LEAP_DBG_SINK(NCSCC_RC_FAILURE);
+}
+
==

Can you please  provide   README about  long DN  Support , which will 
consist information such as `how steps to enable long DN setting`

similar to   LOG service,  please find  reference LOG service README 
Support Long DN
`https://sourceforge.net/p/opensaf/tickets/_discuss/thread/6ba7a0c9/8103/attachment/README_LONGDN_R2`


Comment 2 :

==
@@ -334,10 +334,10 @@ uint32_t cpd_amf_register(CPD_CB *cpd_cb

  }
  if (saAmfComponentRegister(cpd_cb->amf_hdl, _cb->comp_name, 
(SaNameT *)NULL) == SA_AIS_OK) {
-TRACE_LEAVE2("cpd amf register success for 
%s",cpd_cb->comp_name.value);
+TRACE_LEAVE2("cpd amf register success for %s", 
osaf_extended_name_borrow(_cb->comp_name));

==

I think `cpd_cb->comp_name` `cluster_node.nodeName` kind of variables 
are fill once and thy are consistent ,
so is it possible to store such variable once by using 
`osaf_extended_name_borrow()` when the intial value getting assigned?
this comment applies to all other consistent variables .

Comment 3 :

==

@@ -166,6 +162,9 @@ uint32_t cpd_ckpt_node_delete(CPD_CB *cb
  rc = NCSCC_RC_FAILURE;
  }

+if (ckpt_node->ckpt_name != NULL)
+free((void *)ckpt_node->ckpt_name);
+
==

Ideally frees can be part of m_MMGR_FREE_CPD_CKPT_INFO_NODE() , so that 
we can avoid multiple free calls ( code readability )
this comment applies to all other free chances.

Comment 4 :

==

@@ -123,8 +123,7 @@ typedef struct cpd_cpnd_info_node {
  uint32_t timer_state;
  bool ckpt_cpnd_scxb_exist;
  /* for imm */
-SaNameT node_name;
-SaNameT ckpt_name;
+SaConstStringT node_name;
===

why ckpt_name removed form struct cpd_cpnd_info_node ?
is it no more used in this struct ?


Comment 5 :

It will be more useful to provide or change the cpsv_demo application to 
use LONG DN

/staging/samples/cpsv

-AVM

>
> Thank you and best regards,
> Hoang
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Wednesday, June 29, 2016 10:48 AM
> To: Hoang Vo 
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than
> 255 bytes [#1574]
>
> Hi Hoang,
>
> On 6/23/2016 4:23 PM, Hoang Vo wrote:
>> Testing Commands:
>> -
>> start all SCs and PLs
>> log in to Sc-1
>> run ckpttest
>> enable long DN setting
> Can you please how steps to enable long DN setting.  it will be more
> useful to have  README about  long DN  Support similar to
> LOG service,  please find  reference LOG service README Support Long DN
> `https://sourceforge.net/p/opensaf/tickets/_discuss/thread/6ba7a0c9/8103/att
> achment/README_LONGDN_R2`
>
>
> -AVM
>
>
>
> On 6/23/2016 4:23 PM, Hoang Vo wrote:
>> Summary: CKPT: Support DNs longer than 255 bytes [#1574]
>> Review request for Trac Ticket(s): 1574
>> Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
>> Pull request to: mahesh.va...@oracle.com
>> Affected branch(es): default
>> Development branch: default
>>
>> 
>> Impacted area   Impact y/n
>> 
>>Docsn
>>Build systemn
>>RPM/packaging   n
>>Configuration files n
>>Startup scripts n
>>SAF servicesy
>>OpenSAF servicesn
>>Core libraries  n
>>Samples n
>>Tests   y
>>Other   n
>>
>>
>> Comments (indicate scope for each "y" above):
>> -
>>
>> changeset 729f0b7318a9e628a00ed6ab0617c85d4527aa73
>> Author:  Hoang Vo 
>> Date:Thu, 23 Jun 2016 17:42:12 +0700
>>
>>  cpd: Add support for extended SaNameT [#1574]
>>
>> changeset c2fae0887466adc3414fa64506832122896e6070
>> Author:  Hoang Vo 

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

2016-06-28 Thread A V Mahesh
Hi Hoang,

On 6/23/2016 4:23 PM, Hoang Vo wrote:
> Testing Commands:
> -
> start all SCs and PLs
> log in to Sc-1
> run ckpttest
> enable long DN setting
   Can you please how steps to enable long DN setting.  it will be more 
useful to have  README about  long DN  Support similar to
   LOG service,  please find  reference LOG service README Support Long DN
`https://sourceforge.net/p/opensaf/tickets/_discuss/thread/6ba7a0c9/8103/attachment/README_LONGDN_R2`
 


-AVM



On 6/23/2016 4:23 PM, Hoang Vo wrote:
> Summary: CKPT: Support DNs longer than 255 bytes [#1574]
> Review request for Trac Ticket(s): 1574
> Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
> Pull request to: mahesh.va...@oracle.com
> Affected branch(es): default
> Development branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesy
>   OpenSAF servicesn
>   Core libraries  n
>   Samples n
>   Tests   y
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>
> changeset 729f0b7318a9e628a00ed6ab0617c85d4527aa73
> Author:   Hoang Vo 
> Date: Thu, 23 Jun 2016 17:42:12 +0700
>
>   cpd: Add support for extended SaNameT [#1574]
>
> changeset c2fae0887466adc3414fa64506832122896e6070
> Author:   Hoang Vo 
> Date: Thu, 23 Jun 2016 17:42:12 +0700
>
>   cpnd: Add support for extended SaNameT v1 [#1574]
>
> changeset 98a1ed77d1de469b95022d5ea302b1e3d94b949b
> Author:   Hoang Vo 
> Date: Thu, 23 Jun 2016 17:42:12 +0700
>
>   cpa: Add support for extended SaNameT v1 [#1574]
>
> changeset adb30ae18b5972a4948403cabe379d5546ccdbea
> Author:   Hoang Vo 
> Date: Thu, 23 Jun 2016 17:42:12 +0700
>
>   cpsv: Add new message to support extended SaNameT v1 [#1574] New 
> messages
>   supporting extended SaNameT are introduce. Encoding and decoding 
> funtions
>   for them are also included.
>
> changeset dd4916df11a3e50a76f9002b00fefd63364f7599
> Author:   Hoang Vo 
> Date: Thu, 23 Jun 2016 17:42:12 +0700
>
>   cpd: Add new mbcsv messages supporting extended SaNameT v1 [#1574] New 
> MBCSV
>   messages supporting extended SaNameT and their encoding/decoding 
> functions
>   are included.
>
> changeset f091e95968329ed246c613537c636efe1508f3e8
> Author:   Hoang Vo 
> Date: Thu, 23 Jun 2016 17:42:12 +0700
>
>   cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and 
> CPA
>   v1 [#1574]
>
> changeset d1bc0b21ac74f3eb2a6fff7c3d46dd7ef478ec92
> Author:   Hoang Vo 
> Date: Thu, 23 Jun 2016 17:42:12 +0700
>
>   ckpt: Add new test cases to verify long DN feature on CPSV v1 [#1574]
>
> changeset 4d297fdba6e02c0501ad9872f98b85372bb6f6ce
> Author:   Hoang Vo 
> Date: Thu, 23 Jun 2016 17:42:12 +0700
>
>   imported patch 1574_cpnd_support_recover_shm_version_0_v2.patch
>
>
> Complete diffstat:
> --
>   osaf/libs/agents/saf/cpa/Makefile.am  |1 +
>   osaf/libs/agents/saf/cpa/cpa_api.c|   50 ---
>   osaf/libs/agents/saf/cpa/cpa_db.c |2 +
>   osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
>   osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
>   osaf/libs/common/cpsv/cpsv_evt.c  |  505 
> +--
>   osaf/libs/common/cpsv/include/cpa.h   |1 +
>   osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
>   osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpd.h   |1 +
>   osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
>   osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
>   osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpnd.h  |1 +
>   osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
>   osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
>   osaf/libs/common/cpsv/include/cpsv_evt.h  |   24 +++
>   osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
>   osaf/services/saf/cpsv/cpd/Makefile.am|1 +
>   osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
>   osaf/services/saf/cpsv/cpd/cpd_db.c   |  110 +---
>   osaf/services/saf/cpsv/cpd/cpd_evt.c  |  107 +++-
>   osaf/services/saf/cpsv/cpd/cpd_imm.c  |  268 
> ++
>   osaf/services/saf/cpsv/cpd/cpd_main.c |7 +
>   osaf/services/saf/cpsv/cpd/cpd_mbcsv.c|   31 -
>