[devel] [PATCH 1 of 1] amfd: avoid null pointer access [#1365]

2015-05-05 Thread nagendra . k
 osaf/services/saf/amf/amfd/role.cc |  3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


During node failover if node is not found at amfd,
then my_node remains null and amfd access it in the end.
It needs to avoided as amfd crashes.

diff --git a/osaf/services/saf/amf/amfd/role.cc 
b/osaf/services/saf/amf/amfd/role.cc
--- a/osaf/services/saf/amf/amfd/role.cc
+++ b/osaf/services/saf/amf/amfd/role.cc
@@ -366,7 +366,8 @@ static uint32_t avd_role_failover(AVD_CL
 
 done:
if (NCSCC_RC_SUCCESS != status)
-   opensaf_reboot(my_node->node_info.nodeId, (char 
*)my_node->node_info.executionEnvironment.value,
+   opensaf_reboot(my_node != NULL ? my_node->node_info.nodeId : 0,
+   my_node != NULL ? (char 
*)my_node->node_info.executionEnvironment.value : NULL,
"FAILOVER failed");
 
 

--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel


Re: [devel] [PATCH 1 of 1] amfd: avoid null pointer access [#1365]

2015-05-06 Thread Hans Nordebäck
ack, code review only/Thanks HansN

On 05/05/2015 12:55 PM, nagendr...@oracle.com wrote:
>   osaf/services/saf/amf/amfd/role.cc |  3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> During node failover if node is not found at amfd,
> then my_node remains null and amfd access it in the end.
> It needs to avoided as amfd crashes.
>
> diff --git a/osaf/services/saf/amf/amfd/role.cc 
> b/osaf/services/saf/amf/amfd/role.cc
> --- a/osaf/services/saf/amf/amfd/role.cc
> +++ b/osaf/services/saf/amf/amfd/role.cc
> @@ -366,7 +366,8 @@ static uint32_t avd_role_failover(AVD_CL
>   
>   done:
>   if (NCSCC_RC_SUCCESS != status)
> - opensaf_reboot(my_node->node_info.nodeId, (char 
> *)my_node->node_info.executionEnvironment.value,
> + opensaf_reboot(my_node != NULL ? my_node->node_info.nodeId : 0,
> + my_node != NULL ? (char 
> *)my_node->node_info.executionEnvironment.value : NULL,
>   "FAILOVER failed");
>   
>   


--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel