Re: [devel] [PATCH 1 of 1] amfnd: avoid sending SUSI resp during recovery [#1931]
Hi Nagu ack (review only) Thanks On 4/08/2016 3:20 PM, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfnd/susm.cc | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > > During component failover recovery (NPI SU), Amfnd > attempt to send SUSI resp to Amfd though there is > no SUSI assignment is undergoing. > NPI SU terminating state is not a reflective of > SUSI assignment rather it can be during recovery > phases also. > > diff --git a/osaf/services/saf/amf/amfnd/susm.cc > b/osaf/services/saf/amf/amfnd/susm.cc > --- a/osaf/services/saf/amf/amfnd/susm.cc > +++ b/osaf/services/saf/amf/amfnd/susm.cc > @@ -1832,7 +1832,9 @@ uint32_t avnd_su_pres_st_chng_prc(AVND_C > rc = avnd_di_oper_send(cb, su, > SA_AMF_COMPONENT_FAILOVER); > > /* si assignment/removal failed.. inform AvD */ > - rc = avnd_di_susi_resp_send(cb, su, > m_AVND_SU_IS_ALL_SI(su) ? 0 : si); > + /* Send response to Amfd only when there is a pending > assignment. */ > + if (m_AVND_SU_IS_ASSIGN_PEND(su)) > + rc = avnd_di_susi_resp_send(cb, su, > m_AVND_SU_IS_ALL_SI(su) ? 0 : si); > } > > /* instantiating -> term-failed */ -- ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 1 of 1] amfnd: avoid sending SUSI resp during recovery [#1931]
Please review it by today. Thanks -Nagu > -Original Message- > From: Nagendra Kumar > Sent: 04 August 2016 10:51 > To: hans.nordeb...@ericsson.com; Praveen Malviya; > minh.c...@dektech.com.au; gary@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net > Subject: [devel] [PATCH 1 of 1] amfnd: avoid sending SUSI resp during > recovery [#1931] > > osaf/services/saf/amf/amfnd/susm.cc | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > > During component failover recovery (NPI SU), Amfnd attempt to send SUSI > resp to Amfd though there is no SUSI assignment is undergoing. > NPI SU terminating state is not a reflective of SUSI assignment rather it can > be during recovery phases also. > > diff --git a/osaf/services/saf/amf/amfnd/susm.cc > b/osaf/services/saf/amf/amfnd/susm.cc > --- a/osaf/services/saf/amf/amfnd/susm.cc > +++ b/osaf/services/saf/amf/amfnd/susm.cc > @@ -1832,7 +1832,9 @@ uint32_t avnd_su_pres_st_chng_prc(AVND_C > rc = avnd_di_oper_send(cb, su, > SA_AMF_COMPONENT_FAILOVER); > > /* si assignment/removal failed.. inform AvD */ > - rc = avnd_di_susi_resp_send(cb, su, > m_AVND_SU_IS_ALL_SI(su) ? 0 : si); > + /* Send response to Amfd only when there is a > pending assignment. */ > + if (m_AVND_SU_IS_ASSIGN_PEND(su)) > + rc = avnd_di_susi_resp_send(cb, su, > m_AVND_SU_IS_ALL_SI(su) ? 0 : > +si); > } > > /* instantiating -> term-failed */ > > -- > ___ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel -- ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 1 of 1] amfnd: avoid sending SUSI resp during recovery [#1931]
osaf/services/saf/amf/amfnd/susm.cc | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) During component failover recovery (NPI SU), Amfnd attempt to send SUSI resp to Amfd though there is no SUSI assignment is undergoing. NPI SU terminating state is not a reflective of SUSI assignment rather it can be during recovery phases also. diff --git a/osaf/services/saf/amf/amfnd/susm.cc b/osaf/services/saf/amf/amfnd/susm.cc --- a/osaf/services/saf/amf/amfnd/susm.cc +++ b/osaf/services/saf/amf/amfnd/susm.cc @@ -1832,7 +1832,9 @@ uint32_t avnd_su_pres_st_chng_prc(AVND_C rc = avnd_di_oper_send(cb, su, SA_AMF_COMPONENT_FAILOVER); /* si assignment/removal failed.. inform AvD */ - rc = avnd_di_susi_resp_send(cb, su, m_AVND_SU_IS_ALL_SI(su) ? 0 : si); + /* Send response to Amfd only when there is a pending assignment. */ + if (m_AVND_SU_IS_ASSIGN_PEND(su)) + rc = avnd_di_susi_resp_send(cb, su, m_AVND_SU_IS_ALL_SI(su) ? 0 : si); } /* instantiating -> term-failed */ -- ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
