Re: [devel] [PATCH 1 of 1] clm: fix decoding for SaNameT type [#1906]

2016-08-16 Thread A V Mahesh
Hi Zoran,

ACK tested.

-AVM


On 8/16/2016 1:31 PM, Zoran Milinkovic wrote:
>   osaf/libs/common/clmsv/clmsv_enc_dec.c |  3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> Add null-terminated string to the end of decoded string for SaNameT type.
>
> diff --git a/osaf/libs/common/clmsv/clmsv_enc_dec.c 
> b/osaf/libs/common/clmsv/clmsv_enc_dec.c
> --- a/osaf/libs/common/clmsv/clmsv_enc_dec.c
> +++ b/osaf/libs/common/clmsv/clmsv_enc_dec.c
> @@ -36,11 +36,12 @@ uint32_t clmsv_decodeSaNameT(NCS_UBAID *
>   osafassert(0);
>   }
>   if(length >= SA_MAX_NAME_LENGTH) {
> - value = (char *)calloc(1, length + 1);
> + value = (char *)malloc(length + 1);
>   }
>   ncs_dec_skip_space(uba, 2);
>   total_bytes += 2;
>   ncs_decode_n_octets_from_uba(uba, (uint8_t *)value, (uint32_t)length);
> + value[length] = 0;
>   osaf_extended_name_lend(value, name);
>   total_bytes += length;
>   return total_bytes;
>
> --
> ___
> Opensaf-devel mailing list
> Opensaf-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel


[devel] [PATCH 1 of 1] clm: fix decoding for SaNameT type [#1906]

2016-08-16 Thread Zoran Milinkovic
 osaf/libs/common/clmsv/clmsv_enc_dec.c |  3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Add null-terminated string to the end of decoded string for SaNameT type.

diff --git a/osaf/libs/common/clmsv/clmsv_enc_dec.c 
b/osaf/libs/common/clmsv/clmsv_enc_dec.c
--- a/osaf/libs/common/clmsv/clmsv_enc_dec.c
+++ b/osaf/libs/common/clmsv/clmsv_enc_dec.c
@@ -36,11 +36,12 @@ uint32_t clmsv_decodeSaNameT(NCS_UBAID *
osafassert(0);
}
if(length >= SA_MAX_NAME_LENGTH) {
-   value = (char *)calloc(1, length + 1);
+   value = (char *)malloc(length + 1);
}
ncs_dec_skip_space(uba, 2);
total_bytes += 2;
ncs_decode_n_octets_from_uba(uba, (uint8_t *)value, (uint32_t)length);
+   value[length] = 0;
osaf_extended_name_lend(value, name);
total_bytes += length;
return total_bytes;

--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel