Re: [devel] [PATCH 1 of 1] log: assertion failed in log_stream_close [#1954]

[Vu Minh Nguyen]

Hi Lennart,

Last time, before raising this ticket, I also question how can it happened 
but I have not yet found out the cause.

I will push the ticket now, and will investigate the cause later.

Regards, Vu

> -Original Message-
> From: Lennart Lund [mailto:lennart.l...@ericsson.com]
> Sent: Wednesday, September 7, 2016 9:01 PM
> To: Vu Minh Nguyen ;
> mahesh.va...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [PATCH 1 of 1] log: assertion failed in log_stream_close
[#1954]
> 
> Hi Vu
> 
> ACK but a question
> 
> How can a client have a "cur_rec->stream_id" but no associated stream?
> Should not be possible? Other problem causing this?
> 
> Thanks
> Lennart
> 
> > -Original Message-
> > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
> > Sent: den 16 augusti 2016 12:09
> > To: Lennart Lund ; mahesh.va...@oracle.com
> > Cc: opensaf-devel@lists.sourceforge.net
> > Subject: [PATCH 1 of 1] log: assertion failed in log_stream_close
[#1954]
> >
> >  osaf/services/saf/logsv/lgs/lgs_evt.cc |  4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> >
> > Assertion failed in log_stream_close() because the caller did not check
> NULL
> > before calling the function.
> >
> > This patch adds the protection.
> >
> > diff --git a/osaf/services/saf/logsv/lgs/lgs_evt.cc
> > b/osaf/services/saf/logsv/lgs/lgs_evt.cc
> > --- a/osaf/services/saf/logsv/lgs/lgs_evt.cc
> > +++ b/osaf/services/saf/logsv/lgs/lgs_evt.cc
> > @@ -166,7 +166,9 @@ int lgs_client_delete(uint32_t client_id
> > lgs_stream_list_t *tmp_rec;
> > log_stream_t *stream = log_stream_get_by_id(cur_rec-
> > >stream_id);
> > TRACE_4("client_id: %u, REMOVE stream id: %u", client-
> > >client_id, cur_rec->stream_id);
> > -   log_stream_close(, );
> > +   if (stream != NULL) {
> > +   log_stream_close(, );
> > +   }
> > tmp_rec = cur_rec->next;
> > free(cur_rec);
> > cur_rec = tmp_rec;


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1 of 1] log: assertion failed in log_stream_close [#1954]

[A V Mahesh]

HI Vu,

ACK

-AVM


On 8/16/2016 3:39 PM, Vu Minh Nguyen wrote:
>   osaf/services/saf/logsv/lgs/lgs_evt.cc |  4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> Assertion failed in log_stream_close() because the caller did not check NULL
> before calling the function.
>
> This patch adds the protection.
>
> diff --git a/osaf/services/saf/logsv/lgs/lgs_evt.cc 
> b/osaf/services/saf/logsv/lgs/lgs_evt.cc
> --- a/osaf/services/saf/logsv/lgs/lgs_evt.cc
> +++ b/osaf/services/saf/logsv/lgs/lgs_evt.cc
> @@ -166,7 +166,9 @@ int lgs_client_delete(uint32_t client_id
>   lgs_stream_list_t *tmp_rec;
>   log_stream_t *stream = log_stream_get_by_id(cur_rec->stream_id);
>   TRACE_4("client_id: %u, REMOVE stream id: %u", 
> client->client_id, cur_rec->stream_id);
> - log_stream_close(, );
> + if (stream != NULL) {
> + log_stream_close(, );
> + }
>   tmp_rec = cur_rec->next;
>   free(cur_rec);
>   cur_rec = tmp_rec;


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 1 of 1] log: assertion failed in log_stream_close [#1954]

[Vu Minh Nguyen]

 osaf/services/saf/logsv/lgs/lgs_evt.cc |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)


Assertion failed in log_stream_close() because the caller did not check NULL
before calling the function.

This patch adds the protection.

diff --git a/osaf/services/saf/logsv/lgs/lgs_evt.cc 
b/osaf/services/saf/logsv/lgs/lgs_evt.cc
--- a/osaf/services/saf/logsv/lgs/lgs_evt.cc
+++ b/osaf/services/saf/logsv/lgs/lgs_evt.cc
@@ -166,7 +166,9 @@ int lgs_client_delete(uint32_t client_id
lgs_stream_list_t *tmp_rec;
log_stream_t *stream = log_stream_get_by_id(cur_rec->stream_id);
TRACE_4("client_id: %u, REMOVE stream id: %u", 
client->client_id, cur_rec->stream_id);
-   log_stream_close(, );
+   if (stream != NULL) {
+   log_stream_close(, );
+   }
tmp_rec = cur_rec->next;
free(cur_rec);
cur_rec = tmp_rec;

--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel