Re: [devel] [PATCH 1 of 2] log: fix to remove a redundant double quotation [#1463]

2017-03-13 Thread A V Mahesh 
Hi Can,

ACK for series, not tested

-AVM


On 3/8/2017 6:43 PM, Canh Van Truong wrote:
>   src/log/logd/lgs_fmt.cc |  3 ---
>   1 files changed, 0 insertions(+), 3 deletions(-)
>
>
> When sending a log record which is longer than limited quota,
> there will be a double quotation mark although there is not double quotation 
> in
> token format.
>
> The patch remove it.
>
> diff --git a/src/log/logd/lgs_fmt.cc b/src/log/logd/lgs_fmt.cc
> --- a/src/log/logd/lgs_fmt.cc
> +++ b/src/log/logd/lgs_fmt.cc
> @@ -1362,7 +1362,6 @@ int lgs_format_log_record(SaLogRecordT *
>   dest[fixedLogRecordSize - 1] = '\n';
>   i = fixedLogRecordSize;
> } else if ((fixedLogRecordSize > 0) && (i >= fixedLogRecordSize)) {
> -dest[fixedLogRecordSize - 2] = (SaInt8T)'\"';
>   dest[fixedLogRecordSize - 1] = '\n';
>   i = fixedLogRecordSize;
> }
> @@ -1375,11 +1374,9 @@ int lgs_format_log_record(SaLogRecordT *
> /* There can be situations when the filesize is as small as the 
> maxrecsize.
>  * For eg:- By default for the application streams max file size is 
> 1024
>  */
> -  dest[logFileSize - 2] = (SaInt8T)'\"';
> dest[logFileSize - 1] = '\n';
> i = logFileSize;
>   } else {
> -  dest[dest_size - 2] = (SaInt8T)'\"';
> dest[dest_size - 1] = '\n';
> i = dest_size;
>   }


--
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1 of 2] log: fix to remove a redundant double quotation [#1463]

2017-03-08 Thread Vu Minh Nguyen 
Ack

Regards, Vu

> -Original Message-
> From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
> Sent: Wednesday, March 8, 2017 2:13 PM
> To: lennart.l...@ericsson.com; mahesh.va...@oracle.com;
> vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 2] log: fix to remove a redundant double quotation
> [#1463]
> 
>  src/log/logd/lgs_fmt.cc |  3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> 
> When sending a log record which is longer than limited quota,
> there will be a double quotation mark although there is not double
quotation
> in
> token format.
> 
> The patch remove it.
> 
> diff --git a/src/log/logd/lgs_fmt.cc b/src/log/logd/lgs_fmt.cc
> --- a/src/log/logd/lgs_fmt.cc
> +++ b/src/log/logd/lgs_fmt.cc
> @@ -1362,7 +1362,6 @@ int lgs_format_log_record(SaLogRecordT *
>  dest[fixedLogRecordSize - 1] = '\n';
>  i = fixedLogRecordSize;
>} else if ((fixedLogRecordSize > 0) && (i >= fixedLogRecordSize)) {
> -dest[fixedLogRecordSize - 2] = (SaInt8T)'\"';
>  dest[fixedLogRecordSize - 1] = '\n';
>  i = fixedLogRecordSize;
>}
> @@ -1375,11 +1374,9 @@ int lgs_format_log_record(SaLogRecordT *
>/* There can be situations when the filesize is as small as the
maxrecsize.
> * For eg:- By default for the application streams max file size is
1024
> */
> -  dest[logFileSize - 2] = (SaInt8T)'\"';
>dest[logFileSize - 1] = '\n';
>i = logFileSize;
>  } else {
> -  dest[dest_size - 2] = (SaInt8T)'\"';
>dest[dest_size - 1] = '\n';
>i = dest_size;
>  }


--
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1 of 2] log: fix to remove a redundant double quotation [#1463]

2017-03-08 Thread Lennart Lund 
Ack

Thanks
Lennart

> -Original Message-
> From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
> Sent: den 8 mars 2017 14:13
> To: Lennart Lund ; mahesh.va...@oracle.com;
> Vu Minh Nguyen 
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 2] log: fix to remove a redundant double quotation
> [#1463]
> 
>  src/log/logd/lgs_fmt.cc |  3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> 
> When sending a log record which is longer than limited quota,
> there will be a double quotation mark although there is not double quotation
> in
> token format.
> 
> The patch remove it.
> 
> diff --git a/src/log/logd/lgs_fmt.cc b/src/log/logd/lgs_fmt.cc
> --- a/src/log/logd/lgs_fmt.cc
> +++ b/src/log/logd/lgs_fmt.cc
> @@ -1362,7 +1362,6 @@ int lgs_format_log_record(SaLogRecordT *
>  dest[fixedLogRecordSize - 1] = '\n';
>  i = fixedLogRecordSize;
>} else if ((fixedLogRecordSize > 0) && (i >= fixedLogRecordSize)) {
> -dest[fixedLogRecordSize - 2] = (SaInt8T)'\"';
>  dest[fixedLogRecordSize - 1] = '\n';
>  i = fixedLogRecordSize;
>}
> @@ -1375,11 +1374,9 @@ int lgs_format_log_record(SaLogRecordT *
>/* There can be situations when the filesize is as small as the 
> maxrecsize.
> * For eg:- By default for the application streams max file size is 
> 1024
> */
> -  dest[logFileSize - 2] = (SaInt8T)'\"';
>dest[logFileSize - 1] = '\n';
>i = logFileSize;
>  } else {
> -  dest[dest_size - 2] = (SaInt8T)'\"';
>dest[dest_size - 1] = '\n';
>i = dest_size;
>  }

--
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel