Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

2016-08-04 Thread A V Mahesh 
Hi Anders Widell,

I ran & cleared all the warnings  provide by  "make cppcheck" and "make 
cpplint"  tools in new files lgs_clm.cc  & lgs_clm.h
  in V3 patch please review.

-AVM


On 8/2/2016 4:02 PM, Anders Widell wrote:
> Hi!
>
> I ran "make cppcheck" and "make cpplint" on these new patches, and I 
> still get the following warnings for the two new files lgs_clm.cc and 
> lgs_clm.h:
>
> [osaf/services/saf/logsv/lgs/lgs_clm.cc:98] -> 
> [osaf/services/saf/logsv/lgs/lgs_clm.cc:100]: (style) Variable 'rc' is 
> reassigned a value before the old one has been used.
> ./osaf/services/saf/logsv/lgs/lgs_clm.h:0:  No #ifndef header guard 
> found, suggested CPP variable is: 
> OSAF_SERVICES_SAF_LOGSV_LGS_LGS_CLM_H_  [build/header_guard] [5]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:18:  Include the directory 
> when naming .h files  [build/include] [4]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:19:  Include the directory 
> when naming .h files  [build/include] [4]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:31:  Lines should be <= 80 
> characters long  [whitespace/line_length] [2]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:32:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:33:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:34:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:35:  { should almost always 
> be at the end of the previous line  [whitespace/braces] [4]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:36:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:37:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:38:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:39:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:41:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:42:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:43:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:44:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:45:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:46:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:48:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:49:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:50:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:51:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:52:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:53:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:54:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:55:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:56:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:57:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:58:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:58:  Missing space before {  
> [whitespace/braces] [5]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:59:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:60:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:61:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:62:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:63:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:64:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:65:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:66:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:67:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:68:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:69:  Tab found; better to use 
> spaces  [whitespace/tab]

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

2016-08-03 Thread Anders Widell 
.cc and .h files are supposed to be in the same directory according to 
the style guide. You can specify the full path to the include file from 
the top of the source tree:

#include "osaf/services/saf/logsv/lgs/lgs_clm.h"

regards,
Anders Widell

On 08/03/2016 12:22 PM, A V Mahesh wrote:
> Hi Anders Widel,
>
> I cleared all the warnings, except following please suggest the how do 
> we adders them :
>
> 1 )  Reason for the followings warnings  because of lgs  *.h files are 
> not in a `include`  directory ,
>  can I ignore or do i move all the .h file to `include` directory ?
>
>
> ./lgs_clm.cc:18:  Include the directory when naming .h files 
> [build/include] [4]
> ./lgs_clm.cc:19:  Include the directory when naming .h files 
> [build/include] [4]
>
> -AVM
>
> On 8/2/2016 4:02 PM, Anders Widell wrote:
>> Hi!
>>
>> I ran "make cppcheck" and "make cpplint" on these new patches, and I 
>> still get the following warnings for the two new files lgs_clm.cc and 
>> lgs_clm.h:
>>
>> [osaf/services/saf/logsv/lgs/lgs_clm.cc:98] -> 
>> [osaf/services/saf/logsv/lgs/lgs_clm.cc:100]: (style) Variable 'rc' 
>> is reassigned a value before the old one has been used.
>> ./osaf/services/saf/logsv/lgs/lgs_clm.h:0:  No #ifndef header guard 
>> found, suggested CPP variable is: 
>> OSAF_SERVICES_SAF_LOGSV_LGS_LGS_CLM_H_  [build/header_guard] [5]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:18:  Include the directory 
>> when naming .h files  [build/include] [4]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:19:  Include the directory 
>> when naming .h files  [build/include] [4]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:31:  Lines should be <= 80 
>> characters long  [whitespace/line_length] [2]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:32:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:33:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:34:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:35:  { should almost always 
>> be at the end of the previous line  [whitespace/braces] [4]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:36:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:37:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:38:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:39:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:41:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:42:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:43:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:44:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:45:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:46:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:48:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:49:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:50:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:51:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:52:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:53:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:54:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:55:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:56:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:57:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:58:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:58:  Missing space before {  
>> [whitespace/braces] [5]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:59:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:60:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:61:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:62:  Tab found; better to 
>> use spaces  [whitespace/tab] [1]
>> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:63:  Tab

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

2016-08-03 Thread A V Mahesh 
Hi Anders Widel,

I cleared all the warnings, except following please suggest the how do 
we adders them :

1 )  Reason for the followings warnings  because of lgs  *.h files are 
not in a `include`  directory ,
  can I ignore or do i move all the .h file to `include` directory ?


./lgs_clm.cc:18:  Include the directory when naming .h files 
[build/include] [4]
./lgs_clm.cc:19:  Include the directory when naming .h files 
[build/include] [4]

-AVM

On 8/2/2016 4:02 PM, Anders Widell wrote:
> Hi!
>
> I ran "make cppcheck" and "make cpplint" on these new patches, and I 
> still get the following warnings for the two new files lgs_clm.cc and 
> lgs_clm.h:
>
> [osaf/services/saf/logsv/lgs/lgs_clm.cc:98] -> 
> [osaf/services/saf/logsv/lgs/lgs_clm.cc:100]: (style) Variable 'rc' is 
> reassigned a value before the old one has been used.
> ./osaf/services/saf/logsv/lgs/lgs_clm.h:0:  No #ifndef header guard 
> found, suggested CPP variable is: 
> OSAF_SERVICES_SAF_LOGSV_LGS_LGS_CLM_H_  [build/header_guard] [5]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:18:  Include the directory 
> when naming .h files  [build/include] [4]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:19:  Include the directory 
> when naming .h files  [build/include] [4]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:31:  Lines should be <= 80 
> characters long  [whitespace/line_length] [2]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:32:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:33:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:34:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:35:  { should almost always 
> be at the end of the previous line  [whitespace/braces] [4]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:36:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:37:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:38:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:39:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:41:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:42:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:43:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:44:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:45:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:46:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:48:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:49:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:50:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:51:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:52:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:53:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:54:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:55:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:56:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:57:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:58:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:58:  Missing space before {  
> [whitespace/braces] [5]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:59:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:60:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:61:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:62:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:63:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:64:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:65:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
> ./osaf/services/saf/logsv/lgs/lgs_clm.cc:66:  Tab found; better to use 
> spaces  [whitespace/tab] [1]
>

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

2016-08-02 Thread Anders Widell 
Hi!

I ran "make cppcheck" and "make cpplint" on these new patches, and I 
still get the following warnings for the two new files lgs_clm.cc and 
lgs_clm.h:

[osaf/services/saf/logsv/lgs/lgs_clm.cc:98] -> 
[osaf/services/saf/logsv/lgs/lgs_clm.cc:100]: (style) Variable 'rc' is 
reassigned a value before the old one has been used.
./osaf/services/saf/logsv/lgs/lgs_clm.h:0:  No #ifndef header guard 
found, suggested CPP variable is: 
OSAF_SERVICES_SAF_LOGSV_LGS_LGS_CLM_H_  [build/header_guard] [5]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:18:  Include the directory when 
naming .h files  [build/include] [4]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:19:  Include the directory when 
naming .h files  [build/include] [4]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:31:  Lines should be <= 80 
characters long  [whitespace/line_length] [2]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:32:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:33:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:34:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:35:  { should almost always be 
at the end of the previous line  [whitespace/braces] [4]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:36:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:37:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:38:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:39:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:41:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:42:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:43:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:44:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:45:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:46:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:48:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:49:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:50:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:51:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:52:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:53:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:54:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:55:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:56:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:57:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:58:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:58:  Missing space before {  
[whitespace/braces] [5]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:59:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:60:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:61:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:62:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:63:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:64:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:65:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:66:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:67:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:68:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:69:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:70:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:71:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:72:  Tab found; better to use 
spaces  [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:72:  Line ends in whitespace.  
Consider deleting these

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

2016-08-02 Thread A V Mahesh 
Hi Anders Widell,

Sorry , I missed to do hg add of new file , will resend.

-AVM


On 8/2/2016 1:49 PM, Anders Widell wrote:
> Hi Mahesh!
>
> The files lgs_clm.cc and lgs_clm.h seem to be missing in these 
> patches. Could you please resend?
>
> thanks,
>
> Anders Widell
>
> On 08/02/2016 07:18 AM, mahesh.va...@oracle.com wrote:
>> Summary:lga: agent Cluster Membership (CLM) integration [#1638] V2
>> Review request for Trac Ticket(s): #1638
>> Peer Reviewer(s):Vu, Lennart,Anders Widell
>> Pull request to: <>
>> Affected branch(es): default
>> Development branch: default
>>
>> 
>> Impacted area   Impact y/n
>> 
>>   Docsn
>>   Build systemn
>>   RPM/packaging   n
>>   Configuration files n
>>   Startup scripts n
>>   SAF servicesn
>>   OpenSAF servicesy
>>   Core libraries  n
>>   Samples n
>>   Tests   y
>>   Other   n
>>
>>
>> Comments (indicate scope for each "y" above):
>> -
>>   <>
>>
>> changeset d7c494e940160d474a89dbafbc2cbf058678
>> Author:A V Mahesh 
>> Date:Tue, 02 Aug 2016 10:41:21 +0530
>>
>> lga: agent Cluster Membership (CLM) integration [#1638] V2
>>  V2 patch:
>>
>> Incorporated Anders Widell and Vu review comments , for more details
>> see the review comments posted on V1 patch. Description:
>>
>> Form CLM integration is supported from Log Service A.02.02.
>>
>> At-least a A.02.02 LGA client will check CLM membership status of 
>> client's
>> node. old LGA clients A.02.01 are always clm member.
>>
>> This patch enhanced the log service for Unavailability of the Log 
>> Service
>> API on a Non-Member Node which will fail with 
>> SA_AIS_ERR_UNAVAILABLE.
>>
>> After this patch the Log Service does not provide service to 
>> processes on
>> cluster nodes that are not in the cluster membership.
>>
>> If the node rejoins the cluster membership, processes executing 
>> on the node
>> will be able to reinitialize new library handles and use the 
>> entire set of
>> Log Service APIs that operate on these new handles; however, 
>> invocation of
>> APIs that operate on handles acquired by any process before the 
>> node left
>> the membership will continue to fail with SA_AIS_ERR_UNAVAILABLE 
>> (or with
>> the special treatment described above for asynchronous calls) 
>> with the
>> exception of saLogFinalize(), which is used to free the library 
>> handles and
>> all resources associated with these handles. Hence, it is 
>> recommended for
>> the processes to finalize the library handles as soon as the 
>> processes
>> detect that the node left the membership.
>>
>> Detailed README will be provide soon.
>>
>> Following are expected Log Service API behavior :
>>
>> Case1: On Non-Member Node, Log Service API will fail with code
>> SA_AIS_ERR_UNAVAILABLE (31) Case2: On Member Node after recovered 
>> from Non-
>> Member Node, Log Service API will fail with code 
>> SA_AIS_ERR_UNAVAILABLE (31)
>> Case3: Non-Member Node + (Headless) Log Service API will fail 
>> with code
>> SA_AIS_ERR_UNAVAILABLE (31) Case4: On Non-Member Node + 
>> (Headless) + (Head
>> Joined) Log Service API will fail with code 
>> SA_AIS_ERR_UNAVAILABLE (31)
>>
>> changeset dc881a3c478480e44bb163e75a463baaa9430482
>> Author:A V Mahesh 
>> Date:Tue, 02 Aug 2016 10:42:11 +0530
>>
>> lgs: director Cluster Membership (CLM) integration [#1638] V2
>>
>> changeset 1742284de46e241c2785744399830017b64ba3df
>> Author:A V Mahesh 
>> Date:Tue, 02 Aug 2016 10:42:58 +0530
>>
>> logtest: change related to Cluster Membership (CLM) integration 
>> [#1638] V2
>> Test :
>>
>>  #amf-adm lock safNode=PL-4,safCluster=myClmCluster
>>
>>   failed with code SA_AIS_ERR_UNAVAILABLE (31).
>>
>> #amf-adm unlock safNode=PL-4,safCluster=myClmCluster
>>
>>   failed with code SA_AIS_ERR_UNAVAILABLE (31).
>>
>>  #amf-adm lock safNode=PL-4,safCluster=myClmCluster + (SC-1 & Sc-2
>> /etc/init.d/opensafd stop)
>>
>>   failed with code SA_AIS_ERR_UNAVAILABLE (31)
>>
>> # amf-adm lock safNode=PL-4,safCluster=myClmCluster + ((SC-1 & Sc-2
>> /etc/init.d/opensafd stop)) + ((SC-1 & Sc-2 /etc/init.d/opensafd
>> start) + amf-adm unlock safNode=PL-4,safCluster=myClmCluster
>>
>>   failed with code SA_AIS_ERR_UNAVAILABLE (31)
>>
>>  Expected but currently The Imm APIs are NOT working error -
>> saImmOmInitialize FAILED: SA_AIS_ERR_LIBRARY (2)
>>
>>
>> Complete diffstat:
>> --
>>   osaf/libs/agents/saf/lga/lga.h |2 +
>>   osaf/libs/agents/saf/lga/lga_api.c |   47 
>> +

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

2016-08-02 Thread Anders Widell 
Hi Mahesh!

The files lgs_clm.cc and lgs_clm.h seem to be missing in these patches. 
Could you please resend?

thanks,

Anders Widell

On 08/02/2016 07:18 AM, mahesh.va...@oracle.com wrote:
> Summary:lga: agent Cluster Membership (CLM) integration [#1638] V2
> Review request for Trac Ticket(s): #1638
> Peer Reviewer(s):Vu, Lennart,Anders Widell
> Pull request to: <>
> Affected branch(es): default
> Development branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesn
>   OpenSAF servicesy
>   Core libraries  n
>   Samples n
>   Tests   y
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>   <>
>
> changeset d7c494e940160d474a89dbafbc2cbf058678
> Author:   A V Mahesh 
> Date: Tue, 02 Aug 2016 10:41:21 +0530
>
>   lga: agent Cluster Membership (CLM) integration [#1638] V2
> 
>  V2 patch:
>
>   Incorporated Anders Widell and Vu review comments , for more details
>   see the review comments posted on V1 patch. Description:
>
>   Form CLM integration is supported from Log Service A.02.02.
>
>   At-least a A.02.02 LGA client will check CLM membership status of 
> client's
>   node. old LGA clients A.02.01 are always clm member.
>
>   This patch enhanced the log service for Unavailability of the Log 
> Service
>   API on a Non-Member Node which will fail with SA_AIS_ERR_UNAVAILABLE.
>
>   After this patch the Log Service does not provide service to processes 
> on
>   cluster nodes that are not in the cluster membership.
>
>   If the node rejoins the cluster membership, processes executing on the 
> node
>   will be able to reinitialize new library handles and use the entire set 
> of
>   Log Service APIs that operate on these new handles; however, invocation 
> of
>   APIs that operate on handles acquired by any process before the node 
> left
>   the membership will continue to fail with SA_AIS_ERR_UNAVAILABLE (or 
> with
>   the special treatment described above for asynchronous calls) with the
>   exception of saLogFinalize(), which is used to free the library handles 
> and
>   all resources associated with these handles. Hence, it is recommended 
> for
>   the processes to finalize the library handles as soon as the processes
>   detect that the node left the membership.
>
>   Detailed README will be provide soon.
>
>   Following are expected Log Service API behavior :
>
>   Case1: On Non-Member Node, Log Service API will fail with code
>   SA_AIS_ERR_UNAVAILABLE (31) Case2: On Member Node after recovered from 
> Non-
>   Member Node, Log Service API will fail with code SA_AIS_ERR_UNAVAILABLE 
> (31)
>   Case3: Non-Member Node + (Headless) Log Service API will fail with code
>   SA_AIS_ERR_UNAVAILABLE (31) Case4: On Non-Member Node + (Headless) + 
> (Head
>   Joined) Log Service API will fail with code SA_AIS_ERR_UNAVAILABLE (31)
>
> changeset dc881a3c478480e44bb163e75a463baaa9430482
> Author:   A V Mahesh 
> Date: Tue, 02 Aug 2016 10:42:11 +0530
>
>   lgs: director Cluster Membership (CLM) integration [#1638] V2
>
> changeset 1742284de46e241c2785744399830017b64ba3df
> Author:   A V Mahesh 
> Date: Tue, 02 Aug 2016 10:42:58 +0530
>
>   logtest: change related to Cluster Membership (CLM) integration [#1638] 
> V2
>   Test :
>
>#amf-adm lock safNode=PL-4,safCluster=myClmCluster
>
> failed with code SA_AIS_ERR_UNAVAILABLE (31).
>
>   #amf-adm unlock safNode=PL-4,safCluster=myClmCluster
>
> failed with code SA_AIS_ERR_UNAVAILABLE (31).
>
>#amf-adm lock safNode=PL-4,safCluster=myClmCluster + (SC-1 & Sc-2
>   /etc/init.d/opensafd stop)
>
> failed with code SA_AIS_ERR_UNAVAILABLE (31)
>
>   # amf-adm lock safNode=PL-4,safCluster=myClmCluster + ((SC-1 & Sc-2
>   /etc/init.d/opensafd stop)) + ((SC-1 & Sc-2 /etc/init.d/opensafd
>   start) + amf-adm unlock safNode=PL-4,safCluster=myClmCluster
>
> failed with code SA_AIS_ERR_UNAVAILABLE (31)
>
>Expected but currently The Imm APIs are NOT working error -
>   saImmOmInitialize FAILED: SA_AIS_ERR_LIBRARY (2)
>
>
> Complete diffstat:
> --
>   osaf/libs/agents/saf/lga/lga.h |2 +
>   osaf/libs/agents/saf/lga/lga_api.c |   47 
> +
>   osaf/libs/agents/saf/lga/lga_mds.c |   69 
> ++
>   osaf/libs/agents/saf/lga/lga_util.c|2 +
>