Re: [devel] [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912]
ack from me. On 17/08/18 10:00, Gary Lee wrote: > All callers of Consensus::Demote() already log an error if the return code is > not SA_AIS_OK. > A warning message will suffice. > --- > src/osaf/consensus/consensus.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/osaf/consensus/consensus.cc b/src/osaf/consensus/consensus.cc > index 2a8e9bb1c..dc5c9bc46 100644 > --- a/src/osaf/consensus/consensus.cc > +++ b/src/osaf/consensus/consensus.cc > @@ -142,7 +142,7 @@ SaAisErrorT Consensus::Demote(const std::string& node) { >} > >if (rc != SA_AIS_OK) { > -LOG_ER("Unlock failed (%u)", rc); > +LOG_WA("Unlock failed (%u)", rc); > return rc; >} > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912]
Ack, (code review only)/Thanks Hans -Original Message- From: Gary Lee Sent: den 17 augusti 2018 02:00 To: Hans Nordebäck ; Minh Hon Chau ; Anders Widell Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912] All callers of Consensus::Demote() already log an error if the return code is not SA_AIS_OK. A warning message will suffice. --- src/osaf/consensus/consensus.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/osaf/consensus/consensus.cc b/src/osaf/consensus/consensus.cc index 2a8e9bb1c..dc5c9bc46 100644 --- a/src/osaf/consensus/consensus.cc +++ b/src/osaf/consensus/consensus.cc @@ -142,7 +142,7 @@ SaAisErrorT Consensus::Demote(const std::string& node) { } if (rc != SA_AIS_OK) { -LOG_ER("Unlock failed (%u)", rc); +LOG_WA("Unlock failed (%u)", rc); return rc; } -- 2.17.1 -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel