Re: [devel] [PATCH 11 of 16] base: Removed unused macros from ncs_osprm.h, ncssysf_def.h and os_defs.h files [#537]

[Anders Widell]

There are printf() and fprintf() calls in this code:

2013-12-05 13:51, ramesh.bet...@oracle.com skrev:
 + printf(\nMQSV:MQD:ON);
   if (mqd_lib_req(lib_create) != NCSCC_RC_SUCCESS) {
   fprintf(stderr, mqd_lib_req FAILED\n);
Since stdout and stderr are redirected to /dev/null in all OpenSAF 
services, these should be removed. Or if they are relevant, the printf's 
can be converted to TRACE() and the fprintf's to LOG_ER().

regards,
Anders Widell


--
Sponsored by Intel(R) XDK 
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631iu=/4140/ostg.clktrk
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 11 of 16] base: Removed unused macros from ncs_osprm.h, ncssysf_def.h and os_defs.h files [#537]

[Anders Widell]

I get the following build error in PLM:

plms_dbg_utils.c: In function ‘plms_cb_dump_routine’:
plms_dbg_utils.c:50:2: error: implicit declaration of function 
‘m_GET_ASCII_DATE_TIME_STAMP’ [-Werror=implicit-function-declaration]

regards,
Anders Widell

2013-12-05 13:51, ramesh.bet...@oracle.com skrev:
   osaf/libs/agents/saf/cpa/cpa_init.c   |2 +-
   osaf/libs/agents/saf/mqa/mqa_init.c   |2 +-
   osaf/libs/agents/saf/plma/plma_init.c |2 +-
   osaf/libs/core/include/ncs_osprm.h|   26 +
   osaf/libs/core/include/ncssysf_def.h  |  103 
 +
   osaf/libs/core/include/os_defs.h  |   48 +-
   osaf/libs/core/leap/sysf_def.c|  122 
 
   osaf/libs/core/mds/include/mds_dt.h   |1 -
   osaf/services/infrastructure/dtms/dtm/dtm_intra.c |1 -
   osaf/services/infrastructure/dtms/include/dtm.h   |1 -
   osaf/services/saf/cpsv/cpd/cpd_main.c |2 +-
   osaf/services/saf/cpsv/cpnd/cpnd_main.c   |2 +-
   osaf/services/saf/mqsv/mqd/mqd_main.c |2 +-
   osaf/services/saf/mqsv/mqnd/mqnd_main.c   |2 +-
   14 files changed, 14 insertions(+), 302 deletions(-)


 diff --git a/osaf/libs/agents/saf/cpa/cpa_init.c 
 b/osaf/libs/agents/saf/cpa/cpa_init.c
 --- a/osaf/libs/agents/saf/cpa/cpa_init.c
 +++ b/osaf/libs/agents/saf/cpa/cpa_init.c
 @@ -297,7 +297,7 @@ unsigned int ncs_cpa_startup(void)
   osaf_mutex_unlock_ordie(s_agent_startup_mutex);
   return m_LEAP_DBG_SINK(NCSCC_RC_FAILURE);
   } else {
 - m_NCS_DBG_PRINTF(\nCPSV:CPA:ON);
 + printf(\nCPSV:CPA:ON);
   cpa_use_count = 1;
   }
   
 diff --git a/osaf/libs/agents/saf/mqa/mqa_init.c 
 b/osaf/libs/agents/saf/mqa/mqa_init.c
 --- a/osaf/libs/agents/saf/mqa/mqa_init.c
 +++ b/osaf/libs/agents/saf/mqa/mqa_init.c
 @@ -988,7 +988,7 @@ unsigned int ncs_mqa_startup(void)
   osaf_mutex_unlock_ordie(s_agent_startup_mutex);
   return m_LEAP_DBG_SINK(NCSCC_RC_FAILURE);
   } else {
 - m_NCS_DBG_PRINTF(\nMQSV:MQA:ON);
 + printf(\nMQSV:MQA:ON);
   mqa_use_count = 1;
   }
   
 diff --git a/osaf/libs/agents/saf/plma/plma_init.c 
 b/osaf/libs/agents/saf/plma/plma_init.c
 --- a/osaf/libs/agents/saf/plma/plma_init.c
 +++ b/osaf/libs/agents/saf/plma/plma_init.c
 @@ -355,7 +355,7 @@ uint32_t ncs_plma_startup()
   return m_LEAP_DBG_SINK(NCSCC_RC_FAILURE);
   }else{
   /** Initialize the library for the first time */
 - m_NCS_DBG_PRINTF(\nPLMSV:PLMA:ON);
 + printf(\nPLMSV:PLMA:ON);
   plma_use_count = 1;
   }
   osaf_mutex_unlock_ordie(s_agent_startup_mutex);
 diff --git a/osaf/libs/core/include/ncs_osprm.h 
 b/osaf/libs/core/include/ncs_osprm.h
 --- a/osaf/libs/core/include/ncs_osprm.h
 +++ b/osaf/libs/core/include/ncs_osprm.h
 @@ -143,22 +143,15 @@ extern C {
   } NCS_OS_TASK_REQUEST;
   
   
 /
 - 
 - 
 - 
 - ****
**
 **
** Lock Interface Primitives  
 **
**
 **
** This interface is used by the client to control access to data or  
 **
 - ** other shared resources. The interface utilizes the typedef NCS_OS_LOCK  
 **
 - ** for processing object access requests. The NCS_OS_LOCK typedef is   
 **
 + ** other shared resources. The interface utilizes the typedef NCS_OS_LOCK **
 + ** for processing object access requests. The NCS_OS_LOCK typedef is  **
** DEFINED BY THE TARGET SYSTEM in any manner necessary to carry the  
 **
** information needed to implement the interface. 
 **
**
 **
 - 
 - 
 - 

 ***/
   
   
 /
 @@ -805,21 +798,6 @@ uint32_t ncs_os_posix_mq(NCS_OS_POSIX_MQ

 /
   #define