[tickets] [opensaf:tickets] #2409 amf: Issues with the printing of CLC CLI command environment variables in traces

2017-04-12 Thread Nguyen TK Luu 
- **Milestone**: future --> 5.17.06



---

** [tickets:#2409] amf: Issues with the printing of CLC CLI command environment 
variables in traces**

**Status:** assigned
**Milestone:** 5.17.06
**Created:** Mon Apr 03, 2017 07:07 AM UTC by Nguyen TK Luu
**Last Updated:** Mon Apr 03, 2017 07:07 AM UTC
**Owner:** Nguyen TK Luu


There are following 2 issues with the printing of CLC CLI command environment 
variables of a component in amfnd traces:
- Environment variables set in both CompType and Comp got doubly printed.
- Environment variables with incorrect format (i.e not 'var=value') got printed 
with weird output.

Reproduce using amf_demo testapp with the following set of environment 
variables:

safVersion=1,safCompType=AmfDemo1
...

  saAmfCtDefCmdEnv
  AMF_DEMO_VAR1=CT_VALUE1
  AMF_DEMO_VAR2=CT_VALUE2




 safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1
 ...
 
   saAmfCompCmdEnv
   AMF_DEMO_VAR2=COMP1_OVERLOAD_VALUE2
   AMF_DEMO_VAR3
   AMF_DEMO_VAR4 = COMP1_VALUE4
 


Apr  3 13:21:15.680056 osafamfnd [290:290:src/amf/amfnd/clc.cc:2927] >> 
avnd_comp_clc_cmd_execute: 
'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1':CLC CLI command 
type:'AVND_COMP_CLC_CMD_TYPE_INSTANTIATE(1)'
Apr  3 13:21:15.680147 osafamfnd [290:290:src/amf/amfnd/clc.cc:2984] ER Unknown 
enviroment variable format 'AMF_DEMO_VAR3'. Should be 'var=value'
Apr  3 13:21:15.680168 osafamfnd [290:290:src/amf/amfnd/clc.cc:3091] T1 CLC CLI 
script:'/opt/amf_demo/amf_demo_script'
Apr  3 13:21:15.680173 osafamfnd [290:290:src/amf/amfnd/clc.cc:3093] T1 CLC CLI 
command arguments[1] ='instantiate'
Apr  3 13:21:15.680176 osafamfnd [290:290:src/amf/amfnd/clc.cc:3096] T1 CLC CLI 
command timeout: In nano secs:100 In milli secs: 1
Apr  3 13:21:15.680180 osafamfnd [290:290:src/amf/amfnd/clc.cc:3100] T1 CLC CLI 
command env variable name = 'AMF_DEMO_VAR2': value ='CT_VALUE2'
Apr  3 13:21:15.680183 osafamfnd [290:290:src/amf/amfnd/clc.cc:3100] T1 CLC CLI 
command env variable name = 'AMF_DEMO_VAR1': value ='CT_VALUE1'
Apr  3 13:21:15.680187 osafamfnd [290:290:src/amf/amfnd/clc.cc:3100] T1 CLC CLI 
command env variable name = 'AMF_DEMO_VAR4 ': value =' COMP1_VALUE4'
Apr  3 13:21:15.680191 osafamfnd [290:290:src/amf/amfnd/clc.cc:3100] T1 CLC CLI 
command env variable name = '(null)': value ='(null)'
Apr  3 13:21:15.680194 osafamfnd [290:290:src/amf/amfnd/clc.cc:3100] T1 CLC CLI 
command env variable name = 'AMF_DEMO_VAR2': value ='COMP1_OVERLOAD_VALUE2'
Apr  3 13:21:15.680197 osafamfnd [290:290:src/amf/amfnd/clc.cc:3100] T1 CLC CLI 
command env variable name = 'SA_AMF_COMPONENT_NAME': value 
='safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1'
Apr  3 13:21:15.680455 osafamfnd [290:290:src/amf/amfnd/clc.cc:3132] T2 The CLC 
CLI command execution success
Apr  3 13:21:15.680505 osafamfnd [290:290:src/amf/amfnd/clc.cc:3136] T2 success
Apr  3 13:21:15.680511 osafamfnd [290:290:src/amf/amfnd/clc.cc:3145] << 
avnd_comp_clc_cmd_execute: 1




---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2410 samples: amf_demo_script missed to define $piddir

2017-04-12 Thread Gary Lee 
- **status**: assigned --> review
- **Milestone**: future --> 5.17.06



---

** [tickets:#2410] samples: amf_demo_script missed to define $piddir**

**Status:** review
**Milestone:** 5.17.06
**Created:** Mon Apr 03, 2017 11:43 AM UTC by Nguyen TK Luu
**Last Updated:** Mon Apr 03, 2017 11:44 AM UTC
**Owner:** Nguyen TK Luu


The $piddir variable (containing path to amf_demo component's pid file) is 
missed to be defined in amf_demo_script. This could lead to the amf_demo 
process not getting truely killed in some cases when cleanup is called (e.g 
when invoking saAmfComponentErrorReport()), leaving the process unmanaged by 
AMF.

~~~
samples/amf/sa_aware/amf_demo_script:

# Source LSB functions library
. /lib/lsb/init-functions

compname=`echo $SA_AMF_COMPONENT_NAME | md5sum | awk '{print $1}'`
pidfile="$piddir/${compname}.pid"

stop()
{
echo -n "Stopping $prog: "
killproc -p $pidfile $binary
RETVAL=$?
if [ $RETVAL -ne 0 ]; then
logger -st $name "killproc $binary failed"
fi
return $RETVAL
}
~~~


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2425 lck: implement saLckLimitGet

2017-04-12 Thread Alex Jones 



---

** [tickets:#2425] lck: implement saLckLimitGet**

**Status:** accepted
**Milestone:** 5.17.08
**Created:** Wed Apr 12, 2017 05:04 PM UTC by Alex Jones
**Last Updated:** Wed Apr 12, 2017 05:04 PM UTC
**Owner:** Alex Jones


This ticket is an enhancement to LCK to add saLckLimitGet function.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced

2017-04-12 Thread Rafael 
- **Component**: unknown --> smf



---

** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced**

**Status:** unassigned
**Milestone:** 5.2.0
**Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen
**Last Updated:** Mon Apr 10, 2017 08:09 PM UTC
**Owner:** nobody


Previous behavior:
The behavior was to ignore a fail to activate a component unless any secondary 
fault happened. This means that it was for example possible to complete a 
campaign even if a component failed to start and fix this problem after 
committing. No action to resume the campaign was needed.

After [#2145]:
The campaign will always suspend in case of component fail and a resume must be 
requested for the campaign to continue.

NBC:
The behavior has changed in such a way that it must be seen as a NBC. The #2145 
ticket corrects SMF behavior regarding AIS but is still NBC since the previous 
behavior is the legacy behavior in previous releases.

Proposal 1; Fix if not needed to change setting in runtime e.g. during an 
upgrade
Add a new configuration attribute to the SMF configuration class that makes it 
possible to select whether the behavior after #2145 shall be used or not. The 
default setting must be the previous behavior.
The setting must have the following properties:
- If the attribute does not exist (old model)   legacy behavior
- If the attribute value is not changed from defaultlegacy behavior
- If the attribute value is  or invalid  legacy behavior
- If the attribute value is a valid “ON” settingnew behavior
- A request to change the attribute in runtime shall always be rejected

Proposal 2; Fix if change has to be made during upgrade:
Add a new configuration attribute to the SMF configuration class that makes it 
possible to select whether the behavior after #2145 shall be used or not. The 
default setting must be the previous behavior.
The setting must have the following properties:
- If the attribute does not exist (old model)   legacy behavior
- If the attribute value is not changed from defaultlegacy behavior
- If the attribute value is  or invalid  legacy behavior
- If the attribute value is a valid “ON” settingnew behavior
- Attribute value must be possible to change in runtime in “idle” state (no 
campaign is executing)
- Attribute value must be possible to change in runtime in campaign init state. 
Note that if changed here
  the new setting must be used in the rest of the campaign



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2424 amfnd: illegal memory access in avnd_comptype_delete()

2017-04-12 Thread Hoa Le 
- **status**: assigned --> review



---

** [tickets:#2424] amfnd: illegal memory access in avnd_comptype_delete()**

**Status:** review
**Milestone:** 5.17.06
**Created:** Wed Apr 12, 2017 04:08 AM UTC by Hoa Le
**Last Updated:** Wed Apr 12, 2017 04:08 AM UTC
**Owner:** Hoa Le
**Attachments:**

- 
[bt_core.1491307159.osafamfnd.428.PL-5](https://sourceforge.net/p/opensaf/tickets/2424/attachment/bt_core.1491307159.osafamfnd.428.PL-5)
 (12.3 kB; application/octet-stream)


There are some unsafe memory accesses in avnd_comptype_delete() function. This 
caused segfault as in attachment.

~~~
/src/amf/amfnd/compdb.cc

static amf_comp_type_t *avnd_comptype_create(SaImmHandleT immOmHandle, const 
std::string& dn)
{
int rc = -1;
...
if (amf_saImmOmAccessorGet_o2(immOmHandle, accessorHandle, dn, nullptr, 
(SaImmAttrValuesT_2 ***)) != SA_AIS_OK) {
LOG_ER("amf_saImmOmAccessorGet_o2 FAILED for '%s'", dn.c_str());
goto done;
}
...
 done:
if (rc != 0) {
avnd_comptype_delete(compt);
compt = nullptr;
}
...
}

static void avnd_comptype_delete(amf_comp_type_t *compt)
{
...
/* Free saAmfCtDefInstantiateCmdArgv[i] before freeing 
saAmfCtDefInstantiateCmdArgv */
arg_counter = 0;
while ((argv = compt->saAmfCtDefInstantiateCmdArgv[arg_counter++]) != 
nullptr)
...
}
~~~

In this case, compt->saAmfCtDefInstantiateCmdArgv was NULL, accessing to 
compt->saAmfCtDefInstantiateCmdArgv[arg_counter++]) caused a segmentation fault.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2367 imm: Improve ccb error string handling

2017-04-12 Thread Hieu Nguyen 
- **status**: accepted --> assigned
- **assigned_to**: Hung Nguyen --> Hieu Nguyen



---

** [tickets:#2367] imm: Improve ccb error string handling**

**Status:** assigned
**Milestone:** 5.17.08
**Created:** Mon Mar 13, 2017 03:34 AM UTC by Hung Nguyen
**Last Updated:** Mon Apr 10, 2017 01:40 PM UTC
**Owner:** Hieu Nguyen


* Use ::setCcbErrorString in ::ccbObjDelContinuation 
and::ccbCompletedContinuation instead of working directly with 
ccb->mErrorStrings

* Only store error strings on originating node where OM client resides.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

[tickets] [opensaf:tickets] #2408 IMM: Fix cppcheck 1.78 memory leak error at tools

2017-04-12 Thread Hung Nguyen 
- **status**: review --> fixed
- **Comment**:

develop [code:021003]

commit 021003cbe581ae0eebd29981a2654f6f1f7f3095
Author: Hieu Nguyen 
Date:   Wed Apr 12 12:45:53 2017 +0700
imm: Fixed memory leak in imm_cfg.c [#2408]
Fixed memory leak in unique_admiOwner() function of imm_cfg.c file


release [code:8d7687]
~~~
commit 8d76876f236e4116bcca9a2f7ee67e6f1dfc7ae8
Author: Hieu Nguyen 
Date:   Wed Apr 12 12:45:53 2017 +0700

imm: Fixed memory leak in imm_cfg.c [#2408]

Fixed memory leak in unique_admiOwner() function of imm_cfg.c file
~~~

default (hg) [staging:69b0ff]
~~~
changeset:   8762:69b0ffd9694b
user:Hieu Nguyen 
date:Wed Apr 12 13:26:51 2017 +0700
summary: imm: Fixed memory leak in imm_cfg.c file [#2408]
~~~




---

** [tickets:#2408] IMM: Fix cppcheck 1.78 memory leak error at tools**

**Status:** fixed
**Milestone:** 5.17.08
**Created:** Mon Apr 03, 2017 02:16 AM UTC by Hieu Nguyen
**Last Updated:** Mon Apr 10, 2017 01:40 PM UTC
**Owner:** Hieu Nguyen


opensaf-staging/src/imm/tools/imm_cfg.c:861]: (error) Memory leak: 
unique_adminOwner


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets