[tickets] [opensaf:tickets] #2438 log: generate hash only if having destination name set

2017-04-25 Thread Vu Minh Nguyen
- **status**: accepted --> review
- **Comment**:

https://sourceforge.net/u/winhvu/review/ci/6b39e32bffb2c7fb6442c63d9accf8e9423603de



---

** [tickets:#2438] log: generate hash only if having destination name set**

**Status:** review
**Milestone:** 5.17.06
**Created:** Tue Apr 25, 2017 02:12 PM UTC by Vu Minh Nguyen
**Last Updated:** Tue Apr 25, 2017 02:12 PM UTC
**Owner:** Vu Minh Nguyen


`rfc5424_msgid` is only referred when streaming and having destination name set 
on that log stream. It means it does meaningless job sometimes, that is do hash 
calculation even there is no destination name set. 

This ticket will fix that.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2436 amfnd: Buffered messages are unexpectedly deleted during SC Absence period

2017-04-25 Thread Minh Hon Chau
- **status**: assigned --> review



---

** [tickets:#2436] amfnd: Buffered messages are unexpectedly deleted during SC 
Absence period**

**Status:** review
**Milestone:** 5.17.06
**Created:** Mon Apr 24, 2017 10:58 AM UTC by Minh Hon Chau
**Last Updated:** Mon Apr 24, 2017 10:58 AM UTC
**Owner:** Minh Hon Chau


Stop both SCs so that cluster goes into headless. Trigger a su failover, so 
su_oper message is buffered and supposedly will be sent to active amfd when SC 
comes back. However, if cluster is waiting up to 3 mins, which is exactly the 
MDS_AWAIT_ACTIVE_TMR_VAL timeout, amfnd will receive another NCSMDS_DOWN. At 
this time, amfnd will delete all pending messages, which causes the headless 
recovery impossible.

Some outline logs:
~~~
Apr 18 16:49:09.749428 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:0603] >> avnd_evt_mds_avd_dn_evh 
Apr 18 16:49:09.750094 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:0618] WA AMF director 
unexpectedly crashed
Apr 18 16:49:09.750103 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:0662] TR Delete all pending 
messages to be sent to AMFD

Apr 18 16:49:09.796138 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:0756] NO avnd_di_oper_send() 
deferred as AMF director is offline(1), or sync is required(1)

Apr 18 16:49:09.797440 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:0756] NO avnd_di_oper_send() 
deferred as AMF director is offline(1), or sync is required(1)

Apr 18 16:52:09.825457 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:0603] >> avnd_evt_mds_avd_dn_evh 
Apr 18 16:52:09.825489 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:0618] WA AMF director 
unexpectedly crashed
Apr 18 16:52:09.825495 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:0662] TR Delete all pending 
messages to be sent to AMFD
Apr 18 16:52:09.825498 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:1273] >> avnd_diq_rec_del 
Apr 18 16:52:09.825505 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:1290] << avnd_diq_rec_del 
Apr 18 16:52:09.825508 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:1273] >> avnd_diq_rec_del 
Apr 18 16:52:09.825512 osafamfnd 
[10775:10775:../../opensaf/src/amf/amfnd/di.cc:1290] << avnd_diq_rec_del 
~~~


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #1969 smf: One step upgrade with cluster reboot does not wait for nodes to start

2017-04-25 Thread Rafael Odzakow
- **status**: review --> fixed
- **Blocker**:  --> False
- **Comment**:

pushed to develop with commit f9149b49420d989b6ffcaf0f3553c5452e7e2302



---

** [tickets:#1969] smf: One step upgrade with cluster reboot does not wait for 
nodes to start**

**Status:** fixed
**Milestone:** 5.17.06
**Created:** Wed Aug 24, 2016 01:01 PM UTC by elunlen
**Last Updated:** Thu Apr 20, 2017 03:00 PM UTC
**Owner:** Rafael Odzakow


When using the one step upgrade feature with a cluster reboot all nodes will 
restart including the SC-nodes. This is done as the last action in the upgrade 
step. After the active SC-node is up again SMF will continue with the procedure 
wrapup. When collecting information in order to prepare the wrapup the node 
destination for all nodes in the campaign is requested. However this 
information can only be collected from nodes that are started and has joined 
the cluster (unlocked).
The problem is that SMF does not seems wait in order to give all nodes a chance 
to join the cluster and if SMF fails to get node destination from any of the 
nodes the campaign will fail as seen in the log below. When reading node 
destination there is a 10 sec “try again” loop waiting for “node up” for each 
node. It is not unlikely that the active SC-node comes up before some of the 
other nodes and that it will take more than 10 sec after that before some of 
the other nodes joins the cluster. If that's the case the campaign will fail


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2430 lck: resources can deadlock after master glnd restart

2017-04-25 Thread Alex Jones
- **status**: review --> fixed
- **Blocker**:  --> False
- **Comment**:

commit e7482750832c7f002730667e0521d41cac6ae77c
Author: Alex Jones 
Date:   Tue Apr 25 11:05:07 2017 -0400




---

** [tickets:#2430] lck: resources can deadlock after master glnd restart**

**Status:** fixed
**Milestone:** 5.17.08
**Created:** Mon Apr 17, 2017 07:57 PM UTC by Alex Jones
**Last Updated:** Tue Apr 18, 2017 03:07 PM UTC
**Owner:** Alex Jones


Exclusive locks can deadlock after master glnd restarts. In a 6 node cluster, 
with each node attempting to access one global exclusive lock, and holding it 
for 1 sec -- if the master glnd is killed, these locks can deadlock.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2438 log: generate hash only if having destination name set

2017-04-25 Thread Vu Minh Nguyen



---

** [tickets:#2438] log: generate hash only if having destination name set**

**Status:** accepted
**Milestone:** 5.17.06
**Created:** Tue Apr 25, 2017 02:12 PM UTC by Vu Minh Nguyen
**Last Updated:** Tue Apr 25, 2017 02:12 PM UTC
**Owner:** Vu Minh Nguyen


`rfc5424_msgid` is only referred when streaming and having destination name set 
on that log stream. It means it does meaningless job sometimes, that is do hash 
calculation even there is no destination name set. 

This ticket will fix that.


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] Re: #2419 smf: when fixing ticket #2145 a NBC problem was introduced

2017-04-25 Thread Rafael Odzakow
I consider the AMF objects as an interface and some external code outside of 
OpenSAF might be reading that campaignDN attribute.


---

** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced**

**Status:** wontfix
**Milestone:** 5.2.0
**Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen
**Last Updated:** Mon Apr 24, 2017 07:53 PM UTC
**Owner:** nobody


Previous behavior:
The behavior was to ignore a fail to activate a component unless any secondary 
fault happened. This means that it was for example possible to complete a 
campaign even if a component failed to start and fix this problem after 
committing. No action to resume the campaign was needed.

After [#2145]:
The campaign will always suspend in case of component fail and a resume must be 
requested for the campaign to continue.

NBC:
The behavior has changed in such a way that it must be seen as a NBC. The #2145 
ticket corrects SMF behavior regarding AIS but is still NBC since the previous 
behavior is the legacy behavior in previous releases.

Proposal 1; Fix if not needed to change setting in runtime e.g. during an 
upgrade
Add a new configuration attribute to the SMF configuration class that makes it 
possible to select whether the behavior after #2145 shall be used or not. The 
default setting must be the previous behavior.
The setting must have the following properties:
- If the attribute does not exist (old model)   legacy behavior
- If the attribute value is not changed from defaultlegacy behavior
- If the attribute value is  or invalid  legacy behavior
- If the attribute value is a valid “ON” settingnew behavior
- A request to change the attribute in runtime shall always be rejected

Proposal 2; Fix if change has to be made during upgrade:
Add a new configuration attribute to the SMF configuration class that makes it 
possible to select whether the behavior after #2145 shall be used or not. The 
default setting must be the previous behavior.
The setting must have the following properties:
- If the attribute does not exist (old model)   legacy behavior
- If the attribute value is not changed from defaultlegacy behavior
- If the attribute value is  or invalid  legacy behavior
- If the attribute value is a valid “ON” settingnew behavior
- Attribute value must be possible to change in runtime in “idle” state (no 
campaign is executing)
- Attribute value must be possible to change in runtime in campaign init state. 
Note that if changed here
  the new setting must be used in the rest of the campaign



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #2412 log: refactor handling log client database in log agent

2017-04-25 Thread Vu Minh Nguyen
Second increment just sent out for review.

Here is the link of code changes/added:
https://sourceforge.net/u/winhvu/review/ci/a7a081176b9b0a6730c7769f14d53d090300dd54/




---

** [tickets:#2412] log: refactor handling log client database in log agent**

**Status:** review
**Milestone:** 5.17.08
**Created:** Tue Apr 04, 2017 12:08 PM UTC by Canh Truong
**Last Updated:** Mon Apr 24, 2017 07:37 AM UTC
**Owner:** Vu Minh Nguyen


In log agent, there is a link list holding all log clients of an application 
process. Also, in each log client, there is an additional link list holding all 
log streams which belongs to each log client.

Adding, modifying or deleing the link lists' elements or on sub-items of the 
client dabases are distrubuted in a lot of places, this could easily cause 
troubles regarding race condition, deadlock, or risks when adding code that do 
changes the databases.

So, this ticket intends to remove that concern by doing:
1) Centralizing read/write accesses to the database to one place with its 
private mutex
2) Use C++ containters to contain and handle databases

And will push the ticket in 02 increments:
1) Convert agent code to C++ without touching any existing logic (looks like 
what AMF has done it in [#1673])
2) Do #1 and #2 above


---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets