[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2016-08-19 Thread Zoran Milinkovic
- **status**: review --> fixed
- **Comment**:

default(5.1):

changeset:   7888:726ef6b3bd82
tag: tip
user:Zoran Milinkovic 
date:Thu Aug 18 14:00:59 2016 +0200
summary: imm: fix string format for size_t type [#195]



---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** fixed
**Milestone:** 5.1.FC
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Thu Aug 18, 2016 12:14 PM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2016-08-18 Thread Zoran Milinkovic
- **status**: fixed --> review
- **Comment**:

IMM cannot be compiled with 32-bit compiler after applying the patch.

~~~
make[7]: Entering directory 
`/local/scratch/emilzor/sf/opensaf-default-build/osaf/services/saf/immsv/immnd'
  CXX  osafimmnd-ImmModel.o
In file included from ../../../../../osaf/libs/core/include/ncs_osprm.h:32:0,
 from ../../../../../osaf/libs/core/include/ncs_lib.h:39,
 from ../../../../../osaf/libs/common/immsv/include/immsv.h:30,
 from immnd.h:31,
 from ImmSearchOp.hh:26,
 from ImmModel.cc:24:
ImmModel.cc: In member function ‘bool ImmModel::verifySchemaChange(const 
string&, ClassInfo*, ClassInfo*, AttrMap&, AttrMap&)’:
../../../../../osaf/libs/core/common/include/logtrace.h:131:95: error: format 
‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type 
‘std::map, ClassInfo*>::size_type {aka unsigned int}’ 
[-Werror=format=]
 #define LOG_NO(format, args...) _logtrace_log(__FILE__, __LINE__, LOG_NOTICE, 
(format), ##args)

   ^
ImmModel.cc:4178:25: note: in expansion of macro ‘LOG_NO’
 LOG_NO("The Number of classes in the cluster %lu 
greater than the schema change"
 ^
../../../../../osaf/libs/core/common/include/logtrace.h:131:95: error: format 
‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type 
‘std::vector::size_type {aka unsigned int}’ [-Werror=format=]
 #define LOG_NO(format, args...) _logtrace_log(__FILE__, __LINE__, LOG_NOTICE, 
(format), ##args)

   ^
ImmModel.cc:4187:25: note: in expansion of macro ‘LOG_NO’
 LOG_NO("The Number of Implementers in the cluster %lu 
greater than the schema change"
 ^
../../../../../osaf/libs/core/common/include/logtrace.h:131:95: error: format 
‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type 
‘std::vector::size_type {aka unsigned int}’ [-Werror=format=]
 #define LOG_NO(format, args...) _logtrace_log(__FILE__, __LINE__, LOG_NOTICE, 
(format), ##args)

   ^
ImmModel.cc:4196:25: note: in expansion of macro ‘LOG_NO’
 LOG_NO("The Number of AdminOwners in the cluster %lu 
greater than the schema change"
 ^
../../../../../osaf/libs/core/common/include/logtrace.h:131:95: error: format 
‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type 
‘std::vector::size_type {aka unsigned int}’ [-Werror=format=]
 #define LOG_NO(format, args...) _logtrace_log(__FILE__, __LINE__, LOG_NOTICE, 
(format), ##args)

   ^
ImmModel.cc:4205:25: note: in expansion of macro ‘LOG_NO’
 LOG_NO("The Number of Ccbs in the cluster %lu greater 
than the schema change"
 ^
cc1plus: all warnings being treated as errors
make[7]: *** [osafimmnd-ImmModel.o] Error 1
make[7]: Leaving directory 
`/local/scratch/emilzor/sf/opensaf-default-build/osaf/services/saf/immsv/immnd'
make[6]: *** [all-recursive] Error 1
make[6]: Leaving directory 
`/local/scratch/emilzor/sf/opensaf-default-build/osaf/services/saf/immsv/immnd'
make[5]: *** [all-recursive] Error 1
make[5]: Leaving directory 
`/local/scratch/emilzor/sf/opensaf-default-build/osaf/services/saf/immsv'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory 
`/local/scratch/emilzor/sf/opensaf-default-build/osaf/services/saf'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory 
`/local/scratch/emilzor/sf/opensaf-default-build/osaf/services'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory 
`/local/scratch/emilzor/sf/opensaf-default-build/osaf'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/local/scratch/emilzor/sf/opensaf-default-build'
make: *** [all] Error 2
~~~



---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Wed Aug 17, 2016 07:27 AM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/

[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2016-08-17 Thread Neelakanta Reddy
- **Comment**:

changeset:   7869:dcc7de92259d
tag: tip
user:Neelakanta Reddy
date:Wed Aug 17 12:54:32 2016 +0530
summary: imm:Adding upgrade xml [#195]




---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** fixed
**Milestone:** 5.1.FC
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Wed Aug 17, 2016 06:59 AM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2016-08-17 Thread Neelakanta Reddy
- **status**: review --> fixed
- **Comment**:

changeset:   7868:f06bacfa7c3f
tag: tip
user:Neelakanta Reddy
date:Wed Aug 17 12:26:09 2016 +0530
summary: imm:Hardcode limits are changed to config parameters [#195]




---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** fixed
**Milestone:** 5.1.FC
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Wed Jul 27, 2016 08:38 AM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2016-07-27 Thread Neelakanta Reddy
- **status**: assigned --> review



---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** review
**Milestone:** 5.1.FC
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Mon Jul 04, 2016 11:46 AM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2016-07-04 Thread Neelakanta Reddy
- **Priority**: minor --> major
- **Comment**:

The enhancement alos covers adding the attributes to immobject 
opensafImm=opensafImm,safApp=safImmService



---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** assigned
**Milestone:** 5.1.FC
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Fri Jul 01, 2016 11:02 AM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2016-07-01 Thread Neelakanta Reddy
- **Milestone**: future --> 5.1.FC



---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** assigned
**Milestone:** 5.1.FC
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Tue Mar 08, 2016 05:05 AM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2016-03-08 Thread Neelakanta Reddy
- **Milestone**: 5.0.FC --> future



---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** assigned
**Milestone:** future
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Thu Dec 10, 2015 12:11 PM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://makebettercode.com/inteldaal-eval___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2015-12-10 Thread Neelakanta Reddy
- **status**: unassigned --> assigned
- **assigned_to**: Neelakanta Reddy
- **Part**: - --> nd
- **Milestone**: future --> 5.0.FC



---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** assigned
**Milestone:** 5.0.FC
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Wed Jun 19, 2013 10:03 AM UTC
**Owner:** Neelakanta Reddy


Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.--
___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets


[tickets] [opensaf:tickets] #195 IMM: Hardcoded limits should be made into config parameters

2013-06-19 Thread Anders Bjornerstedt
Some of these limits are sanity check limits and should really not
be runtime configurable. 

For example, the maximum number of parameters allowed in an admin-opertion
request (or reply) is 127. 
Sanity limits like that one are not intended to be changed.
Thay are there to protect the server side of the service from
applications that are faulty or poorly designed. 
An application reaching such a limit will contain the problem to that
application and provide a clear error indication as to the cause in the 
syslog. 

But even if such parameters are not suitable for runtime configurability,
they should be documented both in what they limit and where in the code
the limit resides. 

Some but not all of these limits reside in:
  /osaf/libs/common/immsv/include/immsv_api.h

preferably all should be moved to that file.

The documentation update will be made to osaf/services/saf/immsv/README.
A corresponding update of the OpenSAF_IMMSv_PR document will be made 
in conjunction with the relevant OpenSAF release. 


---

** [tickets:#195] IMM: Hardcoded limits should be made into config parameters**

**Status:** unassigned
**Created:** Tue May 14, 2013 09:12 AM UTC by Anders Bjornerstedt
**Last Updated:** Tue May 14, 2013 09:12 AM UTC
**Owner:** nobody

Migrated from: 
http://devel.opensaf.org/ticket/2855
-
steps:

1. Two controllers, SC-1 and SC-2.

2. Bring SC-1 up and creates more than 1000 classes

3. Bring SC-2 up, syncing will fail because the maximum supported classes in 
opensaf is 1000.

Oct 9 14:10:53 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_R_AVAILABLE
Oct 9 14:10:53 Slot-1 osafimmd[7534]: Successfully announced sync. New ruling 
epoch:3
Oct 9 14:10:53 Slot-1 immload: logtrace: trace enabled to file 
/var/log/opensaf/osafimmnd, mask=0x
Oct 9 14:10:53 Slot-1 immload: Sync starting
Oct 9 14:10:58 Slot-1 immload: Synced 350 objects in total
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: NODE STATE-> IMM_NODE_FULLY_AVAILABLE 
12197
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: TOO MANY classes line: 1673
Oct 9 14:10:58 Slot-1 immload: immsv_finalize_sync failed!
Oct 9 14:10:58 Slot-1 immload: Sync ending ABNORMALLY
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: Error code 21 returned for message type 
36 - ignoring
Oct 9 14:10:58 Slot-1 osafimmnd[7549]: SERVER STATE: IMM_SERVER_SYNC_SERVER —> 
IMM SERVER READY

The possible fix is to check the number of classes, when the class is created.
--
The problem is actually a bit more general than only the hardcoded limit
on the number of classes.

There are four hardcoded limits in:

osaf/libs/common/immsv/immsv_evt.c:

#define IMMSV_MAX_CLASSES 1000
#define IMMSV_MAX_IMPLEMENTERS 3000
#define IMMSV_MAX_ADMINOWNERS 2000
#define IMMSV_MAX_CCBS 1

All four should be moved to:
osaf/libs/common/immsv/include/immsv_api.h

Making them generally accessible to the imm server implementation code.

Then the checks on the relevant limit should be made in the relevant call in 
ImmModel?.cc

Longer term, these constants should be made into configuration parameters in the
OpenSAF-IMM configuration object.



---

Sent from sourceforge.net because you indicated interest in 


To unsubscribe from further messages, please visit 
--
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets