[tickets] [opensaf:tickets] #2697 clm: Use base::Process to execute scripts from admin-ops
- **Milestone**: 5.19.01 --> future --- ** [tickets:#2697] clm: Use base::Process to execute scripts from admin-ops** **Status:** unassigned **Milestone:** future **Created:** Tue Nov 21, 2017 05:15 PM UTC by Anders Widell **Last Updated:** Wed Jan 09, 2019 09:23 PM UTC **Owner:** nobody Refer to this mailing list post: [opensaf-devel](https://sourceforge.net/p/opensaf/mailman/message/36092893/) Instead of executing the custom script by calling system(), we should use the functionality provided in base/process.h. This is preferred because it executes the script with a well defined environment (only the PATH environment variable is set, with a fixed value). Otherwise, all environment variables from clmna will leak into the script. Any change in environment variables in clmna could then be a non-backwards compatible change, if the user defined script depends on the value of that variable. Another benefit of the base/process.h code is that it lets us specify a time-out. We ought to have a time-out for the script execution, and execute the script in a separate thread to avoid blocking the main thread in clmna. This could be implemented in a similar way as for executing the scale-out script in CLM. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2697 clm: Use base::Process to execute scripts from admin-ops
- **Milestone**: 5.18.04 --> 5.18.12 --- ** [tickets:#2697] clm: Use base::Process to execute scripts from admin-ops** **Status:** unassigned **Milestone:** 5.18.12 **Created:** Tue Nov 21, 2017 05:15 PM UTC by Anders Widell **Last Updated:** Fri Feb 02, 2018 12:18 PM UTC **Owner:** nobody Refer to this mailing list post: [opensaf-devel](https://sourceforge.net/p/opensaf/mailman/message/36092893/) Instead of executing the custom script by calling system(), we should use the functionality provided in base/process.h. This is preferred because it executes the script with a well defined environment (only the PATH environment variable is set, with a fixed value). Otherwise, all environment variables from clmna will leak into the script. Any change in environment variables in clmna could then be a non-backwards compatible change, if the user defined script depends on the value of that variable. Another benefit of the base/process.h code is that it lets us specify a time-out. We ought to have a time-out for the script execution, and execute the script in a separate thread to avoid blocking the main thread in clmna. This could be implemented in a similar way as for executing the scale-out script in CLM. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2697 clm: Use base::Process to execute scripts from admin-ops
--- ** [tickets:#2697] clm: Use base::Process to execute scripts from admin-ops** **Status:** unassigned **Milestone:** 5.18.01 **Created:** Tue Nov 21, 2017 05:15 PM UTC by Anders Widell **Last Updated:** Tue Nov 21, 2017 05:15 PM UTC **Owner:** nobody Refer to this mailing list post: [opensaf-devel](https://sourceforge.net/p/opensaf/mailman/message/36092893/) Instead of executing the custom script by calling system(), we should use the functionality provided in base/process.h. This is preferred because it executes the script with a well defined environment (only the PATH environment variable is set, with a fixed value). Otherwise, all environment variables from clmna will leak into the script. Any change in environment variables in clmna could then be a non-backwards compatible change, if the user defined script depends on the value of that variable. Another benefit of the base/process.h code is that it lets us specify a time-out. We ought to have a time-out for the script execution, and execute the script in a separate thread to avoid blocking the main thread in clmna. This could be implemented in a similar way as for executing the scale-out script in CLM. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
