Re: [opensc-devel] [PATCH] Fix implicit declaration in Engine_pkcs11 0.1.7
Am Samstag 24 Oktober 2009 03:17:16 schrieb Arfrever Frehtes Taifersar Arahesis: > I'm attaching the patch which fixes the following warning: > > hw_pkcs11.c: In function ‘pkcs11_engine_ctrl’: > hw_pkcs11.c:146: warning: implicit declaration of function ‘set_init_args’ thanks, applied! Regards, Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
[opensc-devel] OpenSC 0.11.11 -rc2 release candidate available
Please give it a final test. http://www.opensc-project.org/files/opensc/testing/opensc-0.11.11-rc2.tar.gz -rc1 did not compile with openssl 1.0.0, so we fixed this Unless there is a big problem, the only change between -rc2 and the final release will be the version number. Regards, Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] [opensc-commits] svn opensc changed[3787] Default PCSC provider is libpcsclite.so. 1 instead of libpcsclite.so
Am Samstag 24 Oktober 2009 06:33:36 schrieb Alon Bar-Lev: > I did. > As I wrote, if upstream have parameter to customize and provide > whatever needed downstream no change is required upstream. true, we don't need to change our code if people can customize these things. but why would we want a a default that will cause problems on typical installations? I think that is a bad idea, opensc should not try to use pcsc via a name that is only resolved if the development package is installed. Thus I think the change should be kept, and it is actually an improvement. also I don't want to role -rc3 for an issue like that - people can fix it with configure flags, if they prefer "libpcsclite.so" over "libpcsclite.so.1" for some reason. but maybe I missed something, and there is a drawback to using that name, that I didn't see? Regards, Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] Release 0.12
Am Freitag 23 Oktober 2009 17:49:57 schrieb Alon Bar-Lev: > Yes. > I can work on this. > Is everything else finished and merged? > svn is difficult in merging back after file move. lets wait till we merged 0.12 and trunk. I guess martin knows best how to handle that, maybe he has a git svn, so he can merge his changes as series, but a merge as a single large diff would be ok too. (or the rm/mv combo as worst case.) for the library changes: I know what should be needed to do: move libopensc definition (for the shared lib) from src/libopensc/ to src/, and convert the libs in src/libopensc/ lib/pkcs15init/ and lib/scconf/ to noinst_ libs (see src/common/ it has already "libcommon.la" which is later included as .a archive in linking, and libtool/automake handle everything correctly. so implementation should be easy. Regards, Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] [opensc-commits] svn opensc changed[3787] Default PCSC provider is libpcsclite.so. 1 instead of libpcsclite.so
I did.
As I wrote, if upstream have parameter to customize and provide
whatever needed downstream no change is required upstream.
On Fri, Oct 23, 2009 at 9:37 PM, Ludovic Rousseau
wrote:
> 2009/10/23 Alon Bar-Lev :
>> This is invalid fix.
>
> Please justify.
>
> Read http://bugs.debian.org/511344 first.
>
>> The default should be the libpcsclite.so.
>> If you want something else use --with-pcsc-provider configure
>> parameter during packaging.
>> Please revert and notify debian to modify their packaging.
>> Thanks.
>>
>> On Fri, Oct 23, 2009 at 2:12 PM, wrote:
>>> Revision: 3787
>>> Author: ludovic.rousseau
>>> Date: 2009-10-23 12:12:40 + (Fri, 23 Oct 2009)
>>>
>>> Log Message:
>>> ---
>>> Default PCSC provider is libpcsclite.so.1 instead of libpcsclite.so
>>>
>>> See Debian bug #511344
>>>
>>> Modified Paths:
>>> --
>>> trunk/configure.ac
>>>
>>> Modified: trunk/configure.ac
>>> ===
>>> --- trunk/configure.ac 2009-10-22 18:28:25 UTC (rev 3786)
>>> +++ trunk/configure.ac 2009-10-23 12:12:40 UTC (rev 3787)
>>> @@ -587,7 +587,7 @@
>>> DEFAULT_PCSC_PROVIDER="winscard.dll"
>>> ;;
>>> *)
>>> -
>>> DEFAULT_PCSC_PROVIDER="/usr/lib${libdir##*/lib}/libpcsclite.so"
>>> +
>>> DEFAULT_PCSC_PROVIDER="/usr/lib${libdir##*/lib}/libpcsclite.so.1"
>>> ;;
>>> esac
>>> else
>>>
>>>
>>> ___
>>> opensc-commits mailing list
>>> opensc-comm...@lists.opensc-project.org
>>> http://www.opensc-project.org/mailman/listinfo/opensc-commits
>>>
>>
>
>
>
> --
> Dr. Ludovic Rousseau
>
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
[opensc-devel] [PATCH] Fix implicit declaration in Engine_pkcs11 0.1.7
I'm attaching the patch which fixes the following warning: hw_pkcs11.c: In function ‘pkcs11_engine_ctrl’: hw_pkcs11.c:146: warning: implicit declaration of function ‘set_init_args’ -- Arfrever Frehtes Taifersar Arahesis --- src/engine_pkcs11.h +++ src/engine_pkcs11.h @@ -37,6 +37,8 @@ int set_pin(const char *pin); +int set_init_args(const char *init_args_orig); + int load_cert_ctrl(ENGINE * e, void *p); int inc_verbose(void); signature.asc Description: This is a digitally signed message part. ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available
On 10/23/2009 09:26 PM, Aleksey Samsonov wrote: > Kalev Lember wrote: >> On 10/23/2009 06:10 PM, Aktiv Co. Aleksey Samsonov wrote: >>> -> #define OPENSSL_NO_EC >>> Right? >>> It is my bug. >>> Thanks! >> >> Yes, OPENSSL_NO_EC is defined in there. Thanks for taking a look. >> > > Thanks! > Fix committed to trunk. > Thanks Aleksey, builds fine now. -- Kalev Lember ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] [opensc-commits] svn opensc changed[3787] Default PCSC provider is libpcsclite.so. 1 instead of libpcsclite.so
2009/10/23 Alon Bar-Lev :
> This is invalid fix.
Please justify.
Read http://bugs.debian.org/511344 first.
> The default should be the libpcsclite.so.
> If you want something else use --with-pcsc-provider configure
> parameter during packaging.
> Please revert and notify debian to modify their packaging.
> Thanks.
>
> On Fri, Oct 23, 2009 at 2:12 PM, wrote:
>> Revision: 3787
>> Author: ludovic.rousseau
>> Date: 2009-10-23 12:12:40 + (Fri, 23 Oct 2009)
>>
>> Log Message:
>> ---
>> Default PCSC provider is libpcsclite.so.1 instead of libpcsclite.so
>>
>> See Debian bug #511344
>>
>> Modified Paths:
>> --
>> trunk/configure.ac
>>
>> Modified: trunk/configure.ac
>> ===
>> --- trunk/configure.ac 2009-10-22 18:28:25 UTC (rev 3786)
>> +++ trunk/configure.ac 2009-10-23 12:12:40 UTC (rev 3787)
>> @@ -587,7 +587,7 @@
>> DEFAULT_PCSC_PROVIDER="winscard.dll"
>> ;;
>> *)
>> -
>> DEFAULT_PCSC_PROVIDER="/usr/lib${libdir##*/lib}/libpcsclite.so"
>> +
>> DEFAULT_PCSC_PROVIDER="/usr/lib${libdir##*/lib}/libpcsclite.so.1"
>> ;;
>> esac
>> else
>>
>>
>> ___
>> opensc-commits mailing list
>> opensc-comm...@lists.opensc-project.org
>> http://www.opensc-project.org/mailman/listinfo/opensc-commits
>>
>
--
Dr. Ludovic Rousseau
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available
Kalev Lember wrote: > On 10/23/2009 06:10 PM, Aktiv Co. Aleksey Samsonov wrote: >> -> #define OPENSSL_NO_EC >> Right? >> It is my bug. >> Thanks! > > Yes, OPENSSL_NO_EC is defined in there. Thanks for taking a look. > Thanks! Fix committed to trunk. ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] [opensc-commits] svn opensc changed[3787] Default PCSC provider is libpcsclite.so. 1 instead of libpcsclite.so
This is invalid fix.
The default should be the libpcsclite.so.
If you want something else use --with-pcsc-provider configure
parameter during packaging.
Please revert and notify debian to modify their packaging.
Thanks.
On Fri, Oct 23, 2009 at 2:12 PM, wrote:
> Revision: 3787
> Author: ludovic.rousseau
> Date: 2009-10-23 12:12:40 + (Fri, 23 Oct 2009)
>
> Log Message:
> ---
> Default PCSC provider is libpcsclite.so.1 instead of libpcsclite.so
>
> See Debian bug #511344
>
> Modified Paths:
> --
> trunk/configure.ac
>
> Modified: trunk/configure.ac
> ===
> --- trunk/configure.ac 2009-10-22 18:28:25 UTC (rev 3786)
> +++ trunk/configure.ac 2009-10-23 12:12:40 UTC (rev 3787)
> @@ -587,7 +587,7 @@
> DEFAULT_PCSC_PROVIDER="winscard.dll"
> ;;
> *)
> -
> DEFAULT_PCSC_PROVIDER="/usr/lib${libdir##*/lib}/libpcsclite.so"
> +
> DEFAULT_PCSC_PROVIDER="/usr/lib${libdir##*/lib}/libpcsclite.so.1"
> ;;
> esac
> else
>
>
> ___
> opensc-commits mailing list
> opensc-comm...@lists.opensc-project.org
> http://www.opensc-project.org/mailman/listinfo/opensc-commits
>
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] Release 0.12
Yes. I can work on this. Is everything else finished and merged? svn is difficult in merging back after file move. 2009/10/23 Andreas Jellinghaus > > Am Freitag 23 Oktober 2009 11:49:20 schrieb François Leblanc: > > Does release 0.12 will have all this libraries or put in only one > > libopensc? > > IIRC the current plan is: > > opensc will still have "opensc-pkcs11.so" as we used to, > and also "libopensc.so" but for internal use only > (used by pkcs15-init etc. but not a recommended interface for > 3rd party applications). > > libscconf and libpkcs15init will be merged with libopensc. > > Andreas > ___ > opensc-devel mailing list > opensc-devel@lists.opensc-project.org > http://www.opensc-project.org/mailman/listinfo/opensc-devel ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available
On 10/23/2009 06:10 PM, Aktiv Co. Aleksey Samsonov wrote: > -> #define OPENSSL_NO_EC > Right? > It is my bug. > Thanks! Yes, OPENSSL_NO_EC is defined in there. Thanks for taking a look. -- Kalev ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available
Aktiv Co. Aleksey Samsonov: > Hello, > > Kalev Lember: >> On 10/23/2009 04:39 PM, Andreas Jellinghaus wrote: >>> Please give it a final test. >>> >>> http://www.opensc-project.org/files/opensc/testing/opensc-0.11.11-rc1.tar.gz >>> >>> >> >> Doesn't seem to compile with openssl-1.0 beta3 (distributed with Fedora >> 12, for example): >> >> /bin/sh ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. >> -I../.. -I../../src/pkcs15init -I../../src/include -pthread >> -fno-strict-aliasing -g -O2 -MT openssl.lo -MD -MP -MF .deps/openssl.Tpo >> -c -o openssl.lo openssl.c >> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. >> -I../../src/pkcs15init -I../../src/include -pthread -fno-strict-aliasing >> -g -O2 -MT openssl.lo -MD -MP -MF .deps/openssl.Tpo -c openssl.c -fPIC >> -DPIC -o .libs/openssl.o >> openssl.c:17:24: error: openssl/ec.h: No such file or directory > > Could you please send a config.log? > Thanks -> #define OPENSSL_NO_EC Right? It is my bug. Thanks! ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available
Hello, Kalev Lember: > On 10/23/2009 04:39 PM, Andreas Jellinghaus wrote: >> Please give it a final test. >> >> http://www.opensc-project.org/files/opensc/testing/opensc-0.11.11-rc1.tar.gz > > Doesn't seem to compile with openssl-1.0 beta3 (distributed with Fedora > 12, for example): > > /bin/sh ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. > -I../.. -I../../src/pkcs15init -I../../src/include -pthread > -fno-strict-aliasing -g -O2 -MT openssl.lo -MD -MP -MF .deps/openssl.Tpo > -c -o openssl.lo openssl.c > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. > -I../../src/pkcs15init -I../../src/include -pthread -fno-strict-aliasing > -g -O2 -MT openssl.lo -MD -MP -MF .deps/openssl.Tpo -c openssl.c -fPIC > -DPIC -o .libs/openssl.o > openssl.c:17:24: error: openssl/ec.h: No such file or directory Could you please send a config.log? Thanks ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available
Andreas Jellinghaus ha scritto: > Please give it a final test. > > http://www.opensc-project.org/files/opensc/testing/opensc-0.11.11-rc1.tar.gz Working here. -- Ale ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] trunk and 0.12 branch
On 10/23/2009 04:42 PM, Andreas Jellinghaus wrote: > So what will be the best way to start 0.12 development > in /trunk/? > > a) merge all changes from 0.12 branch into trunk? > (how to do that? as one big change, or as a series > of commits?) > b) svn rm /trunk/; svn mv /branches/martin/0.12 /trunk ? Option a) is probably better, because then the development history in trunk is preserved. Martin used to do his development in git. If that's still the case, it might be possible to rebase his work on top of the new changes in trunk and then merge it to svn as a series of commits. -- Kalev Lember ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available
On 10/23/2009 04:39 PM, Andreas Jellinghaus wrote: > Please give it a final test. > > http://www.opensc-project.org/files/opensc/testing/opensc-0.11.11-rc1.tar.gz Doesn't seem to compile with openssl-1.0 beta3 (distributed with Fedora 12, for example): /bin/sh ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/pkcs15init -I../../src/include -pthread -fno-strict-aliasing -g -O2 -MT openssl.lo -MD -MP -MF .deps/openssl.Tpo -c -o openssl.lo openssl.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/pkcs15init -I../../src/include -pthread -fno-strict-aliasing -g -O2 -MT openssl.lo -MD -MP -MF .deps/openssl.Tpo -c openssl.c -fPIC -DPIC -o .libs/openssl.o openssl.c:17:24: error: openssl/ec.h: No such file or directory openssl.c: In function ‘sc_pkcs11_openssl_md_final’: openssl.c:169: warning: passing argument 3 of ‘EVP_DigestFinal’ from incompatible pointer type /usr/include/openssl/evp.h:514: note: expected ‘unsigned int *’ but argument is of type ‘CK_ULONG *’ openssl.c: In function ‘gostr3410_verify_data’: openssl.c:272: error: ‘EC_POINT’ undeclared (first use in this function) openssl.c:272: error: (Each undeclared identifier is reported only once openssl.c:272: error: for each function it appears in.) openssl.c:272: error: ‘P’ undeclared (first use in this function) openssl.c:274: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token openssl.c:274: error: ‘group’ undeclared (first use in this function) make[3]: *** [openssl.lo] Error 1 make[3]: Leaving directory `/home/kalev/cvs/mingw32-opensc/devel/native/opensc-0.11.11-rc1/src/pkcs11' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/kalev/cvs/mingw32-opensc/devel/native/opensc-0.11.11-rc1/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/kalev/cvs/mingw32-opensc/devel/native/opensc-0.11.11-rc1' make: *** [all] Error 2 -- Kalev Lember ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
[opensc-devel] trunk and 0.12 branch
Hi, Martin, can you merge the latest changes in trunk into 0.12 branch? After that trunk can go and we can replace it with your 0.12 branch. If we need a 0.11 maintenance release I can branch from 0.11.11 release. So what will be the best way to start 0.12 development in /trunk/? a) merge all changes from 0.12 branch into trunk? (how to do that? as one big change, or as a series of commits?) b) svn rm /trunk/; svn mv /branches/martin/0.12 /trunk ? I have little clue what best practice is, so I'm open for opinions. Regards, Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
[opensc-devel] OpenSC 0.11.11 -rc1 release candidate available
Please give it a final test. http://www.opensc-project.org/files/opensc/testing/opensc-0.11.11-rc1.tar.gz Unless there is a big problem, the only change between -rc1 and the final release will be the version number. Regards, Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] Update to MyEID driver
Am Freitag 23 Oktober 2009 13:58:42 schrieb Aventra development: > Hi Andreas, > > Ok, attached is the new patch without the white space changes. > I hope it is the way you like it. Thanks! thanks, commited. Regards, Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] Update to MyEID driver
Hi Andreas, Ok, attached is the new patch without the white space changes. I hope it is the way you like it. Thanks! Br, Toni > -Original Message- > From: Andreas Jellinghaus [mailto:a...@dungeon.inka.de] > Sent: 22. lokakuuta 2009 21:38 > To: opensc-devel@lists.opensc-project.org > Cc: Aventra development > Subject: Re: [opensc-devel] Update to MyEID driver > > Am Mittwoch 21 Oktober 2009 12:31:31 schrieb Aventra development: > > Attached is a update to the MyEID driver. In the patch only the drivers own > > files have been updated. > > > > Also all warnings should have been fixed. The patch is done to the 0.11.10 > > release. > > thanks. can you re-do the patch using "diff -udb"? > the b) option will ignore all whitespace changes - in many places there > something with space only changed, so the diff is very hard to read. > > if you want to cleanup/unify whitespace, we can do that in a seperate > change, that does nothing but whitespace changes. (or I run indent > on the files or something like that). > > Thanks, Andreas > p.s. if you used "svn diff" - it does not support "-b" option. you can > do two new checkouts "svn co http://www.opensc-project.org/svn/opensc/trunk > opensc" and the same with "opensc.orig", then copy the modified files into > "opensc" checkout to overwrite the versions there, and then diff "opensc.orig" > against "opensc" to generate a diff with "diff -udrNPpb opensc.orig opensc" opensc-0.11.10-aventra.patch2.tar.gz Description: Binary data ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] Release 0.12
Am Freitag 23 Oktober 2009 11:49:20 schrieb François Leblanc: > Does release 0.12 will have all this libraries or put in only one > libopensc? IIRC the current plan is: opensc will still have "opensc-pkcs11.so" as we used to, and also "libopensc.so" but for internal use only (used by pkcs15-init etc. but not a recommended interface for 3rd party applications). libscconf and libpkcs15init will be merged with libopensc. Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
[opensc-devel] Release 0.12
Hi, I've seen something about the necessary of separate libraries (libscconf, libpkcs15init ) Does release 0.12 will have all this libraries or put in only one libopensc? François. ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
