Re: [opensc-devel] [opensc-commits] svn opensc changed[4268] tools: thanks to Andreas; for win32 'get password' procedure uses _getch() instead of getchar()

2010-04-28 Thread Alon Bar-Lev
And what about ./src/common/compat_getpass.c do we still need it?

On Tue, Apr 27, 2010 at 10:53 AM, Viktor TARASOV
viktor.tara...@opentrust.com wrote:

 Alon Bar-Lev wrote:
  Shouldn't you include conio.h?
 

 Agree,
 'it worked for me' compiled with Visual Studio 8.0, and I missed it.

  On Tue, Apr 27, 2010 at 10:30 AM, webmas...@opensc-project.org wrote:
 
  Revision: 4268
  Author:   viktor.tarasov
  Date:     2010-04-27 07:30:38 + (Tue, 27 Apr 2010)
 
  Log Message:
  ---
  tools: thanks to Andreas; for win32 'get password' procedure uses _getch() 
  instead of getchar()
 
  Modified Paths:
  --
     trunk/src/tools/util.c
 
  Modified: trunk/src/tools/util.c
  ===
  --- trunk/src/tools/util.c      2010-04-26 12:29:44 UTC (rev 4267)
  +++ trunk/src/tools/util.c      2010-04-27 07:30:38 UTC (rev 4268)
  @@ -295,8 +295,7 @@
                 return -1;
 
         for (i = 0; i  MAX_PASS_SIZE - 1; i++) {
  -               /* buf[i] = _getch(); */
  -               buf[i] = getchar();
  +               buf[i] = _getch();
                 if (buf[i] == 0 || buf[i] == 3)
                         return -1;
                 if (buf[i] == '\n' || buf[i] == '\r')
 
 
  ___
  opensc-commits mailing list
  opensc-comm...@lists.opensc-project.org
  http://www.opensc-project.org/mailman/listinfo/opensc-commits
 
 
 


 --
 Viktor Tarasov  viktor.tara...@opentrust.com

 ___
 opensc-devel mailing list
 opensc-devel@lists.opensc-project.org
 http://www.opensc-project.org/mailman/listinfo/opensc-devel
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Re: [opensc-devel] [opensc-commits] svn opensc changed[4268] tools: thanks to Andreas; for win32 'get password' procedure uses _getch() instead of getchar()

2010-04-28 Thread Viktor TARASOV
Alon Bar-Lev wrote:
 And what about ./src/common/compat_getpass.c do we still need it?
   

It can go, when pintest.c and pkcs15-crypt.c will use local 'getpass',
thanks.

 On Tue, Apr 27, 2010 at 10:53 AM, Viktor TARASOV
 viktor.tara...@opentrust.com wrote:
   
 Alon Bar-Lev wrote:
 
 Shouldn't you include conio.h?

   
 Agree,
 'it worked for me' compiled with Visual Studio 8.0, and I missed it.

 
 On Tue, Apr 27, 2010 at 10:30 AM, webmas...@opensc-project.org wrote:

   
 Revision: 4268
 Author:   viktor.tarasov
 Date: 2010-04-27 07:30:38 + (Tue, 27 Apr 2010)

 Log Message:
 ---
 tools: thanks to Andreas; for win32 'get password' procedure uses _getch() 
 instead of getchar()

 Modified Paths:
 --
trunk/src/tools/util.c

 Modified: trunk/src/tools/util.c
 ===
 --- trunk/src/tools/util.c  2010-04-26 12:29:44 UTC (rev 4267)
 +++ trunk/src/tools/util.c  2010-04-27 07:30:38 UTC (rev 4268)
 @@ -295,8 +295,7 @@
return -1;

for (i = 0; i  MAX_PASS_SIZE - 1; i++) {
 -   /* buf[i] = _getch(); */
 -   buf[i] = getchar();
 +   buf[i] = _getch();
if (buf[i] == 0 || buf[i] == 3)
return -1;
if (buf[i] == '\n' || buf[i] == '\r')


 ___
 opensc-commits mailing list
 opensc-comm...@lists.opensc-project.org
 http://www.opensc-project.org/mailman/listinfo/opensc-commits

 
   
 --
 Viktor Tarasov  viktor.tara...@opentrust.com

 ___
 opensc-devel mailing list
 opensc-devel@lists.opensc-project.org
 http://www.opensc-project.org/mailman/listinfo/opensc-devel
 

   


-- 
Viktor Tarasov  viktor.tara...@opentrust.com

___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel


Re: [opensc-devel] [opensc-commits] svn opensc changed[4268] tools: thanks to Andreas; for win32 'get password' procedure uses _getch() instead of getchar()

2010-04-27 Thread Alon Bar-Lev
Shouldn't you include conio.h?

On Tue, Apr 27, 2010 at 10:30 AM, webmas...@opensc-project.org wrote:

 Revision: 4268
 Author:   viktor.tarasov
 Date:     2010-04-27 07:30:38 + (Tue, 27 Apr 2010)

 Log Message:
 ---
 tools: thanks to Andreas; for win32 'get password' procedure uses _getch() 
 instead of getchar()

 Modified Paths:
 --
    trunk/src/tools/util.c

 Modified: trunk/src/tools/util.c
 ===
 --- trunk/src/tools/util.c      2010-04-26 12:29:44 UTC (rev 4267)
 +++ trunk/src/tools/util.c      2010-04-27 07:30:38 UTC (rev 4268)
 @@ -295,8 +295,7 @@
                return -1;

        for (i = 0; i  MAX_PASS_SIZE - 1; i++) {
 -               /* buf[i] = _getch(); */
 -               buf[i] = getchar();
 +               buf[i] = _getch();
                if (buf[i] == 0 || buf[i] == 3)
                        return -1;
                if (buf[i] == '\n' || buf[i] == '\r')


 ___
 opensc-commits mailing list
 opensc-comm...@lists.opensc-project.org
 http://www.opensc-project.org/mailman/listinfo/opensc-commits
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Re: [opensc-devel] [opensc-commits] svn opensc changed[4268] tools: thanks to Andreas; for win32 'get password' procedure uses _getch() instead of getchar()

2010-04-27 Thread Viktor TARASOV
Alon Bar-Lev wrote:
 Shouldn't you include conio.h?
   

Agree,
'it worked for me' compiled with Visual Studio 8.0, and I missed it.

 On Tue, Apr 27, 2010 at 10:30 AM, webmas...@opensc-project.org wrote:
   
 Revision: 4268
 Author:   viktor.tarasov
 Date: 2010-04-27 07:30:38 + (Tue, 27 Apr 2010)

 Log Message:
 ---
 tools: thanks to Andreas; for win32 'get password' procedure uses _getch() 
 instead of getchar()

 Modified Paths:
 --
trunk/src/tools/util.c

 Modified: trunk/src/tools/util.c
 ===
 --- trunk/src/tools/util.c  2010-04-26 12:29:44 UTC (rev 4267)
 +++ trunk/src/tools/util.c  2010-04-27 07:30:38 UTC (rev 4268)
 @@ -295,8 +295,7 @@
return -1;

for (i = 0; i  MAX_PASS_SIZE - 1; i++) {
 -   /* buf[i] = _getch(); */
 -   buf[i] = getchar();
 +   buf[i] = _getch();
if (buf[i] == 0 || buf[i] == 3)
return -1;
if (buf[i] == '\n' || buf[i] == '\r')


 ___
 opensc-commits mailing list
 opensc-comm...@lists.opensc-project.org
 http://www.opensc-project.org/mailman/listinfo/opensc-commits
 

   


-- 
Viktor Tarasov  viktor.tara...@opentrust.com

___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel