Re: [opensc-devel] ifd_time_elapsed magic (corrected)

[Andreas Jellinghaus]

Hi Andrey,

I think you are right! Thanks for finding, fixing and reporting.
I commited a fix.

Regards, Andreas
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

[opensc-devel] ifd_time_elapsed magic

[Andrey Jivsov]

I am looking at

long ifd_time_elapsed( struct ifd_time *then )
{
struct timeval now, delta, then_tv;

then_tv.tv_sec = then-p1;
then_tv.tv_usec = then-p2;

gettimeofday(now, NULL);
timersub(now, then_tv, delta);
return delta.tv_sec * 1000 + (delta.tv_usec % 1000);
}

what does last line do? tv_sec is in seconds and tv_usec is in 
microseconds. The sum adds milliseconds from tv_sec and lowest 1000 
microseconds. Should it be


return delta.tv_sec * 1000 + (delta.tv_usec / 1000);

instead? Thanks!
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Re: [opensc-devel] ifd_time_elapsed magic (corrected)

[Andrey Jivsov]

[corrected to the actual source from CVS]

I am looking at

long ifd_time_elapsed(struct timeval *then)
{
struct timeval now, delta;

gettimeofday(now, NULL);
timersub(now, then, delta);
return delta.tv_sec * 1000 + (delta.tv_usec % 1000);
}

what does last line do? tv_sec is in seconds and tv_usec is in 
microseconds. The sum adds milliseconds from tv_sec and lowest 1000 
microseconds. Should it be


return delta.tv_sec * 1000 + (delta.tv_usec / 1000);

instead? Thanks!
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel