Re: [opensc-devel] silent build rules for OpenSC
Hello Martin,
On Thu, 2011-06-30 at 12:56 +0300, Martin Paljak wrote:
> Tarballs builds (which also run make distcheck etc) actually should
> come with --enable-strict, which should also be the default option for
> developers. If not constantly, then every now and then. Hopefully this
> will trigger refactoring at some stage. But for everyday use the clean
> output from make is so much better - it is actually possible to notice
> issues.
please consider the inclusion of the following patch.
BTW: 'make > /dev/null' to get essential output only.
Index: configure.ac
===
--- configure.ac(revision 5569)
+++ configure.ac(working copy)
@@ -568,7 +568,7 @@
CFLAGS="${CFLAGS} -pedantic"
fi
if test "${enable_strict}" = "yes"; then
- CFLAGS="${CFLAGS} -Wall -Wextra"
+ CFLAGS="${CFLAGS} -Wall -Wextra -Wno-unused-parameter"
fi
if test "$GCC" = "yes"; then
# This should be resolved not ignored.
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] silent build rules for OpenSC
On Thu, Jun 30, 2011 at 12:45, Ludovic Rousseau wrote: > 2011/6/30 Martin Paljak : >> On Thu, Jun 30, 2011 at 12:17, Ludovic Rousseau >> wrote: >>> Hello, >>> >>> Since automake 1.11 It is possible to have silent rules. The idea is >>> to have much less noise in the console and then warnings much more >>> visible. >> >> Just saw the change in pam_pkcs11 and tried it. It is *so good*. > > I am happy you like it :-) > Jenkins build logs should be much nicer with this change. Tarballs builds (which also run make distcheck etc) actually should come with --enable-strict, which should also be the default option for developers. If not constantly, then every now and then. Hopefully this will trigger refactoring at some stage. But for everyday use the clean output from make is so much better - it is actually possible to notice issues. ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] silent build rules for OpenSC
2011/6/30 Martin Paljak : > On Thu, Jun 30, 2011 at 12:17, Ludovic Rousseau > wrote: >> Hello, >> >> Since automake 1.11 It is possible to have silent rules. The idea is >> to have much less noise in the console and then warnings much more >> visible. > > Just saw the change in pam_pkcs11 and tried it. It is *so good*. I am happy you like it :-) Jenkins build logs should be much nicer with this change. I just pushed my commit in my master branch https://github.com/LudovicRousseau/OpenSC/commit/012544463899799d24a8c0d04c02c099e62f4e68 Bye -- Dr. Ludovic Rousseau ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] silent build rules for OpenSC
On Thu, Jun 30, 2011 at 12:17, Ludovic Rousseau wrote: > Hello, > > Since automake 1.11 It is possible to have silent rules. The idea is > to have much less noise in the console and then warnings much more > visible. Just saw the change in pam_pkcs11 and tried it. It is *so good*. Martin ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
[opensc-devel] silent build rules for OpenSC
Hello,
Since automake 1.11 It is possible to have silent rules. The idea is
to have much less noise in the console and then warnings much more
visible.
Gnome has a nice page [1] to describe it.
I propose to use it for OpenSC and the other subprojects.
Proposed patch:
--- /tmp/j0T5M8_configure.ac2011-06-30 11:12:44.0 +0200
+++ configure.ac2011-06-30 11:09:19.0 +0200
@@ -29,6 +29,9 @@ OPENSC_LT_AGE="$((${OPENSC_LT_CURRENT}-$
AC_CONFIG_SRCDIR([src/libopensc/sc.c])
+# silent build by default
+m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
+
AC_CANONICAL_HOST
AC_PROG_CC
PKG_PROG_PKG_CONFIG
Bye
[1] http://live.gnome.org/GnomeGoals/NicerBuilds
--
Dr. Ludovic Rousseau
___
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
