Re: [opensc-devel] OpenSC SVN r5237 breaks support for Belgian eID
On 05/29/2011 12:35 AM, Viktor Tarasov wrote: > Hello Jean-Pierre, Frank, > > Le 27/05/2011 17:27, JP Szikora a écrit : >> Hi Viktor, >> The change that you pushed in OpenSC SVN r5237 breaks completely the >> support for Belgian eID (eidenv, pkcs15-tool, opensc-pksc11.so usage >> with Firefox is not working anymore after this revision). > > > Could you test the attached patch, please ? > Hi Viktor, Your patch solves the issue with Belgian eID with SVN-trunk or with 0.12.1. Cheers, Jean-Pierre ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC SVN r5237 breaks support for Belgian eID
Le 29/05/2011 01:00, Martin Paljak a écrit : > Hello, > On May 29, 2011, at 00:35 , Viktor Tarasov wrote: > >> Hello Jean-Pierre, Frank, >> >> Le 27/05/2011 17:27, JP Szikora a écrit : >>> Hi Viktor, >>> The change that you pushed in OpenSC SVN r5237 breaks completely the >>> support for Belgian eID (eidenv, pkcs15-tool, opensc-pksc11.so usage with >>> Firefox is not working anymore after this revision). >> >> Could you test the attached patch, please ? > Just looking at the patch file itself does not make sense to me. Shouldn't > the existing code behave exactly the same way, SC_TEST_RET should evaluate > the error and return the same way, without the now added if? > Am I missing something? The TEST_REST in this case is just the return with the message (the message can be changed) for the error that already happened -- SC_ERROR_CORRUPTED_DATA. The other errors are ignored, because there are the data that has been successfully read . (The errors are ignored for the embedded READ_BINARY, not for the first one.) > Martin > ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
Re: [opensc-devel] OpenSC SVN r5237 breaks support for Belgian eID
Hello, On May 29, 2011, at 00:35 , Viktor Tarasov wrote: > Hello Jean-Pierre, Frank, > > Le 27/05/2011 17:27, JP Szikora a écrit : >> Hi Viktor, >> The change that you pushed in OpenSC SVN r5237 breaks completely the support >> for Belgian eID (eidenv, pkcs15-tool, opensc-pksc11.so usage with Firefox is >> not working anymore after this revision). > > > Could you test the attached patch, please ? Just looking at the patch file itself does not make sense to me. Shouldn't the existing code behave exactly the same way, SC_TEST_RET should evaluate the error and return the same way, without the now added if? Am I missing something? Martin -- @MartinPaljak.net +3725156495 ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
