Time Stamp Option for xxstat Commands Phase II [PSARC/2009/307 Self Review]

2009-05-19 Thread Chad Mynhier
On Tue, May 19, 2009 at 4:10 PM, Sherry Moore  wrote:
>> Just to be clear, I'm adding these two ("dladm show-link -s -i" and
>> "flowadm show-flow -s -i") to the list of commands covered by this
>> case. ?I've been told that there's no need to update the one-pager
>> itself and that this email thread is sufficient documentation.
>
> On second thought, how about you send me an updated one with the added
> commands, I will copy it to the materials directory for your ARC case.
> Once I have copied the file (and send you the link to the file), you
> can respond the mail stating that you will add those two commands, and
> the case file has been updated and can be found where.
>

Okay, the case file has been updated with these two commands.  It can
be found here:

http://arc.opensolaris.org/caselog/PSARC/2009/307/materials/case.final.txt

Chad



Time Stamp Option for xxstat Commands Phase II [PSARC/2009/307 Self Review]

2009-05-19 Thread Chad Mynhier
On Mon, May 18, 2009 at 4:12 PM, Chad Mynhier  wrote:
> On Mon, May 18, 2009 at 6:56 AM, James Carlson  
> wrote:
>> Sherry Moore writes:
>>> ? ? ? - netstat(1M)
>> Kais Belgaied writes:
>>> will there be more follow-ons to 2009/105 for the remaining of xxstat
>>> commands?
>>> netstat, dladm show-link -s -i, flowadm show-flow -s -i, etc?
>> ?^^^
>>
>> It looks like at least one of those is being addressed.
>>
>> I think the rest would be addressed if the project team updated
>> Sowmini's CR 6782154 work, which is a common output formatter for
>> networking commands.
>
> Yes, as James pointed out, netstat was already included. ?I could
> certainly add dladm and flowadm to this list.
>

Just to be clear, I'm adding these two ("dladm show-link -s -i" and
"flowadm show-flow -s -i") to the list of commands covered by this
case.  I've been told that there's no need to update the one-pager
itself and that this email thread is sufficient documentation.

Chad



Time Stamp Option for xxstat Commands Phase II [PSARC/2009/307 Self Review]

2009-05-19 Thread Sherry Moore
> Just to be clear, I'm adding these two ("dladm show-link -s -i" and
> "flowadm show-flow -s -i") to the list of commands covered by this
> case.  I've been told that there's no need to update the one-pager
> itself and that this email thread is sufficient documentation.

On second thought, how about you send me an updated one with the added
commands, I will copy it to the materials directory for your ARC case.
Once I have copied the file (and send you the link to the file), you
can respond the mail stating that you will add those two commands, and
the case file has been updated and can be found where.

Sherry
-- 
Sherry Moore, Solaris Core Kernel   http://blogs.sun.com/sherrym



Time Stamp Option for xxstat Commands Phase II [PSARC/2009/307 Self Review]

2009-05-18 Thread Chad Mynhier
On Mon, May 18, 2009 at 6:56 AM, James Carlson  
wrote:
> Sherry Moore writes:
>> ? ? ? - netstat(1M)
> Kais Belgaied writes:
>> will there be more follow-ons to 2009/105 for the remaining of xxstat
>> commands?
>> netstat, dladm show-link -s -i, flowadm show-flow -s -i, etc?
> ?^^^
>
> It looks like at least one of those is being addressed.
>
> I think the rest would be addressed if the project team updated
> Sowmini's CR 6782154 work, which is a common output formatter for
> networking commands.

Yes, as James pointed out, netstat was already included.  I could
certainly add dladm and flowadm to this list.

In general, though, I wasn't planning on another follow-on myself.  I
added the timestamp option to those remaining xxstat commands that I
could test.  There are other xxstat commands that I didn't touch, such
as ndmpstat(1M) or dsstat(1M), because I couldn't have adequately
tested them.

Chad



Time Stamp Option for xxstat Commands Phase II [PSARC/2009/307 Self Review]

2009-05-18 Thread James Carlson
Sherry Moore writes:
>   - netstat(1M)
Kais Belgaied writes:
> will there be more follow-ons to 2009/105 for the remaining of xxstat 
> commands?
> netstat, dladm show-link -s -i, flowadm show-flow -s -i, etc?
  ^^^

It looks like at least one of those is being addressed.

I think the rest would be addressed if the project team updated
Sowmini's CR 6782154 work, which is a common output formatter for
networking commands.

-- 
James Carlson, Solaris Networking  
Sun Microsystems / 35 Network Drive71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677



Time Stamp Option for xxstat Commands Phase II [PSARC/2009/307 Self Review]

2009-05-17 Thread Kais Belgaied
On 05/15/09 16:21, Sherry Moore wrote:
> I am sponsoring this case for Chad Mynhier and closing it as approved
> automatic as it's simply a follow-on to PSARC/2009/105 to cover more
> commands.
>   


will there be more follow-ons to 2009/105 for the remaining of xxstat 
commands?
netstat, dladm show-link -s -i, flowadm show-flow -s -i, etc?

Kais.

> Thanks,
> Sherry
>   




Time Stamp Option for xxstat Commands Phase II [PSARC/2009/307 Self Review]

2009-05-15 Thread Sherry Moore
I am sponsoring this case for Chad Mynhier and closing it as approved
automatic as it's simply a follow-on to PSARC/2009/105 to cover more
commands.

Thanks,
Sherry
-- 
Sherry Moore, Solaris Core Kernel   http://blogs.sun.com/sherrym

Template Version: @(#)sac_nextcase 1.68 02/23/09 SMI
This information is Copyright 2009 Sun Microsystems
1. Introduction
1.1. Project/Component Working Name:
 Time Stamp Option for xxstat Commands Phase II
1.2. Name of Document Author/Supplier:
 Author:  Chad Mynhier
1.3  Date of This Document:
15 May, 2009
4. Technical Description
SUMMARY

This case enhances the following commands to emit a timestamp:

- auditstat(1M)
- netstat(1M)
- cpustat(1M)
- ctstat(1)
- fmstat(1M)
- nfsstat(1M)
- intrstat(1M)
- poolstat(1M)
- rcapstat(1)
- zpool(1M) (the iostat sub-command)

This case follows the precedent set by PSARC 2009/105[1] that
all "*stat" commands that print statistics at a regular
interval should implement a timestamp feature similar to the
one described here.

DETAILS

The recent putback of the fix to bug 4775687 ("would like a
timestamp option like iostat has added to mpstat, vmstat and
prstat")[2] added a timestamp option to these three commands to
match the existing functionality in iostat(1M) and fsstat(1M).
PSARC case 2009/105 set the precedent that all "*stat" commands
should include a similar option.  This case corrects the list
of commands in the summary to meet that precedent.  Note that
the timestamp will be printed with strftime(3C) using the
correct locale-specific format string.

Most of these commands will use the -T option for this
purpose.  The fmstat(1M) command has a pre-existing -T option,
so the -d ("date") option is used here instead.  This follows
the precedent of prstat(1M), which also had a pre-existing -T
option.  In either case, the option has a single one-character
argument,'u' or 'd', to specify whether the timestamp should be
printed in Unix format (i.e., seconds since epoch) or in
date(1) format.

For those cases in which a header is printed periodically, the
timestamp is printed before the header.  For example:

# ./ctstat -i 101 -T d 1 3
Wed May  6 09:05:45 EDT 2009
CTIDZONEID  TYPESTATE   HOLDER  EVENTS  QTIME   NTIME   
101 0   process owned   14  0   -   -   
Wed May  6 09:05:46 EDT 2009
CTIDZONEID  TYPESTATE   HOLDER  EVENTS  QTIME   NTIME   
101 0   process owned   14  0   -   -   
Wed May  6 09:05:47 EDT 2009
CTIDZONEID  TYPESTATE   HOLDER  EVENTS  QTIME   NTIME   
101 0   process owned   14  0   -   -   
# 

The decision to print the timestamp in this way is based on the
precedent set by iostat(1M) and was followed during the
implementation of the fix for 4775687.

EXAMPLES

This example shows the output of fmstat(1M) with a timestamp:

# ./fmstat -m disk-transport -d u 1 3
1241620519
NAME VALUEDESCRIPTION
 dropped 0number of dropped ereports

1241620520
NAME VALUEDESCRIPTION
 dropped 0number of dropped ereports

1241620521
NAME VALUEDESCRIPTION
 dropped 0number of dropped ereports
# 

This example shows the output of nfsstat(1M) with a timestamp:

# ./nfsstat -sr -T d 1 3
Wed May  6 10:38:40 EDT 2009

Server rpc:
Connection oriented:
calls  badcalls   nullrecv   badlen xdrcalldupchecks  dupreqs
0  0  0  0  0  0  0  
Connectionless:
calls  badcalls   nullrecv   badlen xdrcalldupchecks  dupreqs
0  0  0  0  0  0  0  

Wed May  6 10:38:41 EDT 2009

Server rpc:
Connection oriented:
calls  badcalls   nullrecv   badlen xdrcalldupchecks  dupreqs
0  0  0  0  0  0  0  
Connectionless:
calls  badcalls   nullrecv   badlen xdrcalldupchecks  dupreqs
0  0  0  0  0  0  0  

Wed May  6 10:38:42 EDT 2009

Server rpc:
Connection oriented:
calls  badcalls   nullrecv   badlen xdrcalldupchecks  dupreqs
0  0  0  0  0  0  0  
Connectionless:
calls  badcalls   nullrecv   badlen xdrcalldupchecks  dupreqs
0  0  0